[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

tammela added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > siger-young wrote: > > mstorsjo wrote

[Lldb-commits] [PATCH] D109263: [lldb] Update crashlog.py to accept multiple results from mdfind

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109263/new/ https://reviews.llvm.org/D109263 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D109263: [lldb] Update crashlog.py to accept multiple results from mdfind

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, clayborg. JDevlieghere requested review of this revision. mdfind can return multiple results, some of which are not even dSYM bundles, but Xcode archives (`.xcrachive). Currently, we end up concatenating the paths, which i

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

mib added a comment. In D107521#2983109 , @mib wrote: > In D107521#2983069 , @jankratochvil > wrote: > >> It broke Fedora 34 x86_64 buildbot (using gcc) lldb-x86_64-fedora = >> https://lab.llvm.org/staging/#/bui

[Lldb-commits] [lldb] 5f6f33d - [lldb/Plugins] Move member template specialization out of class

Author: Med Ismail Bennani Date: 2021-09-03T22:18:55Z New Revision: 5f6f33da9ee6cbaef5f10b4a7be34a91d5185b2b URL: https://github.com/llvm/llvm-project/commit/5f6f33da9ee6cbaef5f10b4a7be34a91d5185b2b DIFF: https://github.com/llvm/llvm-project/commit/5f6f33da9ee6cbaef5f10b4a7be34a91d5185b2b.diff

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

mib added a comment. I have a fix. I'm testing it locally before landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107521/new/ https://reviews.llvm.org/D107521 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

mib added a comment. In D107521#2983069 , @jankratochvil wrote: > It broke Fedora 34 x86_64 buildbot (using gcc) lldb-x86_64-fedora = > https://lab.llvm.org/staging/#/builders/16 - the build fails: > https://lab.llvm.org/staging/#/builders/16/builds/104

[Lldb-commits] [lldb] 05cdd29 - [lldb] Adjust parse_frames for unnamed images

Author: Jonas Devlieghere Date: 2021-09-03T13:23:24-07:00 New Revision: 05cdd294ab020b42329413ae7ab52d0c5aaf8151 URL: https://github.com/llvm/llvm-project/commit/05cdd294ab020b42329413ae7ab52d0c5aaf8151 DIFF: https://github.com/llvm/llvm-project/commit/05cdd294ab020b42329413ae7ab52d0c5aaf8151.d

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

jankratochvil added a comment. It broke Fedora 34 x86_64 buildbot (using gcc) lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 https://lab.llvm.org/staging/#/builders/16/builds/10450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1075

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

rdhindsa updated this revision to Diff 370660. rdhindsa marked an inline comment as done. rdhindsa added a comment. Added LLDB_REGISTER_METHOD for GetDescription. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109249/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

JDevlieghere added inline comments. Comment at: lldb/source/API/SBInstruction.cpp:260 +bool SBInstruction::GetDescription(lldb::SBStream &s, SBTarget target) { + LLDB_RECORD_METHOD(bool, SBInstruction, GetDescription, + (lldb::SBStream &, lldb::SBTarget), s,

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

rdhindsa created this revision. rdhindsa added reviewers: labath, clayborg. rdhindsa requested review of this revision. Herald added a project: LLDB. Add another Getdescription function for SBInstruction. When trying to print the instruction, existing GetDescription function doesn't have access

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3925204c1f58: [lldb/Plugins] Introduce Scripted Interface Factory (authored by mib). Changed prior to commit: https://reviews.llvm.org/D107521?vs=

[Lldb-commits] [lldb] 3925204 - [lldb/Plugins] Introduce Scripted Interface Factory

Author: Med Ismail Bennani Date: 2021-09-03T19:37:25+02:00 New Revision: 3925204c1f5880f491e08d8481e88342bbeb7bc4 URL: https://github.com/llvm/llvm-project/commit/3925204c1f5880f491e08d8481e88342bbeb7bc4 DIFF: https://github.com/llvm/llvm-project/commit/3925204c1f5880f491e08d8481e88342bbeb7bc4.

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107521/new/ https://reviews.llvm.org/D107521 ___

[Lldb-commits] [lldb] 5ef63c9 - [lldb] [test] Mark the remaining vfork-follow-child test unsupported (flaky) on aarch64

Author: Michał Górny Date: 2021-09-03T16:30:25+02:00 New Revision: 5ef63c953f37b878f5a39aece231aada33ee9798 URL: https://github.com/llvm/llvm-project/commit/5ef63c953f37b878f5a39aece231aada33ee9798 DIFF: https://github.com/llvm/llvm-project/commit/5ef63c953f37b878f5a39aece231aada33ee9798.diff

[Lldb-commits] [lldb] dda643c - [lldb] [test] Mark vfork-follow-child-* tests unsupported (flaky) on aarch64

Author: Michał Górny Date: 2021-09-03T16:04:34+02:00 New Revision: dda643c9fbae59a049d5499920a40455071c206c URL: https://github.com/llvm/llvm-project/commit/dda643c9fbae59a049d5499920a40455071c206c DIFF: https://github.com/llvm/llvm-project/commit/dda643c9fbae59a049d5499920a40455071c206c.diff

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec671f3ea00b: [lldb] Support .debug_rnglists.dwo sections in dwp file (authored by kimanh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [lldb] ec671f3 - [lldb] Support .debug_rnglists.dwo sections in dwp file

Author: Kim-Anh Tran Date: 2021-09-03T15:19:50+02:00 New Revision: ec671f3ea00bcbd7cca7f0d9209c9d775dd47c39 URL: https://github.com/llvm/llvm-project/commit/ec671f3ea00bcbd7cca7f0d9209c9d775dd47c39 DIFF: https://github.com/llvm/llvm-project/commit/ec671f3ea00bcbd7cca7f0d9209c9d775dd47c39.diff

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added a comment. I've split up the code that addresses the .debug_rnglists from the code that takes care of better error handling (https://reviews.llvm.org/D109231). I'll commit the reviewed part (this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D109231: [lldb] Improve error handling around GetRngListData()

kimanh created this revision. kimanh added a reviewer: jankratochvil. kimanh published this revision for review. kimanh added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I've split up the other CL (https://reviews.llvm.org/D107456) into the part that was revi

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh updated this revision to Diff 370562. kimanh added a comment. - splitting up new code (for error handling) into a different CL - keep code that was already accepted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.ll

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > This breaks building in setups wh

[Lldb-commits] [lldb] 49229bb - Revert "[lldb/lua] Force Lua version to be 5.3"

Author: Siger Yang Date: 2021-09-03T17:31:25+08:00 New Revision: 49229bb92b4ba345a414732f4e2248b44c4fcb1d URL: https://github.com/llvm/llvm-project/commit/49229bb92b4ba345a414732f4e2248b44c4fcb1d DIFF: https://github.com/llvm/llvm-project/commit/49229bb92b4ba345a414732f4e2248b44c4fcb1d.diff LO

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

mstorsjo added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > This breaks building in setups where

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

mstorsjo added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) This breaks building in setups where SWIG is available

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bb42dc6b114: [lldb/lua] Force Lua version to be 5.3 (authored by Siger Yang ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/ne

[Lldb-commits] [lldb] 7bb42dc - [lldb/lua] Force Lua version to be 5.3

Author: Siger Yang Date: 2021-09-03T15:22:57+08:00 New Revision: 7bb42dc6b114f57200abfebaaa01160914be6bba URL: https://github.com/llvm/llvm-project/commit/7bb42dc6b114f57200abfebaaa01160914be6bba DIFF: https://github.com/llvm/llvm-project/commit/7bb42dc6b114f57200abfebaaa01160914be6bba.diff LO

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added a comment. I'm sorry about looking into it this late. I've just marked them all unsupported on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___

[Lldb-commits] [lldb] 808bcb7 - [lldb] [test] Mark *fork-follow-child* tests non-Darwin

Author: Michał Górny Date: 2021-09-03T09:07:53+02:00 New Revision: 808bcb7a0ea5a897cd8311c27751504b4dd4f5a5 URL: https://github.com/llvm/llvm-project/commit/808bcb7a0ea5a897cd8311c27751504b4dd4f5a5 DIFF: https://github.com/llvm/llvm-project/commit/808bcb7a0ea5a897cd8311c27751504b4dd4f5a5.diff