[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

2021-09-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Nobody will be surprised that I like the templated solution for the dispatch method :-) A small comment similar to Jim's but otherwise this looks good to me. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.

Re: [Lldb-commits] [lldb] eee687a - [lldb] Add minidump save-core functionality to ELF object files

2021-09-01 Thread Richard Smith via lldb-commits
The new test fails under MSan: Uninitialized bytes in __interceptor_write at offset 2 inside [0x7fb1f42ed000, 18438530) ==3871==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55f5706515d9 in RetryAfterSignal llvm-project/llvm/include/llvm/Support/Errno.h:38:11 #1 0x55f5706515d9

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

2021-09-01 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Lets try again with the buildbots. The only way I can think that this would happen is if we have rendezvous entries with no names that happens in other debug sessions and that is causing new files to be loaded that we don't expect. To f

[Lldb-commits] [PATCH] D109101: [lldb] Add an option to specify a VFS overlay

2021-09-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, teemperor, labath. Herald added a subscriber: dang. JDevlieghere requested review of this revision. Add the ability to specify a VFS overlay to the command line driver. The motivation for this functionality is to

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

2021-09-01 Thread Rumeet Dhindsa via Phabricator via lldb-commits
rdhindsa added a comment. Thank you for giving it a try! It passes for me for both Release and RelWithDebInfo along with asserts enabled in each case. I can give it a try by recommitting and checking the status, this patch is in `Needs Review` status presently. Hence, requesting for a review.

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

2021-09-01 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 369949. mgorny added a comment. Rebased. Changed hw breakpoint sizes to match the normal sending code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 Files: lldb/include/lldb/Target/Process.h lldb/incl

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

2021-09-01 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:543 + bool contains_sve_reg_data = + (data_sp->GetByteSize() > (reg_data_min_size + GetSVEHeaderSize())); + omjavaid wrote: > DavidSpickett w

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

2021-09-01 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:451 Status NativeRegisterContextLinux_arm64::ReadAllRegisterValues( lldb::DataBufferSP &data_sp) { DavidSpickett wrote: > Do we need PAC re

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

2021-09-01 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:451 Status NativeRegisterContextLinux_arm64::ReadAllRegisterValues( lldb::DataBufferSP &data_sp) { Do we need PAC registers here too?

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

2021-09-01 Thread Andy Yankovsky via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeee687a66d76: [lldb] Add minidump save-core functionality to ELF object files (authored by Aj0SK, committed by werat). Repository: rG LLVM Github

[Lldb-commits] [lldb] eee687a - [lldb] Add minidump save-core functionality to ELF object files

2021-09-01 Thread Andy Yankovsky via lldb-commits
Author: Andrej Korman Date: 2021-09-01T15:14:29+02:00 New Revision: eee687a66d76bf0b6e3746f7b8d09b0d871bff27 URL: https://github.com/llvm/llvm-project/commit/eee687a66d76bf0b6e3746f7b8d09b0d871bff27 DIFF: https://github.com/llvm/llvm-project/commit/eee687a66d76bf0b6e3746f7b8d09b0d871bff27.diff

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

2021-09-01 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc56898584561: [lldb] [gdb-remote client] Remove breakpoints throughout vfork (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] c568985 - [lldb] [gdb-remote client] Remove breakpoints throughout vfork

2021-09-01 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-01T10:33:48+02:00 New Revision: c568985845618eaef97a8a07ecc879e28cd70a94 URL: https://github.com/llvm/llvm-project/commit/c568985845618eaef97a8a07ecc879e28cd70a94 DIFF: https://github.com/llvm/llvm-project/commit/c568985845618eaef97a8a07ecc879e28cd70a94.diff