[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

2021-07-17 Thread APOORV SACHAN via Phabricator via lldb-commits
apoos-maximus updated this revision to Diff 359586. apoos-maximus added a comment. reformatted code to comply with pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106226/new/ https://reviews.llvm.org/D106226 Files: lldb/source/Com

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

2021-07-17 Thread APOORV SACHAN via Phabricator via lldb-commits
apoos-maximus updated this revision to Diff 359585. apoos-maximus added a comment. realigned patch against main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106226/new/ https://reviews.llvm.org/D106226 Files: lldb/source/Commands/Command

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

2021-07-17 Thread APOORV SACHAN via Phabricator via lldb-commits
apoos-maximus updated this revision to Diff 359584. apoos-maximus added a comment. changed the code-styling to comply with pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106226/new/ https://reviews.llvm.org/D106226 Files: lldb/s

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

2021-07-17 Thread APOORV SACHAN via Phabricator via lldb-commits
apoos-maximus added reviewers: jingham, rupprecht, davide. apoos-maximus added a comment. This patch is supposed to fix this Bug : 39166 I compiled the code and used the binary with local/remote debugging scenarios. On attach failure this is the out

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

2021-07-17 Thread APOORV SACHAN via Phabricator via lldb-commits
apoos-maximus created this revision. apoos-maximus requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb attach operation fails when the ptrace() call fails on a traced process. The error reporting in this scenario could be improved by inclu

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

2021-07-17 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D106035#2885174 , @nealsid wrote: > In D106035#2879939 , @teemperor > wrote: > >> I actually expect