[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid updated this revision to Diff 359533. nealsid added a comment. Reran clang-format and removed extra braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106035/new/ https://reviews.llvm.org/D106035 Files: lldb/cmake/modules/LLDBConfig.c

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. In D106035#2879939 , @teemperor wrote: > I actually expected after the RFC that we would remove all the non-wchar > code, but this seems also fine. I think this LGTM in general, but I feel a > bit nervous about touching stuff th

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:118 + } + s.Printf("\nraw trace size %zu\n", *raw_size); + return; hanbingwang wrote: > wallace wrote: > > clayborg wrote: > > > wallace wrote: > > > > the presentat

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

aprantl added inline comments. Comment at: lldb/source/Target/ThreadPlanStack.cpp:145 - lldb::ThreadPlanSP plan_sp = std::move(m_plans.back()); + lldb::ThreadPlanSP plan_sp = m_plans.back(); + m_plans.pop_back(); Should we comment that we are intentionally m

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0aa70761b83: [trace][intel pt] Implement the Intel PT cursor (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] b0aa707 - [trace][intel pt] Implement the Intel PT cursor

Author: Walter Erquinigo Date: 2021-07-16T16:47:43-07:00 New Revision: b0aa70761b8324d0c9ebc57da58a44c9e266ce0e URL: https://github.com/llvm/llvm-project/commit/b0aa70761b8324d0c9ebc57da58a44c9e266ce0e DIFF: https://github.com/llvm/llvm-project/commit/b0aa70761b8324d0c9ebc57da58a44c9e266ce0e.di

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 359479. wallace added a comment. fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://reviews.llvm.org/D105531 Files: lldb/include/lldb/Target/Trace.h lldb/include/lldb/Target/TraceCu

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just switch all "-f" to the long option format as mentioned in inlined comments and this is good to go. Comment at: lldb/test/API/commands/trace/TestTraceDumpInstruction

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 359474. kastiglione added a comment. Also call pop_back just after retrieving back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 Files: lldb/source/Target/Th

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 359471. wallace added a comment. - Nwo using a single-step iterator method Next - Changed the direction to a boolean flag called "forwards" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://revi

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Great start! Many inlined comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1309 +FileSpec file_spec(m_content); +FileSystem::Instance().Res

[Lldb-commits] [lldb] 6eb576d - Add a mutex to guard access to the ThreadPlanStack class

Author: Jim Ingham Date: 2021-07-16T15:40:58-07:00 New Revision: 6eb576dcff45fa53e8ceb30c7648b903c1413e05 URL: https://github.com/llvm/llvm-project/commit/6eb576dcff45fa53e8ceb30c7648b903c1413e05 DIFF: https://github.com/llvm/llvm-project/commit/6eb576dcff45fa53e8ceb30c7648b903c1413e05.diff LO

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

jingham added a comment. In D106122#2884543 , @kastiglione wrote: > I believe it does need to be a reclusive mutex. Yes, I could refactor this to have a no-lock version, but I don't think it's worth complicating things. Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

kastiglione accepted this revision. kastiglione added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:113 std::unordered_map m_completed_plan_store; + mutable std::recursive_mutex m_stack_mutex; }; JDevlieghere wrote: > Does this actu

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil updated this revision to Diff 359458. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106194/new/ https://reviews.llvm.org/D106194 Files: lldb/test/Shell/ObjectFile/ELF/split-lazy-load.test lldb/test/Shell/ObjectFile/ELF/split-optimi

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil created this revision. jankratochvil added reviewers: Eric, dblaikie. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, emaste. jankratochvil requested review of this revision. Herald added a subscriber: MaskRay. D100299

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. This doesn't support remote files yet, I am still having trouble testing those. Also, there is also an unrelated clang-format change, not sure if I should revert it or keep it. Repository: rG LLVM Github Monorepo CHANGES

Re: [Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

I believe it does need to be a reclusive mutex. On Friday, July 16, 2021, Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere accepted this revision. > JDevlieghere added inline comments. > This revision is now accepted and ready to land. > > > > C

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a Create Target form for the LLDB GUI. Additionall

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:113 std::unordered_map m_completed_plan_store; + mutable std::recursive_mutex m_stack_mutex; }; --

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

kastiglione added a comment. I've also opened D106171 as a potential fix. It could be that we merge both diffs, they aren't mutually exclusive. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:157 void Clear() { -for (auto plan :

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change `ThreadPlanStack::PopPlan` and `::DiscardPlan` to not do the following: 1. Move the last p

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

hanbingwang marked 2 inline comments as done. hanbingwang added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:155 + /// If \b false, print compact stats + virtual void DumpTraceStats(Thread &thread, Stream &s, bool verbose) = 0; + clayborg w

[Lldb-commits] [lldb] adee89f - [lldb][AArch64] Add tag packing and repetition memory tag manager

Author: David Spickett Date: 2021-07-16T14:21:38+01:00 New Revision: adee89f8bcd11529bc9e046493b71fbe4b49dcd1 URL: https://github.com/llvm/llvm-project/commit/adee89f8bcd11529bc9e046493b71fbe4b49dcd1 DIFF: https://github.com/llvm/llvm-project/commit/adee89f8bcd11529bc9e046493b71fbe4b49dcd1.diff

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadee89f8bcd1: [lldb][AArch64] Add tag packing and repetition memory tag manager (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett updated this revision to Diff 359279. DavidSpickett added a comment. Correct potentitally -> potentially. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105178/new/ https://reviews.llvm.org/D105178 Files: lldb/source/Plugins/Process

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett updated this revision to Diff 359278. DavidSpickett added a comment. Account for fault addresses not being granule aligned by asking for fault_addr to fault_addr+1 which always gives you 1 tag back. (same trick we do in "memory tag read" if we only have a start address) Repository:

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Apologies, I missed the ping. A couple of minor comments otherwise this looks good to me. @omjavaid Should take a look too as he's doing/did the PAC work for Arm Linux. I figure this can go in for Mac and be made generic l

[Lldb-commits] [lldb] d046fb6 - [lldb][AArch64] Refactor memory tag range handling

Author: David Spickett Date: 2021-07-16T11:02:06+01:00 New Revision: d046fb62b7e7cd273b104fee0162725003411c00 URL: https://github.com/llvm/llvm-project/commit/d046fb62b7e7cd273b104fee0162725003411c00 DIFF: https://github.com/llvm/llvm-project/commit/d046fb62b7e7cd273b104fee0162725003411c00.diff

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd046fb62b7e7: [lldb][AArch64] Refactor memory tag range handling (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

hanbingwang updated this revision to Diff 359253. hanbingwang edited the summary of this revision. hanbingwang added a comment. 1. rename "thread trace dump stats" to "thread trace dump info" 2. Additionally, print out the tracing plugin name. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1550 +size_t tags_written = tags_vec.iov_len; +assert(tags_written && (tags_written <= num_tags)); + This assertion suggests something went wrong on ptrac