[Lldb-commits] [PATCH] D105698: [lldb/Target] Fix event handling during process launch

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This LGTM. This code is fetching events by hand off the event queue and then resending them, so it makes sense that it should stop the ones it is handling from leaking out to the Process li

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

jj10306 created this revision. jj10306 added reviewers: wallace, clayborg. Herald added subscribers: dang, mgorny. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff enables visualization of Intel PT traces by converting a su

[Lldb-commits] [lldb] d124133 - Add scoped timers to ReadMemoryFromInferior and ReadMemoryFromFileCache.

Author: Adrian Prantl Date: 2021-07-09T13:37:04-07:00 New Revision: d124133f17357536c4034cb2b2c0bec537cd8fd5 URL: https://github.com/llvm/llvm-project/commit/d124133f17357536c4034cb2b2c0bec537cd8fd5 DIFF: https://github.com/llvm/llvm-project/commit/d124133f17357536c4034cb2b2c0bec537cd8fd5.diff

[Lldb-commits] [lldb] 3338819 - [lldb] Drop REQUIRES where redundant because of lit.local.cfg

Author: Jonas Devlieghere Date: 2021-07-09T13:25:10-07:00 New Revision: 3338819b08faa7f23f65fb4e67154583984ebf5c URL: https://github.com/llvm/llvm-project/commit/3338819b08faa7f23f65fb4e67154583984ebf5c DIFF: https://github.com/llvm/llvm-project/commit/3338819b08faa7f23f65fb4e67154583984ebf5c.d

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

clayborg accepted this revision. clayborg added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105649/new/ https://reviews.llvm.org/D105649 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] 488fcea - [lldb] Use custom script instead of lldb.macosx.crashlog in test

Author: Jonas Devlieghere Date: 2021-07-09T12:42:11-07:00 New Revision: 488fcea3b552e6cbc96eb767abdfb11f4184b812 URL: https://github.com/llvm/llvm-project/commit/488fcea3b552e6cbc96eb767abdfb11f4184b812 DIFF: https://github.com/llvm/llvm-project/commit/488fcea3b552e6cbc96eb767abdfb11f4184b812.d

[Lldb-commits] [lldb] 2e3f469 - [IR] Add GEPOperator::indices() (NFC)

Author: Nikita Popov Date: 2021-07-09T21:41:20+02:00 New Revision: 2e3f4694d61dd50c8ec1278331edee84a60555f8 URL: https://github.com/llvm/llvm-project/commit/2e3f4694d61dd50c8ec1278331edee84a60555f8 DIFF: https://github.com/llvm/llvm-project/commit/2e3f4694d61dd50c8ec1278331edee84a60555f8.diff

[Lldb-commits] [lldb] c476566 - [IRForTarget] Don't pass nullptr to GetElementPtrInst::Create() (NFC)

Author: Nikita Popov Date: 2021-07-09T21:14:41+02:00 New Revision: c476566be5d025a3f122392af481a74f887911e6 URL: https://github.com/llvm/llvm-project/commit/c476566be5d025a3f122392af481a74f887911e6 DIFF: https://github.com/llvm/llvm-project/commit/c476566be5d025a3f122392af481a74f887911e6.diff

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added a comment. In D105564#2867717 , @probinson wrote: >> Currently when we have a member function that has an auto return type and >> the definition is out of line we generate two DWARF DIE. >> One for the declaration and a second one for the de

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

probinson added a comment. > Currently when we have a member function that has an auto return type and the > definition is out of line we generate two DWARF DIE. > One for the declaration and a second one for the definition, the definition > holds the deduced type but does not contain a DW_AT_na

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added a comment. @aprantl after your comments and discussion offline I changed my approach to do this lookup using the symbol table and it worked out. The main issue with the first approach was that gcc would also have to be updated in order for them to change their approach to generatin

[Lldb-commits] [PATCH] D105717: Create "thread trace dump stats" command

hanbingwang created this revision. hanbingwang added reviewers: wallace, clayborg. Herald added a subscriber: dang. hanbingwang requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the user types that command 'thread trace dump stats' and t

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 357578. shafik added reviewers: jingham, jasonmolenda. shafik added a comment. Changing approach based on Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://reviews.llvm.org/D105564 Files: lldb/source/Plugins/Expr

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9517353959b: [lldb] Add the ability to silently import scripted commands (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] f951735 - [lldb] Add the ability to silently import scripted commands

Author: Jonas Devlieghere Date: 2021-07-09T10:05:39-07:00 New Revision: f9517353959b4ef5c706e4356b56aeb9e0087584 URL: https://github.com/llvm/llvm-project/commit/f9517353959b4ef5c706e4356b56aeb9e0087584 DIFF: https://github.com/llvm/llvm-project/commit/f9517353959b4ef5c706e4356b56aeb9e0087584.d

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I kept the existing behavior everywhere except when `--silent` is passed. I also don't think "being interactive" is a good enough discriminator, I can imagine some people might want to see the work done by the script. H

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

jingham added a comment. In D105470#2866731 , @werat wrote: > Thanks for the prompt review! > >> This change is wrong for ValueObjectConstResult's. The original point of >> ValueObjectConstResult's was to store the results of expressions so that, >> eve

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett updated this revision to Diff 357500. DavidSpickett added a comment. Correct `//` to `///` in comment block for ReadMemoryTags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://reviews.llvm.org/D105630 Files: lldb/

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemoryTag.cpp:70 Process *process = m_exe_ctx.GetProcessPtr(); llvm::Expected tag_manager_or_err = +process->GetMemoryTagManager(); DavidSpickett wrote: > omjavai

[Lldb-commits] [PATCH] D105698: [lldb/Target] Fix event handling during process launch

mib created this revision. mib added a reviewer: jingham. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes process event handling when the events are broadcasted at launch. To do so, the patch introduces a new listener t

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett added a comment. > It will become a bit more complicated for a reader who have no knowledge > about memory tag range and disjoint region. I've added/updated some of the comments in `MakeTaggedRange`. Maybe you can highlight any bits that aren't clear and I'll make sure they get co

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett updated this revision to Diff 357486. DavidSpickett added a comment. Update various comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://reviews.llvm.org/D105630 Files: lldb/include/lldb/Target/MemoryTagManag

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 357478. werat added a comment. Add a test for a value created via `SBTarget::CreateValueFromData`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 357477. werat added a comment. Add a test for a value created via `SBTarget::CreateValueFromData`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat added a comment. Thanks for the prompt review! > This change is wrong for ValueObjectConstResult's. The original point of > ValueObjectConstResult's was to store the results of expressions so that, > even if the process is not at the original stop point, you could still check > the value