[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem added a comment. I had requested it and got it a short bit ago. Looks like I landed it successfully. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36597e4719e9: [lldb] Fix typos. NFC. (authored by brucem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 36597e4 - [lldb] Fix typos. NFC.

Author: Bruce Mitchener Date: 2021-05-31T06:48:57+07:00 New Revision: 36597e4719e9de6d374f7953aad83234d42ca181 URL: https://github.com/llvm/llvm-project/commit/36597e4719e9de6d374f7953aad83234d42ca181 DIFF: https://github.com/llvm/llvm-project/commit/36597e4719e9de6d374f7953aad83234d42ca181.dif

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

teemperor added a comment. I assume you don't have requested commit access yet (?) so I'm going to land this for you. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381 ___

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem updated this revision to Diff 348714. brucem added a comment. Mark as NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381 Files: lldb/docs/design/overview.rst lldb/docs/resources/test.rst ll

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem updated this revision to Diff 348713. brucem added a comment. Remove incorrect change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381 Files: lldb/docs/design/overview.rst lldb/docs/resources/t

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

lebedev.ri resigned from this revision. lebedev.ri added a comment. (removing from my queue - i don't expect to provide any review here) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942 ___

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM but could you split out the non-NFC change (and then you can also mark this whole commit as NFC). I'm just going to accept this module that change. Comment at: ll

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem created this revision. Herald added a reviewer: shafik. brucem requested review of this revision. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103381 Files: lldb/docs/design/overview.rst lldb/docs/resources/test.rst lldb/docs/status/p

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

teemperor added inline comments. Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); +} brucem wrote: > teemperor wrote: > > You need to 'instrument' these func

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

brucem added inline comments. Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); +} teemperor wrote: > You need to 'instrument' these functions. there is a too

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

teemperor added inline comments. Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); +} You need to 'instrument' these functions. there is a tool called `lldb-i

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

brucem created this revision. brucem added a reviewer: lldb-commits. brucem requested review of this revision. Herald added a project: LLDB. This is present when doing a `platform process list` and is tracked by the underlying code. To do something like the process list via the SB API in the futur