[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342650. wallace marked 12 inline comments as done. wallace added a comment. Address all comments - now the reporting timing conditions are in ProgressEvent, which simplifies the other classes - removed the progressInvalid enum by making sure only valid Progr

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:888 + // consolidated data address mask after ignoring the top byte. + if (!ReadPAuthMask().Fail()) +mask |= m_pac_mask.data_mask; DavidSpick

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid updated this revision to Diff 342608. omjavaid added a comment. This fixes review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/

[Lldb-commits] [lldb] 60ad0fd - Clarify the help for "breakpoint command add" and "watchpoint command add".

Author: Jim Ingham Date: 2021-05-03T17:22:43-07:00 New Revision: 60ad0fd3c8bf18dc1a307b97e9e3eb21dd5e4cfb URL: https://github.com/llvm/llvm-project/commit/60ad0fd3c8bf18dc1a307b97e9e3eb21dd5e4cfb DIFF: https://github.com/llvm/llvm-project/commit/60ad0fd3c8bf18dc1a307b97e9e3eb21dd5e4cfb.diff LO

[Lldb-commits] [PATCH] D101655: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d5d720df0bb: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2d5d720 - [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version

Author: Jonas Devlieghere Date: 2021-05-03T15:05:32-07:00 New Revision: 2d5d720df0bba25f1aa2cea973d3d38dc5afac45 URL: https://github.com/llvm/llvm-project/commit/2d5d720df0bba25f1aa2cea973d3d38dc5afac45 DIFF: https://github.com/llvm/llvm-project/commit/2d5d720df0bba25f1aa2cea973d3d38dc5afac45.d

[Lldb-commits] [PATCH] D101655: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101655/new/ https://reviews.llvm.org/D101655 ___ lldb-commits ma

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:266-272 + s->Printf("file = '%s', line = %u, ", +m_location_spec.GetFileSpec()

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Target/Trace.cpp:163 + /*inline_block_range*/ false, range) && +range.ContainsFileAddres

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:35 + + if (m_event_type == progressStart) +m_message = message; ==

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace updated this revision to Diff 342453. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include/lldb/Target/Trace.h lldb/source/Plugins/Trace/intel-pt/Tr

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace updated this revision to Diff 342448. wallace marked 10 inline comments as done. wallace added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342386. wallace marked 12 inline comments as done. wallace added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/l

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

omjavaid updated this revision to Diff 342357. omjavaid added a comment. This merges separate patch D99947 for Linux into this one. Linux specific changes are no longer required as we have moved mask calculation into ABISysV_arm64 class. CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers

mstorsjo added inline comments. Comment at: lldb/test/Shell/Register/Inputs/aarch64-gp-read.cpp:57 +"ldr x0, [%0, #248]\n\t" +"stp x29, x0, [sp, #-16]\n\t" +"\n\t" mgorny wrote: > mstorsjo wrote: > > I'm not quite sure what this bit a

[Lldb-commits] [PATCH] D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers

mgorny added inline comments. Comment at: lldb/test/Shell/Register/Inputs/aarch64-gp-read.cpp:57 +"ldr x0, [%0, #248]\n\t" +"stp x29, x0, [sp, #-16]\n\t" +"\n\t" mstorsjo wrote: > I'm not quite sure what this bit actually tests, with

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69a326925071: Support AArch64 PAC elf-core register read (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 69a3269 - Support AArch64 PAC elf-core register read

Author: Muhammad Omair Javaid Date: 2021-05-03T16:04:47+05:00 New Revision: 69a3269250715e31ec49be94065c1c8787a3d305 URL: https://github.com/llvm/llvm-project/commit/69a3269250715e31ec49be94065c1c8787a3d305 DIFF: https://github.com/llvm/llvm-project/commit/69a3269250715e31ec49be94065c1c8787a3d3

[Lldb-commits] [PATCH] D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers

mstorsjo added inline comments. Comment at: lldb/test/Shell/Register/Inputs/aarch64-gp-read.cpp:57 +"ldr x0, [%0, #248]\n\t" +"stp x29, x0, [sp, #-16]\n\t" +"\n\t" I'm not quite sure what this bit actually tests, with regards to inspe