[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice added a comment. I did leave 'main' in the .s file, but it's not very big. Is this ok now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice updated this revision to Diff 337622. cmtice added a comment. Update test case to use lldb on .o file and not run the inferior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

jasonmolenda added a comment. Hi Augusto, this is an interesting idea. This would simulate a slow serial connection well, but over a modern USB or Wifi or Bluetooth connection, we find the packet size is nearly irrelevant to performance -- but the number of packets is absolutely critical. If

[Lldb-commits] [PATCH] D100508: [lldb] Simplify output for skipped categories in dotest.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ce1067f2ddd: [lldb] Simplify output for skipped categories in dotest.py (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] 6ce1067 - [lldb] Simplify output for skipped categories in dotest.py

Author: Jonas Devlieghere Date: 2021-04-14T18:50:48-07:00 New Revision: 6ce1067f2ddd8623b163175ee9488673b9ced8d2 URL: https://github.com/llvm/llvm-project/commit/6ce1067f2ddd8623b163175ee9488673b9ced8d2 DIFF: https://github.com/llvm/llvm-project/commit/6ce1067f2ddd8623b163175ee9488673b9ced8d2.d

[Lldb-commits] [PATCH] D100521: [lld] Fix up code addresses in RegisterContextUnwind

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, omjavaid, justincohen. Herald added a subscriber: kristof.beyls. Herald added a reviewer: a.sidorin. JDevlieghere requested review of this revision. Call into the ABI to fixup code addresses in RegisterContextUnwind. W

[Lldb-commits] [PATCH] D100520: [lldb] Set code and data address mask from qHostInfo

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, omjavaid, justincohen. JDevlieghere requested review of this revision. Read the number of addressable bits from the qHostInfo packet and use it to set the code and data address mask in the process. https://reviews.l

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

jasonmolenda added a comment. Thanks Jonas, I think this change to Process can cover Omair's use case, where the number of bits are used hardcoded. The Darwin use case were ProcessGDBRemote, DynamicLoaderDarwinKernel, and ProcessMachCore can all set the number of bits used in addressing

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

JDevlieghere added a comment. Coincidentally, I was just in need of something similar. Jason pointed me to this discussion so I took the liberty of implementing his suggestion in D100515 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99944/new/ https:

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, omjavaid, justincohen, labath, DavidSpickett. JDevlieghere requested review of this revision. Implement Jason's suggestion from D99944 to have both a code and data mask, while still

[Lldb-commits] [lldb] ebee457 - [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash reports

Author: Shafik Yaghmour Date: 2021-04-14T16:28:38-07:00 New Revision: ebee45713190d9844ef860bf491035e3dcf3a538 URL: https://github.com/llvm/llvm-project/commit/ebee45713190d9844ef860bf491035e3dcf3a538 DIFF: https://github.com/llvm/llvm-project/commit/ebee45713190d9844ef860bf491035e3dcf3a538.dif

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added a comment. In D100338#2689846 , @augusto2112 wrote: > @jasonmolenda I've updated all the function calls to prefer the file cache > (except the one you pointed out), but I'm a little worried about this, since > I changed a lot of func

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

mgorny updated this revision to Diff 337562. mgorny added a comment. Fixed storing incorrect iterator (to temporary `info`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100418/new/ https://reviews.llvm.org/D100418 Files: lldb/include/lldb/Host/MainLoop.h lldb/source/Host/common/M

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:226 +NewSubprocess(NativeProcessProtocol *parent_process, + std::unique_ptr &child_process) = 0; }; labath wrote: > That way, the delegate _mus

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 added a comment. @jasonmolenda I've updated all the function calls to prefer the file cache (except the one you pointed out), but I'm a little worried about this, since I changed a lot of function calls. Maybe I could update the function signature to `force_live_memory` (and default

[Lldb-commits] [lldb] a749bd7 - [lldb] Add addressing_bits to KNOWN_HOST_INFO_KEYS and sort the list

Author: Jonas Devlieghere Date: 2021-04-14T14:15:17-07:00 New Revision: a749bd76394c05b423cd643633188eb09f59fbe8 URL: https://github.com/llvm/llvm-project/commit/a749bd76394c05b423cd643633188eb09f59fbe8 DIFF: https://github.com/llvm/llvm-project/commit/a749bd76394c05b423cd643633188eb09f59fbe8.d

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 updated this revision to Diff 337558. augusto2112 added a comment. Herald added subscribers: atanasyan, MaskRay, jrtc27, sdardis, emaste. Changed the approach from a target setting to updating Target::ReadMemory to prefer the file cache (if section is read-only) Repository: rG LLV

[Lldb-commits] [PATCH] D100508: [lldb] Simplify output for skipped categories in dotest.py

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I actually like the verbose output but I guess being more terse by default's fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100508/new/ https://reviews.llvm.org/D100508 ___

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100384/new/ https://reviews.llvm.org/D100384 ___

[Lldb-commits] [PATCH] D100508: [lldb] Simplify output for skipped categories in dotest.py

JDevlieghere created this revision. JDevlieghere added reviewers: labath, rupprecht, mgorny, aprantl. JDevlieghere requested review of this revision. Print a single line listing all the categories that are being skipped, rather than relying on the `check.*Support()` functions specifying why a par

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

mib updated this revision to Diff 337549. mib added a comment. Use Doxygen group comment for ScriptedProcess members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100384/new/ https://reviews.llvm.org/D100384 Files: lldb/include/lldb/Interpreter

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

mgorny updated this revision to Diff 337541. mgorny marked an inline comment as done. mgorny added a comment. Revert accidental whitespace change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100261/new/ https://reviews.llvm.org/D100261 Files: lldb/source/Plugins/Process/gdb-remote/

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

mgorny updated this revision to Diff 337539. mgorny edited the summary of this revision. mgorny added a comment. Store callbacks in `std::list`, and use the list iterator to identify the callback to remove. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100418/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 337535. mgorny marked 3 inline comments as done. mgorny added a comment. All pending changes, except for the change from `std::unique_ptr<...> &` to `std::unique_ptr<...>`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.ll

[Lldb-commits] [lldb] cc88d30 - [lldb-vscode] Reduce chattiness of progress events

Author: Walter Erquinigo Date: 2021-04-14T13:00:01-07:00 New Revision: cc88d301a0bcd8b93c632af2870503949038c87f URL: https://github.com/llvm/llvm-project/commit/cc88d301a0bcd8b93c632af2870503949038c87f DIFF: https://github.com/llvm/llvm-project/commit/cc88d301a0bcd8b93c632af2870503949038c87f.di

[Lldb-commits] [PATCH] D100443: [lldb-vscode] Reduce chattiness of progress events

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc88d301a0bc: [lldb-vscode] Reduce chattiness of progress events (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

dblaikie added a comment. In D100191#2689543 , @mgorny wrote: > In D100191#2689489 , @labath wrote: > >> We should also start thinking about tests. I suppose the smallest piece of >> functionality that could be u

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added a comment. This is it! The fruit of my labor! It feels like it's... kinda small. But I guess this is because all the groundwork has been done well, and now it's just a matter of plugging it in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Implement a new target.process.follow-fork-mode setting to control LLDB's behavior on fork. If set to 'parent', the forked child is detached and parent continues being trac

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

mgorny updated this revision to Diff 337525. mgorny added a comment. Use helper method for softbp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100267/new/ https://reviews.llvm.org/D100267 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

mgorny updated this revision to Diff 337523. mgorny added a comment. Now uses a helper function to switch breakpoints. Might not seem necessary here but the next patch makes heavy use of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100263/new/ https://reviews.llvm.org/D100263 Fil

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added a comment. In D100191#2689489 , @labath wrote: > We should also start thinking about tests. I suppose the smallest piece of > functionality that could be usefully tested (with a lldb-server test) is > debugging a process that forks, stoppin

[Lldb-commits] [lldb] 87183b1 - [lldb] Only override target arch if it is compatible

Author: Fred Riss Date: 2021-04-14T12:14:25-07:00 New Revision: 87183b1a7511f1726b0b19a2a217ed249ef3c5b9 URL: https://github.com/llvm/llvm-project/commit/87183b1a7511f1726b0b19a2a217ed249ef3c5b9 DIFF: https://github.com/llvm/llvm-project/commit/87183b1a7511f1726b0b19a2a217ed249ef3c5b9.diff LOG

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. This patch introduces a new setting on ProcessGDBRemote to allow artificially slowing down the communication betwenn lldb and the server. The new setting sleeps `PacketDelayMultiplier` nanoseconds per byte read or written in

[Lldb-commits] [lldb] 2494243 - [lldb] Move QThreadSuffixSupported and QListThreadsInStopReply into llgs

Author: Pavel Labath Date: 2021-04-14T21:08:55+02:00 New Revision: 2494243ed3f2ec2d7aba6e879fff47ff0ed71683 URL: https://github.com/llvm/llvm-project/commit/2494243ed3f2ec2d7aba6e879fff47ff0ed71683 DIFF: https://github.com/llvm/llvm-project/commit/2494243ed3f2ec2d7aba6e879fff47ff0ed71683.diff

[Lldb-commits] [lldb] ded6604 - [lldb/test] Remove the "expect_captures" feature of lldb-server tests

Author: Pavel Labath Date: 2021-04-14T21:08:55+02:00 New Revision: ded660495f4e6514823db9ebadbbfa7653c061f3 URL: https://github.com/llvm/llvm-project/commit/ded660495f4e6514823db9ebadbbfa7653c061f3 DIFF: https://github.com/llvm/llvm-project/commit/ded660495f4e6514823db9ebadbbfa7653c061f3.diff

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added a comment. We should also start thinking about tests. I suppose the smallest piece of functionality that could be usefully tested (with a lldb-server test) is debugging a process that forks, stopping after the fork, and detaching from the child. Shall we try making that work first?

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

augusto2112 created this revision. augusto2112 added reviewers: jingham, jasonmolenda, clayborg. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100500 Files: l

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2102 + if (pid == StringExtractorGDBRemote::AllProcesses) +return SendUnimplementedResponse("Selecting all processes not supported"); + if (pid == LLDB_INV

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

labath added a comment. In D100418#2689425 , @mgorny wrote: > In D100418#2689348 , @labath wrote: > >> I've been thinking about whether this should be done here, or via a separate >> multiplexer entity. It's not

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3202-3209 if (!m_current_process || (m_current_process->GetID() == LLDB_INVALID_PROCESS_ID)) { LLDB_LOGF(

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

mgorny added a comment. In D100418#2689348 , @labath wrote: > I've been thinking about whether this should be done here, or via a separate > multiplexer entity. It's not clear to me which one is cleaner so I suppose we > can go with what you have done h

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2102 + if (pid == StringExtractorGDBRemote::AllProcesses) +return SendUnimplementedResponse("Selecting all processes not supported"); + if (pid == LLDB_INV

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:226 +NewSubprocess(NativeProcessProtocol *parent_process, + std::unique_ptr &child_process) = 0; }; That way, the delegate _must_ do something

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

labath added a comment. I've been thinking about whether this should be done here, or via a separate multiplexer entity. It's not clear to me which one is cleaner so I suppose we can go with what you have done here. That said, I'm not too happy about this callback_id business. IIUC, it's only

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1314 -for line in self.res.GetOutput().splitlines(): -if 'lldb-server' in line: -pid = line.split(' ')[0] When running on a buildb

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This fixes the underlying issue for the random failure of this test on the lldb bots. The only way we get bitten here is if someone runs this on a system with smaps disabled but giv

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. AArch64 kernel builds default to having /smaps and the "VmFlags" line was added in 3.8.

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.h:129-134 + Broadcaster m_async_broadcaster; ///< The broadcaster emitting process/thread + /// state change events. + lldb::ListenerSP m_async

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 337468. DavidSpickett added a comment. - Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/sour

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 337467. DavidSpickett added a comment. - Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h lldb/in

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 337461. DavidSpickett added a comment. - Rebase onto main - skipUnlessAArch64MTELinuxCompiler was committed already so not added here, just used by the new tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 337460. DavidSpickett added a comment. - Rebase onto main Same code just moved around since qSupported parsing was refactored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llv

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 337452. DavidSpickett added a comment. - Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h l

[Lldb-commits] [PATCH] D100262: [lldb] [gdb-remote client] Support switching PID along with TID

mgorny updated this revision to Diff 337403. mgorny added a comment. Rebase on top of the refactor. Remove `m_override_pid` in favor of controlling `m_curr_pid` and `m_curr_pid_run`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100262/new/ https://reviews.llvm.org/D100262 Files: ll

[Lldb-commits] [lldb] 6cdc223 - [lldb][AArch64] Simplify MTE memory region test

Author: David Spickett Date: 2021-04-14T11:50:45+01:00 New Revision: 6cdc2239dbabeb6fb8a9f933693f744a60d50a8c URL: https://github.com/llvm/llvm-project/commit/6cdc2239dbabeb6fb8a9f933693f744a60d50a8c DIFF: https://github.com/llvm/llvm-project/commit/6cdc2239dbabeb6fb8a9f933693f744a60d50a8c.diff

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cdc2239dbab: [lldb][AArch64] Simplify MTE memory region test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97684/new/ https://

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

DavidSpickett added a comment. Going to commit this with the compiler predicate since this was accepted already and Omair has reviewed the test predicate in the other review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97684/new/ https://reviews

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

DavidSpickett updated this revision to Diff 337387. DavidSpickett added a comment. Pulling in compiler predicate from https://reviews.llvm.org/D95601 to get this landed before I attempt to fix the race condition in hasLinuxVmFlags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Refactor SetCurrentThread() and SetCurrentThreadForRun() to reduce code duplication and simplify it. Both methods now call common SendSetCurrentThreadPacket() that implemen

[Lldb-commits] [PATCH] D100447: [lldb] Silence GCC warnings about control reaching the end of non-void functions. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG127322ddebde: [lldb] Silence GCC warnings about control reaching the end of non-void… (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 127322d - [lldb] Silence GCC warnings about control reaching the end of non-void functions. NFC.

Author: Martin Storsjö Date: 2021-04-14T11:54:45+03:00 New Revision: 127322ddebde9c3a0b1cd5cdc81b36870606b4f6 URL: https://github.com/llvm/llvm-project/commit/127322ddebde9c3a0b1cd5cdc81b36870606b4f6 DIFF: https://github.com/llvm/llvm-project/commit/127322ddebde9c3a0b1cd5cdc81b36870606b4f6.diff

[Lldb-commits] [PATCH] D100447: [lldb] Silence GCC warnings about control reaching the end of non-void functions. NFC.

mstorsjo added a comment. In D100447#2688172 , @dblaikie wrote: > Looks good - thanks! Do you need me to commit this for you? Thanks, but I've got commit access! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D100447: [lldb] Silence GCC warnings about control reaching the end of non-void functions. NFC.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Do you need me to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100447/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D100447: [lldb] Silence GCC warnings about control reaching the end of non-void functions. NFC.

mstorsjo updated this revision to Diff 337366. mstorsjo added a comment. Moved unreachable to outside of switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100447/new/ https://reviews.llvm.org/D100447 Files: lldb/source/Plugins/LanguageRuntim

[Lldb-commits] [PATCH] D100447: [lldb] Silence GCC warnings about control reaching the end of non-void functions. NFC.

dblaikie added a comment. I'm guessing this change will break the build in a different way, triggering clang's -Wcovered-switch-default - the usual way this gcc/clang diagnostic pinch is resolved is by putting the unreachable after the switch/at the end of the function, instead of in a default