[Lldb-commits] [PATCH] D99828: Create setting to disable LanguageRuntime provided UnwindPlans

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. When developing LanguageRuntime plugin unwind plans, it is sometimes helpful to work with the co

[Lldb-commits] [PATCH] D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this

shafik created this revision. shafik added reviewers: jingham, jasonmolenda, aprantl. shafik requested review of this revision. When looking up user specified formatters qualifiers are removed from types before matching, I have added a clarifying example to the document and added an example to a

[Lldb-commits] [lldb] d302e33 - [LLDB] Sleep for 5 second TestVSCode_launch test_progress_events

Author: Muhammad Omair Javaid Date: 2021-04-03T03:04:37+05:00 New Revision: d302e33b9708524f79db0b3a3450b370fd9fc36f URL: https://github.com/llvm/llvm-project/commit/d302e33b9708524f79db0b3a3450b370fd9fc36f DIFF: https://github.com/llvm/llvm-project/commit/d302e33b9708524f79db0b3a3450b370fd9fc3

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:11 +# Failure was the block range 1..2 was not printed plus: +# error: DW_AT_range-DW_FORM_sec_offset.s.tmp {0x00

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 335024. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added a comment. Thanks for the review. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:489 const llvm::Optional &DWARFUnit::GetRnglist() { + if (GetVersion() >= 5 && !m_rnglist_table_done) { +m_

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. In D99426#2666141 , @abhina.sreeskantharajan wrote: > In D99426#2665361 , @aganea wrote: > >> I am still concerned by the fact that this patch doesn't fix the issue >> mentionned in https:/

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334941. abhina.sreeskantharajan retitled this revision from "[Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text" to "[SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text". abhina.

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D99426#2664883 , @abhina.sreeskantharajan wrote: > In D99426#2664841 , @MaskRay wrote: > >> /// The fil

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2665361 , @aganea wrote: > I am still concerned by the fact that this patch doesn't fix the issue > mentionned in https://reviews.llvm.org/D96363#2650460 > Was the intention to fix that issue? Will the fi

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. I am still concerned by the fact that this patch doesn't fix the issue mentionned in https://reviews.llvm.org/D96363#2650460 Was the intention to fix that issue? Will the fix be done in a subsequent patch? Comment at: llvm/lib/Support/Windows/Path.inc:1

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny marked 5 inline comments as done. mgorny added a comment. @labath, I think I've made all the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny updated this revision to Diff 334957. mgorny edited the summary of this revision. mgorny added a comment. Herald added a subscriber: arichardson. Simplified FreeBSD/NetBSD to use per-PID `waitpid()`. Removed arch restrictions from wp tests — made them consistent with Python tests. CHANGE

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/include/lldb/Host/linux/Host.h:13 +#include "llvm/ADT/Optional.h" + +#include "lldb/lldb-types.h" labath wrote: > These spaces are pretty common in lldb, but that's not actually consistent > with how the rest of llv

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny updated this revision to Diff 334947. mgorny marked 11 inline comments as done. mgorny added a comment. Update the Linux plugin and tests, mostly. TODO: FreeBSD, NetBSD and watchpoint feature for tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llv

[Lldb-commits] [lldb] 4559731 - [LLDB] Skip TestLoadUsingLazyBind.py on arm/linux

Author: Muhammad Omair Javaid Date: 2021-04-02T15:54:48+05:00 New Revision: 455973162cb98d440753fcff923793d24de00c83 URL: https://github.com/llvm/llvm-project/commit/455973162cb98d440753fcff923793d24de00c83 DIFF: https://github.com/llvm/llvm-project/commit/455973162cb98d440753fcff923793d24de00c

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334930. mgorny added a comment. Added a `skip` to the hanging new test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/