[Lldb-commits] [lldb] 38edd23 - [lldb] Fix TestAppleSimulatorOSType for older watchOS SDKs

Author: Jonas Devlieghere Date: 2021-03-26T20:28:42-07:00 New Revision: 38edd23b8cbfc46f35bb9071e86bb66c876d371c URL: https://github.com/llvm/llvm-project/commit/38edd23b8cbfc46f35bb9071e86bb66c876d371c DIFF: https://github.com/llvm/llvm-project/commit/38edd23b8cbfc46f35bb9071e86bb66c876d371c.d

[Lldb-commits] [lldb] df0f9e0 - [lldb] Stop using i386 for the watchOS simulator

Author: Jonas Devlieghere Date: 2021-03-26T17:09:45-07:00 New Revision: df0f9e044773480dbc01cf4e381af0517c930f13 URL: https://github.com/llvm/llvm-project/commit/df0f9e044773480dbc01cf4e381af0517c930f13 DIFF: https://github.com/llvm/llvm-project/commit/df0f9e044773480dbc01cf4e381af0517c930f13.d

[Lldb-commits] [lldb] 24baaad - [lldb] Remove UpdateISAToDescriptorMapFromMemory

Author: Jonas Devlieghere Date: 2021-03-26T15:40:36-07:00 New Revision: 24baaad94539553b00aceca8be5420cab943167e URL: https://github.com/llvm/llvm-project/commit/24baaad94539553b00aceca8be5420cab943167e DIFF: https://github.com/llvm/llvm-project/commit/24baaad94539553b00aceca8be5420cab943167e.d

[Lldb-commits] [PATCH] D99448: [lldb] Move UpdateISAToDescriptorMap into ClassInfoExtractor

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. Move UpdateISAToDescriptorMap into ClassInfoExtractor so that all the formerly public functions can be private and remain an implementation detail of the extractor. https

[Lldb-commits] [PATCH] D99446: [lldb] Add consistency between reading the dynamic and shared cache class info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rG645764f3aae8: [lldb] Add consistency between reading the dynamic and shared cache class info (authored

[Lldb-commits] [lldb] 645764f - [lldb] Add consistency between reading the dynamic and shared cache class info

Author: Jonas Devlieghere Date: 2021-03-26T15:19:21-07:00 New Revision: 645764f3aae83468ca6f9fbd403ab8cf03c91b5a URL: https://github.com/llvm/llvm-project/commit/645764f3aae83468ca6f9fbd403ab8cf03c91b5a DIFF: https://github.com/llvm/llvm-project/commit/645764f3aae83468ca6f9fbd403ab8cf03c91b5a.d

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

clayborg updated this revision to Diff 333640. clayborg added a comment. Simplify expression for calculating the m_next_offset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99401/new/ https://reviews.llvm.org/D99401 Files: lldb/source/Plugins/S

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:56 + if (m_header.length > 0) +m_next_offset = m_offset + *offset_ptr - m_offset + m_header.length; + else Ah yes! I will change it. Repository: rG

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

dblaikie added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:56 + if (m_header.length > 0) +m_next_offset = m_offset + *offset_ptr - m_offset + m_header.length; + else clayborg wrote: > dblaikie wrote: > > This ma

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

clayborg updated this revision to Diff 333639. clayborg added a comment. Fix issues found by JDevlieghere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99401/new/ https://reviews.llvm.org/D99401 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARF

Re: [Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

I built on mac with ASAN and ran the tests and they passed just fine. I was also able to compile on Debian linux and the tests ran ok for me. Can anyone else reproduce this failure? > On Mar 26, 2021, at 9:29 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > This test

[Lldb-commits] [PATCH] D99446: [lldb] Add consistency between reading the dynamic and shared cache class info

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h:347 + + class SharedCacheClassInfoExtractor { + public: D

[Lldb-commits] [PATCH] D99446: [lldb] Add consistency between reading the dynamic and shared cache class info

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. This adds the consistency I promised in D99315 between how we read the class info from the Objective-C runtime and the shared cache. (NFC)

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG077aa102534a: [lldb] Support lazily named classes in the Objective-C classes (authored by JDevlieghere). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 077aa10 - [lldb] Support lazily named classes in the Objective-C classes

Author: Jonas Devlieghere Date: 2021-03-26T13:34:08-07:00 New Revision: 077aa102534ac4dee2856da8b8155fbfdcb429af URL: https://github.com/llvm/llvm-project/commit/077aa102534ac4dee2856da8b8155fbfdcb429af DIFF: https://github.com/llvm/llvm-project/commit/077aa102534ac4dee2856da8b8155fbfdcb429af.d

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

justincohen marked 2 inline comments as done. justincohen added inline comments. Comment at: lldb/source/Plugins/Process/minidump/MinidumpTypes.h:113 + +struct CrashpadInfo { + llvm::support::ulittle32_t version; markmentovai wrote: > Ensure alignment is compati

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

justincohen updated this revision to Diff 333608. justincohen added a comment. Check CrashpadInfo version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98886/new/ https://reviews.llvm.org/D98886 Files: lldb/include/lldb/Target/Process.h lldb/

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. > I'm planning on moving the corresponding 3 instance variables for the shared > cache into a SharedCacheClassInfoExtractor in a follow up patch. LGTM as an intermediate step. CHANGES SINC

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.h:19 struct Header { -uint32_t length;// The total length of the entries for that set, not -// including the length field itself. -uint1

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

justincohen updated this revision to Diff 333601. justincohen added a comment. Inverted mask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98886/new/ https://reviews.llvm.org/D98886 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugin

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

clayborg added a comment. In D99401#2653285 , @dblaikie wrote: > (generally makes sense to me - but I'll leave it to some more lldb-focussed > reviewers to do more review/approval) > > Usual caveat/question: Does this take us closer or further away from u

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

dblaikie added a comment. (generally makes sense to me - but I'll leave it to some more lldb-focussed reviewers to do more review/approval) Usual caveat/question: Does this take us closer or further away from unifying this code with LLVM's libDebugInfoDWARF? (or neutral) Com

Re: [Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

I will take a look and apply this patch on my linux server and enable ASAN. Looks like lldb-vscode must be crashing from what the errors look like. > On Mar 26, 2021, at 9:29 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > This test is flaky (even after the vdso fix

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

labath added a comment. This test is flaky (even after the vdso fix by raphael), and it seems like it could be a genuine problem: http://lab.llvm.org:8011/#/builders/68/builds/9440, http://lab.llvm.org:8011/#/builders/68/builds/9409, http://lab.llvm.org:8011/#/builders/68/builds/9403, http://l

[Lldb-commits] [lldb] 5c3aed9 - [lldb] Skip TestVSCode_launch.test_progress_events on linux

Author: Pavel Labath Date: 2021-03-26T17:26:44+01:00 New Revision: 5c3aed98afda5f3016deaca4671634cee449235b URL: https://github.com/llvm/llvm-project/commit/5c3aed98afda5f3016deaca4671634cee449235b DIFF: https://github.com/llvm/llvm-project/commit/5c3aed98afda5f3016deaca4671634cee449235b.diff

[Lldb-commits] [lldb] 21589d0 - [lldb] XFAIL TestGdbRemote_vContThreads on macos

Author: Pavel Labath Date: 2021-03-26T17:26:44+01:00 New Revision: 21589d07665cc167e8ce6afa12ac8d9c972f9ce2 URL: https://github.com/llvm/llvm-project/commit/21589d07665cc167e8ce6afa12ac8d9c972f9ce2 DIFF: https://github.com/llvm/llvm-project/commit/21589d07665cc167e8ce6afa12ac8d9c972f9ce2.diff

[Lldb-commits] [lldb] 22e2d11 - [lldb] Really fix dwarf5-debug_line-file-index.s

Author: Pavel Labath Date: 2021-03-26T17:26:44+01:00 New Revision: 22e2d117d3b9f04a66e03698f930c6f9ac538d69 URL: https://github.com/llvm/llvm-project/commit/22e2d117d3b9f04a66e03698f930c6f9ac538d69 DIFF: https://github.com/llvm/llvm-project/commit/22e2d117d3b9f04a66e03698f930c6f9ac538d69.diff

[Lldb-commits] [lldb] 73cf85e - [LLDB] Skip TestVSCode_disconnect.test_launch arm/linux

Author: Muhammad Omair Javaid Date: 2021-03-26T15:54:42+05:00 New Revision: 73cf85e527f69c495daece7c74743b9073d4717c URL: https://github.com/llvm/llvm-project/commit/73cf85e527f69c495daece7c74743b9073d4717c DIFF: https://github.com/llvm/llvm-project/commit/73cf85e527f69c495daece7c74743b9073d471

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 333507. nealsid added a comment. Thanks for the review - addressed your comments here (I had to rely on Doxygen picking up the type reference automatically because I couldn't get the \see syntax to work correctly, though) Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues.

clayborg created this revision. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLVM error handling was introduced to the parsing of the .debug_aranges it would cause major issues if any DWARFDebugArangeSet::extract() calls r