[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

JDevlieghere created this revision. JDevlieghere added reviewers: friss, aprantl, jingham. JDevlieghere requested review of this revision. Generic classes in Swift have their name instantiated on request, since the vast majority never need it, and it just wastes time and memory. This results in LL

[Lldb-commits] [lldb] c4fee95 - [lldb/ObjC] Make the NonPointerIsaCache initialization lazy

Author: Fred Riss Date: 2021-03-24T20:08:06-07:00 New Revision: c4fee95746caad924cd33ace36bad44a3dbffd79 URL: https://github.com/llvm/llvm-project/commit/c4fee95746caad924cd33ace36bad44a3dbffd79 DIFF: https://github.com/llvm/llvm-project/commit/c4fee95746caad924cd33ace36bad44a3dbffd79.diff LOG

[Lldb-commits] [lldb] ff29fdf - [lldb] Format AppleObjCRuntimeV2 (NFC)

Author: Jonas Devlieghere Date: 2021-03-24T20:08:06-07:00 New Revision: ff29fdfe4e1390a99f118588b283940ef205f0a8 URL: https://github.com/llvm/llvm-project/commit/ff29fdfe4e1390a99f118588b283940ef205f0a8 DIFF: https://github.com/llvm/llvm-project/commit/ff29fdfe4e1390a99f118588b283940ef205f0a8.d

[Lldb-commits] [PATCH] D99314: [lldb] Add IsSafeToCallAPI to DynamicLoader

JDevlieghere created this revision. JDevlieghere added reviewers: friss, aprantl, jingham. JDevlieghere requested review of this revision. On Darwin based systems, lldb will get notified by dyld before it itself finished initializing, at which point it's not safe to call certain APIs or SPIs. Ad

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, This is where the

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

aprantl added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9505 +void *opaque_decl_ctx, ConstString *instance_var_name_ptr, +bool *instance_is_pointer_ptr) { if (opaque_decl_ctx) { Another nicer way to implement

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/test/Shell/Subprocess/fork-follow-parent.test:6 +process launch +# CHECK: function run in child +# CHECK-NOT: function run in parent The tests sometimes fail if child starts after the breakpoint is hit (and therefor

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny updated this revision to Diff 333124. mgorny added a comment. Also add clone+watchpoint test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/include/lldb/Host/linux/Ho

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny updated this revision to Diff 333122. mgorny added a comment. Handle `clone(2)` for new process as well (and add a test for it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 333114. mib marked an inline comment as done. mib added a comment. Addressing @stella.stamenova feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/incl

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:114 + create_python_package( +${swig_target} stella.stamenova wrote: > How is this different than the package on line 107? This might have been copied twice ... getting rid of it.

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should f

[Lldb-commits] [lldb] fad34da - Revert "[lldb/Plugins] Add ScriptedProcess Process Plugin"

Author: Med Ismail Bennani Date: 2021-03-24T21:31:16+01:00 New Revision: fad34da7fdcd2f6e60920ca1e6d290f8e53ec315 URL: https://github.com/llvm/llvm-project/commit/fad34da7fdcd2f6e60920ca1e6d290f8e53ec315 DIFF: https://github.com/llvm/llvm-project/commit/fad34da7fdcd2f6e60920ca1e6d290f8e53ec315.

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:114 + create_python_package( +${swig_target} How is this different than the package on line 107? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe122877f1098: Add a progress class that can track long running ope

[Lldb-commits] [lldb] e122877 - Add a progress class that can track long running operations in LLDB.

Author: Greg Clayton Date: 2021-03-24T12:58:13-07:00 New Revision: e122877f10988d791cd7d7cd667ce17febec3a16 URL: https://github.com/llvm/llvm-project/commit/e122877f10988d791cd7d7cd667ce17febec3a16 DIFF: https://github.com/llvm/llvm-project/commit/e122877f10988d791cd7d7cd667ce17febec3a16.diff

[Lldb-commits] [lldb] 3fd7d0d - Disable the tests except on Darwin.

Author: Jim Ingham Date: 2021-03-24T12:19:18-07:00 New Revision: 3fd7d0d281a9b1dc7a8352cbd29178cbfacc73f1 URL: https://github.com/llvm/llvm-project/commit/3fd7d0d281a9b1dc7a8352cbd29178cbfacc73f1 DIFF: https://github.com/llvm/llvm-project/commit/3fd7d0d281a9b1dc7a8352cbd29178cbfacc73f1.diff LO

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny updated this revision to Diff 333064. mgorny retitled this revision from "[lldb] [Process/Linux] Watch for fork notifications" to "[lldb] [Process/Linux] Watch for fork/vfork notifications". mgorny edited the summary of this revision. mgorny added a comment. Included `vfork()`. Still have

[Lldb-commits] [lldb] c8faa8c - Make the stop-on-sharedlibrary-events setting work.

Author: Jim Ingham Date: 2021-03-24T11:15:11-07:00 New Revision: c8faa8c2669c1867ef6ac33466f219a39d5faaa7 URL: https://github.com/llvm/llvm-project/commit/c8faa8c2669c1867ef6ac33466f219a39d5faaa7 DIFF: https://github.com/llvm/llvm-project/commit/c8faa8c2669c1867ef6ac33466f219a39d5faaa7.diff LO

[Lldb-commits] [lldb] 13bb39a - [NFC][LLDB] Removing extra semicolons to silence -Wc++98-compat-extra-semi diagnostics

Author: Shafik Yaghmour Date: 2021-03-24T19:10:58+01:00 New Revision: 13bb39aad347712b7d9b1dddcd142d066ac72d13 URL: https://github.com/llvm/llvm-project/commit/13bb39aad347712b7d9b1dddcd142d066ac72d13 DIFF: https://github.com/llvm/llvm-project/commit/13bb39aad347712b7d9b1dddcd142d066ac72d13.dif

[Lldb-commits] [lldb] b09d44b - [lldb/Plugins] Add ScriptedProcess Process Plugin

Author: Med Ismail Bennani Date: 2021-03-24T19:10:58+01:00 New Revision: b09d44b6ae0901865a0d4b2a0cf797c3cd34eeeb URL: https://github.com/llvm/llvm-project/commit/b09d44b6ae0901865a0d4b2a0cf797c3cd34eeeb DIFF: https://github.com/llvm/llvm-project/commit/b09d44b6ae0901865a0d4b2a0cf797c3cd34eeeb.

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added a comment. With the help of @teemperor, I was able to test that my latest changes work on Linux with and without enabling python for lldb. I'll re-land the patch and monitor the bots to make sure there is no other issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 333054. mib marked 2 inline comments as done. mib added a reviewer: teemperor. mib added a comment. Enable `ScriptedProcess` process plugin only when `LLDB_ENABLE_PYTHON` is true. This should fix the test failures that happen when python support is disabled. Re

[Lldb-commits] [lldb] 41454c3 - Updated LLDB for the new Clang Language enumerator 'OpenCLCXX'

Author: Dmitri Gribenko Date: 2021-03-24T16:46:02+01:00 New Revision: 41454c30f6a38c3e107d857e63da0561610fd141 URL: https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141 DIFF: https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141.dif

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

teemperor added a comment. In D95713#2647722 , @davezarzycki wrote: > In D95713#2647548 , @teemperor wrote: > >> The tests are failing because Dave's bot is running without enabled Python. >> The same is true for

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should fix t

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

teemperor added a comment. The tests are failing because Dave's bot is running without enabled Python. The same is true for the Windows bot. Putting the plugin behind `#ifdef LLDB_ENABLE_PYTHON` should fix this. FWIW, even with enabled Python this seems to have some minor problems with command

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added a comment. In D95713#2647241 , @davezarzycki wrote: > I've reverted this. If you need help debugging this, please let me know. > Also, as a reminder, please see the attached build log from earlier in the > conversation. Thanks! @davezarzycki

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib closed this revision. mib added a comment. Landed in 3e0ad115439622b9c3e6ca9fd64c7fb07a679f1a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95710/new/ https://reviews.llvm.org/D95710

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/MemoryBuffer.h:78-80 /// if successful, otherwise returning null. If FileSize is specified, this /// means that the client knows th

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

jhenderson added a comment. Overall, this seems reasonable to me. I have a slight concern that it might cause surprising failures for downstream users, that aren't picked up at build time (due to implicit conversions), but I don't think you need to worry too much about that.

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332720. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. After going through all the function usages, I realized FileSize is not used anywhere. I can remove this parameter. Repository: r

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332946. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. I've removed FileSize from getFileAux and WritableMemoryBuffer::getFile as well. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. I've reverted this. If you need help debugging this, please let me know. Also, as a reminder, please see the attached build log from earlier in the conversation. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[Lldb-commits] [lldb] 952bc6c - Revert "[lldb/Plugins] Add ScriptedProcess Process Plugin"

Author: David Zarzycki Date: 2021-03-24T07:07:22-04:00 New Revision: 952bc6c92e21414bcafa6bd85bce0e7f79ddc856 URL: https://github.com/llvm/llvm-project/commit/952bc6c92e21414bcafa6bd85bce0e7f79ddc856 DIFF: https://github.com/llvm/llvm-project/commit/952bc6c92e21414bcafa6bd85bce0e7f79ddc856.diff

[Lldb-commits] [lldb] c68a645 - [lldb] Add llgs_test decorator back to TestAutoInstallMainExecutable

Author: Raphael Isemann Date: 2021-03-24T10:36:01+01:00 New Revision: c68a645acb833109f4bb0d859686b05a81b2be7d URL: https://github.com/llvm/llvm-project/commit/c68a645acb833109f4bb0d859686b05a81b2be7d DIFF: https://github.com/llvm/llvm-project/commit/c68a645acb833109f4bb0d859686b05a81b2be7d.dif

[Lldb-commits] [lldb] 3bc65a9 - Handle a LC_NOTE main bin spec for user process corefiles

Author: Jason Molenda Date: 2021-03-24T02:18:17-07:00 New Revision: 3bc65a946ebef55cee2d1e151977a570d32a2b23 URL: https://github.com/llvm/llvm-project/commit/3bc65a946ebef55cee2d1e151977a570d32a2b23 DIFF: https://github.com/llvm/llvm-project/commit/3bc65a946ebef55cee2d1e151977a570d32a2b23.diff

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for the delay! > It seems like the pre-merge check failures are because I incorrectly set the > project repo when I first created the revision. I noticed in the build >