kimanh created this revision.
kimanh added reviewers: labath, jasonmolenda.
kimanh added a project: LLDB.
Herald added subscribers: JDevlieghere, arphaman.
kimanh requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: lldb-commits, sstefan1.
SymbolFileDWAR
Author: Pavel Labath
Date: 2021-03-14T22:43:52+01:00
New Revision: 463863fffea5c26b0410ee030205fc6bf066f763
URL:
https://github.com/llvm/llvm-project/commit/463863fffea5c26b0410ee030205fc6bf066f763
DIFF:
https://github.com/llvm/llvm-project/commit/463863fffea5c26b0410ee030205fc6bf066f763.diff
labath added a comment.
I'm still bugged by the GetPidTid interface -- the pair of optionals is very
complicated. What if we had this function take a `default_pid` argument (which
would be equal to the currently selected process), and it returned that as the
process id, in case the packet does
labath added a comment.
Thanks. This looks much better, but there is still one thing which bugs me
about the register info constructor. Currently, there are three paths through
that constructor:
1. when we don't have any fancy registers (this is the original one)
2. when we have just SVE (added