[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 329834. nealsid added a comment. Fix regression introduced by removing return statement in case where we were able to format a function name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://re

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid planned changes to this revision. nealsid added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1560 } -return true; } Sorry, just caught this. Am uploading a new diff shortly. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 08d33aa - [nfc] [lldb] Remove variable ranges_base in DWARFUnit::AddUnitDIE

Author: Jan Kratochvil Date: 2021-03-10T23:36:07+01:00 New Revision: 08d33aa6807d998ef777a4e6d56b629878d0e73b URL: https://github.com/llvm/llvm-project/commit/08d33aa6807d998ef777a4e6d56b629878d0e73b DIFF: https://github.com/llvm/llvm-project/commit/08d33aa6807d998ef777a4e6d56b629878d0e73b.diff

[Lldb-commits] [PATCH] D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf36998694f: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction… (authored by kastiglione). Repository: rG LLVM Github

[Lldb-commits] [lldb] daf3699 - [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC)

Author: Dave Lee Date: 2021-03-10T14:15:54-08:00 New Revision: daf36998694fd9a0beaf7e1659ae41a6d1079107 URL: https://github.com/llvm/llvm-project/commit/daf36998694fd9a0beaf7e1659ae41a6d1079107 DIFF: https://github.com/llvm/llvm-project/commit/daf36998694fd9a0beaf7e1659ae41a6d1079107.diff LOG:

[Lldb-commits] [lldb] ac29c35 - [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

Author: Vedant Kumar Date: 2021-03-10T13:57:10-08:00 New Revision: ac29c35207a506eedaaea8a4196b83facbf978da URL: https://github.com/llvm/llvm-project/commit/ac29c35207a506eedaaea8a4196b83facbf978da DIFF: https://github.com/llvm/llvm-project/commit/ac29c35207a506eedaaea8a4196b83facbf978da.diff

[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac29c35207a5: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC (authored by vsk). Changed prior to commit: https://review

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. Herald added a subscriber: JDevlieghere. Hi @teemperor , here's an attempt to fix `SBValue::Persist` method. I've highlighted a few moments in the patch I'm not so sure about, please let me know what you think. Thanks! Comment at: lldb/source/Expression

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat created this revision. werat added a reviewer: teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Right now `SBValue::Persist()` works properly only for values that refere to variables (refer to unit-tests for an exampl

[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98272/new/ https://reviews.llvm.org/D98272 _

[Lldb-commits] [PATCH] D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ignore `-Wreturn-type-c-linkage` diagnostics for `LLDBSwigPythonBreakpointCallbackFunction`. The fu

[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

vsk updated this revision to Diff 329733. vsk added a comment. Use a helper function, respect the force argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98272/new/ https://reviews.llvm.org/D98272 Files: lldb/source/Plugins/Platform/MacOSX

[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

vsk added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:534 +if (arch && arch->IsValid() && !arch->TripleEnvironmentWasSpecified()) + return nullptr; // Avoid very slow xcrun query for non-simulator archs. llvm::StringRe

[Lldb-commits] [PATCH] D96916: [lldb] Fix PushPlan to set subplan to private

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG354d10530d26: [lldb] Fix PushPlan to set subplan to private (autho

[Lldb-commits] [lldb] 354d105 - [lldb] Fix PushPlan to set subplan to private

Author: Dave Lee Date: 2021-03-10T11:05:33-08:00 New Revision: 354d10530d267838a08bf0a27b1bdf69fd99086e URL: https://github.com/llvm/llvm-project/commit/354d10530d267838a08bf0a27b1bdf69fd99086e DIFF: https://github.com/llvm/llvm-project/commit/354d10530d267838a08bf0a27b1bdf69fd99086e.diff LOG:

[Lldb-commits] [PATCH] D96916: [lldb] Fix PushPlan to set subplan to private

kastiglione added a comment. Jim previously approved this offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96916/new/ https://reviews.llvm.org/D96916 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG771c4c9cf6be: [lldb] [Process/FreeBSD] Introduce aarch64 hw break/watchpoint support (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 771c4c9 - [lldb] [Process/FreeBSD] Introduce aarch64 hw break/watchpoint support

Author: Michał Górny Date: 2021-03-10T18:36:19+01:00 New Revision: 771c4c9cf6be9f0b1e6e1d9f3e5063d0c3e6086b URL: https://github.com/llvm/llvm-project/commit/771c4c9cf6be9f0b1e6e1d9f3e5063d0c3e6086b DIFF: https://github.com/llvm/llvm-project/commit/771c4c9cf6be9f0b1e6e1d9f3e5063d0c3e6086b.diff

[Lldb-commits] [lldb] f47a84b - [lldb] [test] Update XFAILs for FreeBSD/aarch64

Author: Michał Górny Date: 2021-03-10T18:36:19+01:00 New Revision: f47a84bc335775273688b76df8ddc7daae7f132e URL: https://github.com/llvm/llvm-project/commit/f47a84bc335775273688b76df8ddc7daae7f132e DIFF: https://github.com/llvm/llvm-project/commit/f47a84bc335775273688b76df8ddc7daae7f132e.diff

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > omjavaid wrote: > > DavidSpickett wrote: > > > DavidSpickett wrote: > > > > DavidSpickett wr