[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

labath added a comment. In D96778#2595162 , @jankratochvil wrote: > In D96778#2595110 , > @stella.stamenova wrote: > >> What is the actual test requirement? > > It requires x86_64 (it is incompatible with x86_32)

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

jankratochvil updated this revision to Diff 327364. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97721/new/ https://reviews.llvm.org/D97721 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp lldb/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [lldb] 4fd3347 - [lldb] Fix typos in documentation (NFC)

Author: Kazu Hirata Date: 2021-03-01T23:40:29-08:00 New Revision: 4fd3347d6e4b0c873c789528e1c9a1b55990d1b6 URL: https://github.com/llvm/llvm-project/commit/4fd3347d6e4b0c873c789528e1c9a1b55990d1b6 DIFF: https://github.com/llvm/llvm-project/commit/4fd3347d6e4b0c873c789528e1c9a1b55990d1b6.diff L

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. This is fully hooked up and working in Visual Studio Code now! Works well. The Visual Studio Code shows any progress that takes more than 0.5 seconds down in the bottom toolbar for me. We can and should discuss these changes now that they are working. Repository: r

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 327357. clayborg added a comment. Herald added a subscriber: arphaman. Added a more granular progress when manaully indexing the DWARF where we report on unit of progress for parsing all dies in a unit, and one unit of progress for indexing each compile uni

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid added a comment. In D50299#2596141 , @JDevlieghere wrote: > In D50299#2596008 , @nealsid wrote: > >> Removed comment on #include line and organized the #includes to match coding >> guidelines better (I was

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. Forgot to mention I added a lldb-vscode implementation after someone told me they now support progress reporting in Visual Studio Code. See https://microsoft.github.io/debug-adapter-protocol/specification#Events_ProgressStart Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 327339. clayborg added a comment. Added a "uint64_t progress_id;" as a member variable of the lldb_private::Progress class to help users track individual progress dialogs without conflict. Prior to this the message was assumed to be unique. Added code to e

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. In D97739#2596218 , @jingham wrote: > I haven't thought about the details of this implementation closely yet. How > will this handled nested progress bars? For instance, if I'm Indexing (maybe > even on multiple threads) and t

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added a comment. I haven't thought about the details of this implementation closely yet. How will this handled nested progress bars? For instance, if I'm Indexing (maybe even on multiple threads) and then one of the threads results in a debug symbols fetch request (e.g. dsymForUUID).

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Progress.h:19 +public: + Progress(uint64_t total, const char *format, ...) + __attribute__((format(printf, 3, 4))); clayborg wrote: > JDevlieghere wrote: > > I'm not a fan of how we'rere-imp

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Progress.h:1 +//===-- Progress.h --*- C++ -*-===// +// JDevlieghere wrote: > I think this belongs more in Utility than Core. I can move this. It used

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

JDevlieghere added a comment. In D50299#2596008 , @nealsid wrote: > Removed comment on #include line and organized the #includes to match coding > guidelines better (I wasn't sure about whether the project uses blank lines > in between #includes from dif

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

JDevlieghere added a comment. Very cool, this is something I have wanted for a long time. Another really good use case here would be `dSYMForUUID` which can take such a long time that people think the debugger hangs. I think this will be really powerful on the command line too if we can hook th

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid updated this revision to Diff 327317. nealsid added a comment. Removed comment on #include line and organized the #includes to match coding guidelines better (I wasn't sure about whether the project uses blank lines in between #includes from different subproject like lldb/clang/llvm so I

[Lldb-commits] [lldb] 5de2d18 - [Diagnose] Unify MCContext and LLVMContext diagnosing

Author: Yuanfang Chen Date: 2021-03-01T15:58:37-08:00 New Revision: 5de2d189e6ad466a1f0616195e8c524a4eb3cbc0 URL: https://github.com/llvm/llvm-project/commit/5de2d189e6ad466a1f0616195e8c524a4eb3cbc0 DIFF: https://github.com/llvm/llvm-project/commit/5de2d189e6ad466a1f0616195e8c524a4eb3cbc0.diff

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. Another thing to clarify: The current design of the Progress objects, when destructed, will report progress with the stored "m_total" value to indicate that the progress is complete. Even if exceptions are thrown, the destructor will still be called. So all current use

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Progress.h:33 + std::atomic m_completed; + const uint64_t m_total; +}; shafik wrote: > Maybe I am misunderstanding but if we are going to have a total are we also > going to variable to keep tr

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

shafik added inline comments. Comment at: lldb/include/lldb/Core/Progress.h:33 + std::atomic m_completed; + const uint64_t m_total; +}; Maybe I am misunderstanding but if we are going to have a total are we also going to variable to keep track of the expected

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added a comment. The current Progress class allows users to specify how many items are to be done when they construct a lldb_private::Progress object, but this part is not used right now for anything yet because it is often hard to know how many items of work there are. For symbol tabl

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327304. ychen added a comment. - Remove dead code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/include/clang/Basic/DiagnosticCategories.td clang/inclu

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added a comment. In D97449#2595415 , @MaskRay wrote: > LG. Can you attach an example triggering clang `InlineAsmDiagHandler2`? I > want to check what the diagnostics look like before and now. `clang/test/CodeGen/asm-errors.c` should trigger it. R

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/include/llvm/MC/MCContext.h:67 class SourceMgr; + template class function_ref; With `std::function`, this can be dropped. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG801067f4c09b: [mlir][lldb] Fix several gcc warnings in mlir and lldb (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

stella.stamenova added inline comments. Comment at: lldb/source/Commands/CommandObjectTrace.cpp:119 lldb::TraceSP trace_sp = traceOrErr.get(); - if (m_options.m_verbose) + if (m_options.m_verbose && trace_sp) result.AppendMessageWithFormat("loading trace

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327300. ychen added a comment. - Revert to use std::function since MCContext needs to own the handler callback - Fix a typo in BackendConsumer::SrcMgrDiagHandler: DI.getKind() -> DI.getSeverity() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:22 def note_fe_inline_asm_here : Note<"instantiated into assembly here">; +def err_fe_source_mgr : Error<"%0">, CatSourceMgr; +def warn_fe_source_mgr : Warning<"%0">, CatSourceMgr, InG

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 __

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:869 +SMLoc Loc, +std::function GetMessage) { + SourceMgr SM; MaskRay wrote: > ychen wrote: > > MaskRay wrote: > > > Use lightweight function_ref since you don't need to store the callback

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. LG. Can you attach an example triggering clang `InlineAsmDiagHandler2`? I want to check what the diagnostic looks like now. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:22 def note_fe_inline_asm_here : Note<"instantiated into assem

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327256. ychen added a comment. - Use function_ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/include/clang/Basic/DiagnosticCategories.td clang/inclu

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added a comment. In D97449#2595390 , @MaskRay wrote: > Is the https://github.com/ClangBuiltLinux/linux/issues/1269 unreachable error > fixed? > > Reproduce: > > git clone https://android.googlesource.com/kernel/common.git --branch > android-4.19-

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. Is the https://github.com/ClangBuiltLinux/linux/issues/1269 unreachable error fixed? Reproduce: git clone https://android.googlesource.com/kernel/common.git --branch android-4.19-stable cd common PATH=path/to/your/clang/bin:$PATH make -s -j 30 LLVM=1 O=/tmp/out/a

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327162. ychen added a comment. - Use StringRef::consume_front Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/include/clang/Basic/DiagnosticCategories.td

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327155. ychen added a comment. - Add clang Diagnostic Category/Group/Kinds for SourceMgr errors - Add comments in MCContext - Simplify Clang handler - Implement DiagnosticInfoSrcMgr::print - Simplify DiagnosticInfoSrcMgr ctor Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:870 +std::function GetMessage) { + SourceMgr SM; + const SourceMgr *SMP = &SM; MaskRay wrote: > This looks a bit strange: we need to construct a fresh SourceMgr to print a > diagnostic. I'v

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:477 + StringRef Message = D.getMessage(); + if (Message.startswith("error: ")) +Message = Message.substr(7); MaskRay wrote: > `StringRef::consume_front` > > I know you are moving

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib added a comment. I reverted the ScriptedProcess patches since they caused test failures on the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 ___ lldb

[Lldb-commits] [PATCH] D97739: Add a progress class that can track long running operations in LLDB.

clayborg added a comment. So this is a first pass on adding progress notifications to the LLDB public API, and to see how it would be used internally. If we can agree on the implementation, then I will add full tests and documentation to this diff. We used a similar patch to this in an older in

[Lldb-commits] [PATCH] D97739: Add a progress class that can track long running operations in LLDB.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, jingham, jasonmolenda. Herald added subscribers: jfb, mgorny, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. LLDB can often a

[Lldb-commits] [lldb] 36254f1 - [lldb] Revert ScriptedProcess patches

Author: Med Ismail Bennani Date: 2021-03-01T23:23:27Z New Revision: 36254f1a0f32e8a1db353efbe1f8c3a290e5b084 URL: https://github.com/llvm/llvm-project/commit/36254f1a0f32e8a1db353efbe1f8c3a290e5b084 DIFF: https://github.com/llvm/llvm-project/commit/36254f1a0f32e8a1db353efbe1f8c3a290e5b084.diff

[Lldb-commits] [lldb] 6dbea3e - [lldb] Add scoped timer to HostInfoMacOSX::GetXcodeSDKPath

Author: Jonas Devlieghere Date: 2021-03-01T14:57:42-08:00 New Revision: 6dbea3efc519756663fc38828f370da6d2f3e2ff URL: https://github.com/llvm/llvm-project/commit/6dbea3efc519756663fc38828f370da6d2f3e2ff DIFF: https://github.com/llvm/llvm-project/commit/6dbea3efc519756663fc38828f370da6d2f3e2ff.d

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib added a comment. In D95711#2595801 , @stella.stamenova wrote: > In D95711#2595566 , @mib wrote: > >> In D95711#2595458 , >> @stella.stamenova wrote: >> >>> This does no

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

stella.stamenova added a comment. In D95711#2595566 , @mib wrote: > In D95711#2595458 , > @stella.stamenova wrote: > >> This does not build on the Windows bot: >> >> https://lab.llvm.org/buildbot/#/builders/83/buil

[Lldb-commits] [lldb] 801067f - [mlir][lldb] Fix several gcc warnings in mlir and lldb

Author: Stella Stamenova Date: 2021-03-01T13:48:22-08:00 New Revision: 801067f4c09bb8c3b625991c5adcb69b58eabaa1 URL: https://github.com/llvm/llvm-project/commit/801067f4c09bb8c3b625991c5adcb69b58eabaa1 DIFF: https://github.com/llvm/llvm-project/commit/801067f4c09bb8c3b625991c5adcb69b58eabaa1.di

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib added a comment. In D95711#2595458 , @stella.stamenova wrote: > This does not build on the Windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/4214 Should be fixed with 5a9c34918bb1526b7e8c29aa5e4fb8d8e27e27b4

[Lldb-commits] [lldb] 5a9c349 - [lldb/Plugins] Fix SWIGPythonBridge build issue

Author: Med Ismail Bennani Date: 2021-03-01T22:37:36+01:00 New Revision: 5a9c34918bb1526b7e8c29aa5e4fb8d8e27e27b4 URL: https://github.com/llvm/llvm-project/commit/5a9c34918bb1526b7e8c29aa5e4fb8d8e27e27b4 DIFF: https://github.com/llvm/llvm-project/commit/5a9c34918bb1526b7e8c29aa5e4fb8d8e27e27b4.

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib added a comment. In D95711#2595458 , @stella.stamenova wrote: > This does not build on the Windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/4214 Looking ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

stella.stamenova added a comment. This does not build on the Windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/4214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 ___

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: grimar, labath. jankratochvil added a project: LLVM. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: LLDB. LLDB has been failing on

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. In D96778#2595162 , @jankratochvil wrote: > In D96778#2595110 , > @stella.stamenova wrote: > >> What is the actual test requirement? > > It requires x86_64 (it is incompatible wit

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46796762afe7: [lldb/Plugins] Add ScriptedProcess Process Plugin (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cff3dec1171: [lldb/bindings] Add Python ScriptedProcess base class to lldb module (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG182f0d1a3441: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess (authored by mib). Changed prior to commit: https://reviews.llv

[Lldb-commits] [lldb] 4679676 - [lldb/Plugins] Add ScriptedProcess Process Plugin

Author: Med Ismail Bennani Date: 2021-03-01T21:13:32+01:00 New Revision: 46796762afe76496ec4dd900f64d0cf4cdc30e99 URL: https://github.com/llvm/llvm-project/commit/46796762afe76496ec4dd900f64d0cf4cdc30e99 DIFF: https://github.com/llvm/llvm-project/commit/46796762afe76496ec4dd900f64d0cf4cdc30e99.

[Lldb-commits] [lldb] 2cff3de - [lldb/bindings] Add Python ScriptedProcess base class to lldb module

Author: Med Ismail Bennani Date: 2021-03-01T21:13:32+01:00 New Revision: 2cff3dec1171188ce04ab1a4373cc1885ab97be1 URL: https://github.com/llvm/llvm-project/commit/2cff3dec1171188ce04ab1a4373cc1885ab97be1 DIFF: https://github.com/llvm/llvm-project/commit/2cff3dec1171188ce04ab1a4373cc1885ab97be1.

[Lldb-commits] [lldb] 182f0d1 - [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

Author: Med Ismail Bennani Date: 2021-03-01T21:13:31+01:00 New Revision: 182f0d1a34419445bb19d67581d6ac1afc98b7fa URL: https://github.com/llvm/llvm-project/commit/182f0d1a34419445bb19d67581d6ac1afc98b7fa DIFF: https://github.com/llvm/llvm-project/commit/182f0d1a34419445bb19d67581d6ac1afc98b7fa.

[Lldb-commits] [lldb] d62a53a - [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

Author: Med Ismail Bennani Date: 2021-03-01T21:13:31+01:00 New Revision: d62a53aaf1d38a55d1affbd3a30d564a4e9d3171 URL: https://github.com/llvm/llvm-project/commit/d62a53aaf1d38a55d1affbd3a30d564a4e9d3171 DIFF: https://github.com/llvm/llvm-project/commit/d62a53aaf1d38a55d1affbd3a30d564a4e9d3171.

[Lldb-commits] [lldb] 103ad3f - [lldb/Commands] Fix short option collision for `process launch`

Author: Med Ismail Bennani Date: 2021-03-01T21:13:31+01:00 New Revision: 103ad3f90708eceddd9fea484ce82354e5a9d62d URL: https://github.com/llvm/llvm-project/commit/103ad3f90708eceddd9fea484ce82354e5a9d62d DIFF: https://github.com/llvm/llvm-project/commit/103ad3f90708eceddd9fea484ce82354e5a9d62d.

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib added a comment. Hey @labath! I'm going to land this patch but I'm happy to iterate over it if you have more feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://reviews.llvm.org/D95712 _

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2595110 , @stella.stamenova wrote: > What is the actual test requirement? It requires x86_64 (it is incompatible with x86_32) and hopefully it is OS-agnostic (after fixing the %clang_host). Repository: rG LLV

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! Comment at: lldb/include/lldb/Host/Editline.h:60 #include "lldb/Utility/Predicate.h" +#include "lldb/Utility/StringList.h" // for StringList CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. It has been now reverted until the testcase gets resolved: https://github.com/llvm/llvm-project/commit/011e7bcaa3194ed4ca3fec48263f5ef69fc1813c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews

[Lldb-commits] [lldb] 011e7bc - Revert "[lldb] Fix handling of `DW_AT_decl_file` according to D91014"

Author: Jan Kratochvil Date: 2021-03-01T20:45:30+01:00 New Revision: 011e7bcaa3194ed4ca3fec48263f5ef69fc1813c URL: https://github.com/llvm/llvm-project/commit/011e7bcaa3194ed4ca3fec48263f5ef69fc1813c DIFF: https://github.com/llvm/llvm-project/commit/011e7bcaa3194ed4ca3fec48263f5ef69fc1813c.diff

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. Considering this broke two bots, you might want to commit a fix or revert soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 327216. mib added a comment. Add support for loading a corefile. Fix incomplete scripted process instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lld

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. In D96778#2594405 , @jankratochvil wrote: > @stella.stamenova It failed on a Windows box: > https://lab.llvm.org/buildbot/#/builders/83/builds/4202 > > $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" > "--ta

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015d78a25e51: [lldb] Remove XPCServices symlinking (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 015d78a - [lldb] Remove XPCServices symlinking

Author: Shoaib Meenai Date: 2021-03-01T11:23:46-08:00 New Revision: 015d78a25e510a6ff512d562b4e062d16c4afc78 URL: https://github.com/llvm/llvm-project/commit/015d78a25e510a6ff512d562b4e062d16c4afc78 DIFF: https://github.com/llvm/llvm-project/commit/015d78a25e510a6ff512d562b4e062d16c4afc78.diff

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

clayborg added a comment. In D97644#2593228 , @jasonmolenda wrote: > Another alternative to RegisterContext::BehavesLikeZerothFrame that I've > thought of is RegisterContext::GetPCForSymbolication, similar to GetPC() > today. I think everyone who is de

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97701/new/ https://reviews.llvm.org/D97701 ___ lldb

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

smeenai added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147 + add_custom_command(TARGET liblldb POST_BUILD +COMMAND ${CMAKE_COMMAND} -E create_symlink +Versions/Current/XPCServices +${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LL

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

smeenai created this revision. smeenai added reviewers: vsk, JDevlieghere. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a downstream change that was accidentally included upstream. Rep

[Lldb-commits] [lldb] 776be16 - Fix virtual-dtor warning a different way, since a virtual dtor is not required for this use case.

Author: David Blaikie Date: 2021-03-01T09:25:26-08:00 New Revision: 776be16ba0532dbb3d66cc104d15a7f13a154e3f URL: https://github.com/llvm/llvm-project/commit/776be16ba0532dbb3d66cc104d15a7f13a154e3f DIFF: https://github.com/llvm/llvm-project/commit/776be16ba0532dbb3d66cc104d15a7f13a154e3f.diff

[Lldb-commits] [lldb] e913a75 - Fix a warning about named return value not being moved-from.

Author: David Blaikie Date: 2021-03-01T09:25:26-08:00 New Revision: e913a754143f227b4aea5f695a2dcd2349101886 URL: https://github.com/llvm/llvm-project/commit/e913a754143f227b4aea5f695a2dcd2349101886 DIFF: https://github.com/llvm/llvm-project/commit/e913a754143f227b4aea5f695a2dcd2349101886.diff

[Lldb-commits] [PATCH] D97696: [lldb] Enable cross CU decl file test only for x64 Linux

werat created this revision. werat added reviewers: jankratochvil, teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix tests after https://reviews.llvm.org/D96778 Repository: rG LLVM Github Monorepo https://reviews.llv

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat added a comment. The test was also executed on `lldb-aarch64-ubuntu` -- https://lab.llvm.org/buildbot/#/changes/13868 But we have `REQUIRES: x86`, shouldn't it exclude ARM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://rev

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a subscriber: stella.stamenova. jankratochvil added a comment. @stella.stamenova It failed on a Windows box: https://lab.llvm.org/buildbot/#/builders/83/builds/4202 $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" "--target=specify-a-target-or-use-a-_host-substitu

[Lldb-commits] [PATCH] D97450: [lldb] [test] Skip AVX lldb-server test on non-x86 architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rG95a1305fb405: [lldb] [test] Skip AVX lldb-server test on non-x86 architectures (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f067f1c79f: [lldb] [test] Workaround symlink-related test failures (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86

This revision was automatically updated to reflect the committed changes. Closed by commit rGc41372c8a1db: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86 (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D97210?vs=325506&id=32710

[Lldb-commits] [lldb] c41372c - [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86

Author: Michał Górny Date: 2021-03-01T16:23:36+01:00 New Revision: c41372c8a1db8fa0bfda25daeca1f5f4f5145439 URL: https://github.com/llvm/llvm-project/commit/c41372c8a1db8fa0bfda25daeca1f5f4f5145439 DIFF: https://github.com/llvm/llvm-project/commit/c41372c8a1db8fa0bfda25daeca1f5f4f5145439.diff

[Lldb-commits] [lldb] 15f067f - [lldb] [test] Workaround symlink-related test failures

Author: Michał Górny Date: 2021-03-01T16:23:36+01:00 New Revision: 15f067f1c79fac34910eaf50f612854eb1d58bb5 URL: https://github.com/llvm/llvm-project/commit/15f067f1c79fac34910eaf50f612854eb1d58bb5 DIFF: https://github.com/llvm/llvm-project/commit/15f067f1c79fac34910eaf50f612854eb1d58bb5.diff

[Lldb-commits] [lldb] 95a1305 - [lldb] [test] Skip AVX lldb-server test on non-x86 architectures

Author: Michał Górny Date: 2021-03-01T16:23:36+01:00 New Revision: 95a1305fb4058ef4925fea181f4664ce266337d6 URL: https://github.com/llvm/llvm-project/commit/95a1305fb4058ef4925fea181f4664ce266337d6 DIFF: https://github.com/llvm/llvm-project/commit/95a1305fb4058ef4925fea181f4664ce266337d6.diff

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec7876feda4: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 7ec7876 - [lldb] Fix handling of `DW_AT_decl_file` according to D91014

Author: Andy Yankovsky Date: 2021-03-01T16:01:11+01:00 New Revision: 7ec7876feda412b6edad0d83565395ef2fd5a004 URL: https://github.com/llvm/llvm-project/commit/7ec7876feda412b6edad0d83565395ef2fd5a004 DIFF: https://github.com/llvm/llvm-project/commit/7ec7876feda412b6edad0d83565395ef2fd5a004.diff

[Lldb-commits] [PATCH] D97684: [lldb][AArch64] Simplify MTE memory region test

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. By checking for cpu and toolchain features ahead of time we don't need the custom return

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added a comment. In D95602#2593980 , @omjavaid wrote: > I guess we also need LLDB API interface for reading/writing memory tags. So > that we can do something like process.ReadMemoryTags() from python. Do you > plan on adding it in a later

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. Having a canonical bug for the symlink issue would be reasonable too... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97230/new/ https://reviews.llvm.org/D97230 _

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

omjavaid added a comment. I guess we also need LLDB API interface for reading/writing memory tags. So that we can do something like process.ReadMemoryTags() from python. Do you plan on adding it in a later patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, + lldb::addr_t addr2) const {

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added a comment. This looks good overall except for one comment inline. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, +

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 327062. DavidSpickett added a comment. Update after changing previous patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLi

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett updated this revision to Diff 327061. DavidSpickett added a comment. Rename to be AArch64 specific. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97284/new/ https://reviews.llvm.org/D97284 Files: lldb/packages/Python/lldbsuite/test

[Lldb-commits] [lldb] 99c24f7 - [lldb/Interpreter] Pacify -Wnon-virtual-dtor

Author: Benjamin Kramer Date: 2021-03-01T11:20:14+01:00 New Revision: 99c24f7aa8ccb84abde1672255439a2b2730ccc1 URL: https://github.com/llvm/llvm-project/commit/99c24f7aa8ccb84abde1672255439a2b2730ccc1 DIFF: https://github.com/llvm/llvm-project/commit/99c24f7aa8ccb84abde1672255439a2b2730ccc1.dif

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

shafik added a comment. lldb change LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97586/new/ https://reviews.llvm.org/D97586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

teemperor added inline comments. Comment at: lldb/source/Commands/CommandObjectTrace.cpp:119 lldb::TraceSP trace_sp = traceOrErr.get(); - if (m_options.m_verbose) + if (m_options.m_verbose && trace_sp) result.AppendMessageWithFormat("loading trace with p