[Lldb-commits] [lldb] 45db9d4 - [test] Fix unused FileCheck prefixes in lldb

Author: Fangrui Song Date: 2021-02-01T21:45:51-08:00 New Revision: 45db9d4594bdbb4a304c16f6ad61b87c60eeb300 URL: https://github.com/llvm/llvm-project/commit/45db9d4594bdbb4a304c16f6ad61b87c60eeb300 DIFF: https://github.com/llvm/llvm-project/commit/45db9d4594bdbb4a304c16f6ad61b87c60eeb300.diff

[Lldb-commits] [lldb] ecb00a7 - [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

Author: Nathan Hawes Date: 2021-02-02T14:56:17+10:00 New Revision: ecb00a77624c94ce38fccf9b4095e026ecf14aed URL: https://github.com/llvm/llvm-project/commit/ecb00a77624c94ce38fccf9b4095e026ecf14aed DIFF: https://github.com/llvm/llvm-project/commit/ecb00a77624c94ce38fccf9b4095e026ecf14aed.diff

[Lldb-commits] [PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecb00a77624c: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to… (authored by nathawes). Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

jingham added a comment. I'm not quite sure why we need the extra m_scripted_process boolean. Seems like you could key off whether we had a non-empty class_name. Is there any case where you would want to boolean set w/o having a class name yet? Comment at: lldb/include/lldb

[Lldb-commits] [PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 320646. nathawes added a comment. Made the following changes as a speculative fix for the windows test failures in the pre-merge checks: - When appending the remaining path components to the external redirect path of a directory-remap entry, use the separa

[Lldb-commits] [lldb] fbd5507 - [lldb] Use the host architecture in TestAppleSimulatorOSType.py

Author: Jonas Devlieghere Date: 2021-02-01T16:18:31-08:00 New Revision: fbd55071788a3e57d2fdf8cad5c79ee45a273019 URL: https://github.com/llvm/llvm-project/commit/fbd55071788a3e57d2fdf8cad5c79ee45a273019 DIFF: https://github.com/llvm/llvm-project/commit/fbd55071788a3e57d2fdf8cad5c79ee45a273019.d

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione added inline comments. Comment at: lldb/test/API/python_api/frame/TestFrames.py:97 sp_value, "We should have a valid Stack Pointer.") -self.assertTrue(int(sp_value.GetValue(), 0) == frame.GetSP( +self.assertEqual(in

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool, I was under the impression @teemperor had already done something similar, but I must be misremembering. Comment at: lldb/test/API/python_api/frame/TestFram

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

vsk added inline comments. Comment at: lldb/include/lldb/Host/ProcessLaunchInfo.h:188 + bool m_scripted_process; + llvm::StringRef m_scripted_process_class_name; + StructuredData::DictionarySP m_scripted_process_dictionary_sp; Might be best to use a std::strin

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione added a comment. I haven't run tests yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95813/new/ https://reviews.llvm.org/D95813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert `assertTrue(a == b)` to `assertEqual(a, b)` to produce better failure messages. T

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 320560. tatyana-krasnukha added a comment. Removed test since the same case was added by D95761 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 Files: lldb/inc

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 320548. tatyana-krasnukha edited the summary of this revision. tatyana-krasnukha added a comment. It turns out that the Debugger recalculated the selected stack frame without taking the Process's run lock. I replaced the whole context evaluation wit

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

mgorny updated this revision to Diff 320524. mgorny added a comment. Remove `#if 0`s. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/ https://reviews.llvm.org/D95802 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugins/Process/FreeBSDRemote/C

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

mgorny created this revision. mgorny added reviewers: krytarowski, emaste, labath. Herald added subscribers: atanasyan, arichardson, sdardis. mgorny requested review of this revision. Introduce mips64 support to match the legacy FreeBSD plugin. This includes support for software single stepping t

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

jingham added a comment. I think it's fine to fall back to the "currently selected target" if the command interpreter doesn't have a current execution context, that should not be your first choice. For instance, if you are running this command in a Python breakpoint callback, then the current

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

JDevlieghere added a comment. Can you add a test for this too? I assume I would look very similar to the example. Maybe have one that checks the base class and one that overrides it with some known values. Comment at: lldb/bindings/python/python-scripted-process.swig:1 +%pyth

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBData.h:129 + lldb::DataExtractorSP GetOpaque() const; + You cannot expose non-SB classes in public methods because that would make them part of the API. Comment at: ll

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro updated this revision to Diff 320483. djtodoro added a comment. - Test update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp lldb/test/API/functionalities/postmortem/el

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro added a comment. > Another option would be to ditch disassembling, and check this via memory > reads, as that is what you are actually fixing +1, nice! thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 __

[Lldb-commits] [lldb] ee562e2 - [lldb/test] Skip `SBTarget::IsLoaded` test on windows (NFC)

Author: Med Ismail Bennani Date: 2021-02-01T14:09:50+01:00 New Revision: ee562e2315cfe339fdcb0cb9b2122284bbeda29b URL: https://github.com/llvm/llvm-project/commit/ee562e2315cfe339fdcb0cb9b2122284bbeda29b DIFF: https://github.com/llvm/llvm-project/commit/ee562e2315cfe339fdcb0cb9b2122284bbeda29b.

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG754ab803b8dc: [lldb] Use current execution context in SBDebugger (authored by werat, committed by teemperor). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 754ab80 - [lldb] Use current execution context in SBDebugger

Author: Andy Yankovsky Date: 2021-02-01T13:12:42+01:00 New Revision: 754ab803b8dc659e3645d369d1b5d6d2f97be29e URL: https://github.com/llvm/llvm-project/commit/754ab803b8dc659e3645d369d1b5d6d2f97be29e DIFF: https://github.com/llvm/llvm-project/commit/754ab803b8dc659e3645d369d1b5d6d2f97be29e.diff

[Lldb-commits] [lldb] 11e74e5 - [lldb] Remove a stray semicolon, fixing GCC warnings. NFC.

Author: Martin Storsjö Date: 2021-02-01T13:45:07+02:00 New Revision: 11e74e512d64ae2a2531156b6f0dde211b1ae19d URL: https://github.com/llvm/llvm-project/commit/11e74e512d64ae2a2531156b6f0dde211b1ae19d DIFF: https://github.com/llvm/llvm-project/commit/11e74e512d64ae2a2531156b6f0dde211b1ae19d.diff

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

werat added a comment. Thanks for the review! Can you submit it for me, since I don't have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95761/new/ https://reviews.llvm.org/D95761 ___ lld

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

mib closed this revision. mib marked 3 inline comments as done. mib added a comment. Landed in b8923c002207da449ec462ade468e27a651b1f91 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] b8923c0 - [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

Author: Med Ismail Bennani Date: 2021-02-01T12:16:33+01:00 New Revision: b8923c002207da449ec462ade468e27a651b1f91 URL: https://github.com/llvm/llvm-project/commit/b8923c002207da449ec462ade468e27a651b1f91 DIFF: https://github.com/llvm/llvm-project/commit/b8923c002207da449ec462ade468e27a651b1f91.

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95761/new/ https://reviews.llvm.org/D95761 __

[Lldb-commits] [lldb] 94fac81 - [Branch-Rename] Fix some links

Author: xgupta Date: 2021-02-01T16:43:21+05:30 New Revision: 94fac81fccfef9917e94bed398781744fb82e159 URL: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159 DIFF: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159.diff LOG: [

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. some minor things in the comments, otherwise LGTM Comment at: lldb/bindings/interface/SBTarget.i:946 + +:param module: `SBModule` that should be loaded in this `SBT

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

mib updated this revision to Diff 320425. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95686/new/ https://reviews.llvm.org/D95686 Files: lldb/bindings/interface/SBTarget.i lldb/include/lldb/API/SBTarget.h lldb/source/API/SBTarget.cpp lldb/t

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

mib updated this revision to Diff 320424. mib added a comment. Add positive test case and update assert message to be more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95686/new/ https://reviews.llvm.org/D95686 Files: lldb/bindings

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

mib updated this revision to Diff 320420. mib edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95686/new/ https://reviews.llvm.org/D95686 Files: lldb/bindings/interface/SBTarget.i lldb/include/lldb/API/SBTarget.

[Lldb-commits] [lldb] 2939d2e - [lldb][docs] Attempt to disable the generated GitHub button on the LLDB website

Author: Raphael Isemann Date: 2021-02-01T09:47:39+01:00 New Revision: 2939d2e1b46c05432864db333ca3d5cb7ab83533 URL: https://github.com/llvm/llvm-project/commit/2939d2e1b46c05432864db333ca3d5cb7ab83533 DIFF: https://github.com/llvm/llvm-project/commit/2939d2e1b46c05432864db333ca3d5cb7ab83533.dif