[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

2021-01-31 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid marked an inline comment as done. omjavaid added a comment. @labath I have made suggested adjustment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

2021-01-31 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 320373. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h lldb/source/Plugins/P

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

2021-01-31 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf43c0707f66a: [lldb] [Process/FreeBSDRemote] Introduce arm64 support (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

2021-01-31 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG9d029362d1ed: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://

[Lldb-commits] [lldb] 9d02936 - [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

2021-01-31 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-01-31T19:52:08+01:00 New Revision: 9d029362d1ed48c38565aeab0ca04bf4143d3e5b URL: https://github.com/llvm/llvm-project/commit/9d029362d1ed48c38565aeab0ca04bf4143d3e5b DIFF: https://github.com/llvm/llvm-project/commit/9d029362d1ed48c38565aeab0ca04bf4143d3e5b.diff

[Lldb-commits] [lldb] f43c070 - [lldb] [Process/FreeBSDRemote] Introduce arm64 support

2021-01-31 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-01-31T19:52:08+01:00 New Revision: f43c0707f66a19236f58f5bd8be470e5fc625603 URL: https://github.com/llvm/llvm-project/commit/f43c0707f66a19236f58f5bd8be470e5fc625603 DIFF: https://github.com/llvm/llvm-project/commit/f43c0707f66a19236f58f5bd8be470e5fc625603.diff

[Lldb-commits] [PATCH] D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

2021-01-31 Thread Michał Górny via Phabricator via lldb-commits
mgorny marked an inline comment as done. mgorny added a comment. Thanks for the review! Fixed the `virtual` and rebased, will test now and push if it still builds ;-). Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.h:88 +protected: + virtual llvm::

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

2021-01-31 Thread Andy Yankovsky via Phabricator via lldb-commits
werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use `GetSelectedExecutionContext()` instead of `GetCommandInterpreter().GetExecutionContext()` in `SBDebugger::GetInternalVariableValue/SBDebugger::SetInte

[Lldb-commits] [PATCH] D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

2021-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.h:88 +protected: + virtual llvm::Expected> + GetSoftwareBreakpointTrapOpcode(size_t size_hint

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

2021-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me (and sorry about the delay). There are some defensive checks that I think could be upgraded to asserts (or even deleted), but these are consistent with the other register

Re: [Lldb-commits] Performing ManualDWARFIndex::Index() async during ManualDWARFIndex::Preload()

2021-01-31 Thread Pavel Labath via lldb-commits
On 29/01/2021 16:25, Lasse Folger via lldb-commits wrote: > Hi lldb devs, > > We experienced some issues when debugging large binaries. > The startup time of lldb for large binaries is long (tens of seconds). > One of the reasons is that the /ManualDWARFIndex::Index()/ function is > executed synch

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

2021-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:404 reg = reg_info->invalidate_regs[++idx]) { +uint32_t lldb_regnum = ConvertRegisterKindToRegisterNumber( +eRegisterKindProc

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

2021-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I think that's because lldb's dissassembler currently just stops when it encounters an unknown/invalid instruction :(, so it doesn't even get to the interesting part. If I skip over the random bytes I get: (lldb) disassemble --start 0x400ff0 --end 0x40100c 0x400f

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

2021-01-31 Thread Pavel Labath via lldb-commits
On 25/01/2021 05:30, David Blaikie wrote: On Fri, Jan 22, 2021 at 5:37 AM Pavel Labath > wrote: On 19/01/2021 23:23, David Blaikie wrote: > On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath mailto:pa...@labath.sk>> wrote: > Yeah - I have mixed feelings about d