wallace updated this revision to Diff 315655.
wallace added a comment.
improve tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93951/new/
https://reviews.llvm.org/D93951
Files:
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode
wallace updated this revision to Diff 315652.
wallace added a comment.
Addressed all comments:
- Now using a single file for all the communication. Did indeed simplified a
lot of code
- Now adding timeouts to Send operations. This will help prevent the adaptor
from undefinitely waiting for the
tammela added inline comments.
Comment at:
lldb/test/Shell/ScriptInterpreter/Lua/breakpoint_function_callback.test:15
+r
+# CHECK:
+breakpoint command add -s lua -o "abc(frame, bp_loc, ...)"
JDevlieghere wrote:
> Can we unpack the SBStructuredData and check for
jasonmolenda created this revision.
jasonmolenda added a project: LLDB.
Herald added a subscriber: JDevlieghere.
jasonmolenda requested review of this revision.
It can be tricky to find the important error messages when debugserver tries to
launch or attach to a process in the system console log.