augusto2112 added a comment.
Hi @labath. Ok, I believe the test is passing now. Thank you for all the help
today!
Question: the original author left a TODO:
// TODO: Make the polling interval configurable
std::chrono::milliseconds waitfor_interval = std::chrono::seconds(1);
Is this a lot
augusto2112 updated this revision to Diff 314231.
augusto2112 added a comment.
Re-include deleted files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93895/new/
https://reviews.llvm.org/D93895
Files:
lldb/source/Plugins/Process/gdb-remote/GDBRe
augusto2112 updated this revision to Diff 314230.
augusto2112 added a comment.
Update test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93895/new/
https://reviews.llvm.org/D93895
Files:
lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.p
labath added a comment.
Have you by any chance learned why are we zero-filling this buffer in the first
place? Seems like an odd thing to do... Maybe we should just stop zero-filling
completely?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93939/
labath added a comment.
The new version seems ok-ish to me, but I'm leaving it open as I'd like Jim to
weigh in here. The immediate cause of the crash is related to the (dangling?)
m_thread pointer inside the completed "step instruction" plan. Normally, this
pointer clears itself when the threa
augusto2112 added a comment.
Hi @labath. I see! I changed it to
`lldbgdbserverutils.gdbremote_hex_encode_string`. Looking at the logs, I found
that the checksum I inserted was wrong, so I've corrected that as well (is
there a way I can calculate the checksum on the test, instead of hard-coding
labath added a comment.
Thanks for picking this up.
I'm not sure if this is the (only) reason for the failure, but I have a feeling
you're encoding the packet incorrectly -- the application name should be
hex-encoded. Try using `lldbgdbserverutils.gdbremote_hex_encode_string` instead.
Reposit
