[Lldb-commits] [PATCH] D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93663/new/ https://reviews.llvm.org/D93663 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat

mgorny updated this revision to Diff 313201. mgorny retitled this revision from "[Process/NetBSD] Copy changes from FreeBSDRemote and reformat [WIP]" to "[Process/NetBSD] Copy changes from FreeBSDRemote and reformat". mgorny edited the summary of this revision. mgorny added a comment. Fixed FPR

[Lldb-commits] [PATCH] D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, mib. Herald added subscribers: arphaman, sbc100, emaste. Herald added a reviewer: espindola. JDevlieghere requested review of this revision. Herald added subscribers: MaskRay, aheejin. This patch introduces a `LLDB_SCO

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc added a comment. In D93495#2462581 , @DavidSpickett wrote: > I assume that the signal displays without tag bits just like any other SEGV? > > I was thinking about testing but I don't see any tests for specific signals > so it would only be needed if

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc updated this revision to Diff 313190. pcc added a comment. Show fault address for SEGV_MTESERR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93495/new/ https://reviews.llvm.org/D93495 Files: lldb/source/Plugins/Process/POSIX/CrashReason.cpp

[Lldb-commits] [lldb] bd2e833 - [lldb] [Process/FreeBSDRemote] Remove anonymous namespace

Author: Michał Górny Date: 2020-12-21T22:26:54+01:00 New Revision: bd2e8ece6afa8a6c1975d19d403d63349414 URL: https://github.com/llvm/llvm-project/commit/bd2e8ece6afa8a6c1975d19d403d63349414 DIFF: https://github.com/llvm/llvm-project/commit/bd2e8ece6afa8a6c1975d19d403d63349414.diff

[Lldb-commits] [PATCH] D93657: [lldb] Ad os_signpost support to `lldb_private::Timer`

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Right! I thought it was depending on D52954 ... LGTM then ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93657/new/ https://reviews.llvm.org/D93657

[Lldb-commits] [PATCH] D93657: [lldb] Ad os_signpost support to `lldb_private::Timer`

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Timer.cpp:62 : m_category(category), m_total_start(std::chrono::steady_clock::now()) { + Signposts->startInterval(this, m_category.GetName()); TimerStack &s

[Lldb-commits] [PATCH] D93657: [lldb] Ad os_signpost support to `lldb_private::Timer`

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/Timer.cpp:62 : m_category(category), m_total_start(std::chrono::steady_clock::now()) { + Signposts->startInterval(this, m_category.GetName

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err);

[Lldb-commits] [PATCH] D93657: [lldb] Ad os_signpost support to `lldb_private::Timer`

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere requested review of this revision. Emit `os_signposts` when supported from LLDB's timer class. A vast amount of performance sensitive places in LLDB are already instrumented with the Timer class. By emitting si

[Lldb-commits] [PATCH] D93621: [lldb][wasm] Parse DWO section names

labath added a comment. It would be nice to "mirror" the test case (test/Shell/ObjectFile/ELF/section-types.yaml) too. Other than that, this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93621/new/ https://reviews.llvm.org/D93621 __

[Lldb-commits] [PATCH] D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat [WIP]

labath added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41 + +namespace { +// x86 64-bit general purpose registers. mgorny wrote: > labath wrote: > > I don't know if this namespace snuck into the FreeBS

[Lldb-commits] [lldb] 3f3ab03 - [lldb] Remove anonymous namespace from NativeRegisterContextLinux_x86_64

Author: Pavel Labath Date: 2020-12-21T20:39:05+01:00 New Revision: 3f3ab03ab7bbaf13329b0ff07c5d3de40970bfcd URL: https://github.com/llvm/llvm-project/commit/3f3ab03ab7bbaf13329b0ff07c5d3de40970bfcd DIFF: https://github.com/llvm/llvm-project/commit/3f3ab03ab7bbaf13329b0ff07c5d3de40970bfcd.diff

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

tammela created this revision. tammela requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adds support for running a Lua function when a breakpoint is hit. Example: breakpoint command add -s lua -F abc The above runs the Lua function 'abc

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. I've run this through our copy of the GDB suite (8.3, not sure how old that is). There are 10 differences, with and without the patch. FAIL: gdb.base/foll-exec.exp: step through execlp call FAIL: gdb.base/foll-exec.exp: step after execlp call FAIL: gdb.base/foll

[Lldb-commits] [PATCH] D93621: [lldb][wasm] Parse DWO section names

pfaffe created this revision. Herald added subscribers: sunfish, sbc100. pfaffe requested review of this revision. Herald added subscribers: lldb-commits, aheejin. Herald added a project: LLDB. Mirror ELF section parsing to support DWARF section names for debug fission. Repository: rG LLVM Git