[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson requested review of this revision. probinson added a comment. This is still showing as approved; I'm going to try "Request Review" to see if that helps. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91734/new/ https://reviews.llvm.org/D91734 _

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson updated this revision to Diff 310935. probinson edited the summary of this revision. probinson added a reviewer: dblaikie. probinson added a comment. Rebase and combine cf1cc774d and dc35368c , plus revise handling co

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. In D91734#2443231 , @probinson wrote: > In D91734#2432988 , @dblaikie wrote: > >> Yeah, it boils down to something like this: >> >> void f1(const char*, const char*) { } >> int main() {

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson reopened this revision. probinson added a comment. This revision is now accepted and ready to land. Reopening, will upload a new diff in a moment that modifies how PHIs are handled. I intend to run the gdb suite on this, will post findings when I have them. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. In D91734#2432988 , @dblaikie wrote: > Yeah, it boils down to something like this: > > void f1(const char*, const char*) { } > int main() { > char prog[1]; > > f1(prog, >prog); > } > > Without the patch,

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

probinson added a comment. > And with these changes together, breaking on the function breaks on line 5 > (presumably because this is creating the constant used by the second '&&' > which is on line 5) instead of line 3. Not the worst thing, but I imagine > given Sony's interest in less "jumpy"

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93052/new/ https://reviews.llvm.org/D93052 ___ lldb-commits

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM - thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 ___ lldb-commits

[Lldb-commits] [PATCH] D92957: ExpressionParser: Migrate to FileEntryRef in ParseInternal, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92957/new/ https://reviews.llvm.org/D92957

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

mgorny updated this revision to Diff 311191. mgorny added a comment. Updated to unload duplicate ld.so as suggested by @labath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPO

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

tatyana-krasnukha updated this revision to Diff 311128. tatyana-krasnukha added a comment. Removed `do_select`'s default value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93052/new/ https://reviews.llvm.org/D93052 Files: lldb/include/lldb/Target/TargetList.h lldb/source/API/SBDe