[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2391245 , @labath wrote: > In D91241#2391156 , @omjavaid wrote: > >> I guess GDB standard does enforce ascending order, here is what it says >> about regnum: >> >> "The register’

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela added a comment. @JDevlieghere When writing this patch I noticed that there is no mechanism in-place to remove the Python/Lua function when the breakpoint is removed or when the callback function is replaced. The class that sets the callback provides `ClearCallback()` but it never calls

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. tammela requested review of this revision. Herald added a subscriber: JDevlieghere. These callbacks are set using the following: breakpoint command add -s lua -o "print('hello world!')" The us

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny added a comment. I'll port to other platforms once we agree on the approach. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_t

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Translate between abridged and full ftag values in order to expose the latter in the gdb-remote protocol while the former are used by FXSAVE/XSAVE... This matches the gdb b

[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

mgorny updated this revision to Diff 305371. mgorny added a comment. Create the unit test unconditionally, guard the code with `__FreeBSD__` define. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91216/new/ https://reviews.llvm.org/D91216 Files: lldb/source/Plugins/Process/FreeBSDRem

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny added a comment. Tested on Linux, FreeBSD and NetBSD. I've presumed we want fip/fdp only on amd64. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:84 lldb_fctrl_x86_64, lldb_fstat_x86_64, lldb_ftag_x86_64, -lld

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: pengfei. mgorny requested review of this revision. The FXSAVE/XSAVE data can have two different layouts on x86_64. When called as FXSAVE/XSAVE..., the Instruction Pointer and Address Poin

[Lldb-commits] [PATCH] D91268: [lldb] [Process/FreeBSDRemote] Access debug registers via offsets

mgorny updated this revision to Diff 305364. mgorny added a comment. Fix `native_i386_dbregs` on i386. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91268/new/ https://reviews.llvm.org/D91268 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp