[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

clayborg added a comment. The only place m_plugin_wp is used is for dumping, so I would vote to get rid of it. (At least on a non-swift LLVM checkout). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88266/new/ https://reviews.llvm.org/D88266 _

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham added a comment. But, sure, if nobody can come up with a use for this plugin dealie, I'll get rid of it. Otherwise I guess we should make a default plugin that calls "Dump"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88266/new/ https:/

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham added a comment. I am happier removing things when I know what they were for??? Not really sure why this plugin architecture is there. My guess is it is part of Todd's os_log facility, but I'm not really sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

clayborg added a comment. So StructuredData::Object does have a dump function: void Object::Dump(lldb_private::Stream &s, bool pretty_print = true) const; Not sure when that got added. So we actually don't even need the m_plugin_wp anymore if we switch to using that? Comme

[Lldb-commits] [PATCH] D88264: [intel-pt] Refactor the JSON parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbddebca61ea7: [intel-pt] Refactor the JSON parsing (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] bddebca - [intel-pt] Refactor the JSON parsing

Author: Walter Erquinigo Date: 2020-09-24T16:35:34-07:00 New Revision: bddebca61ea73d45d5eafc38aaf9fe7605f5a9b3 URL: https://github.com/llvm/llvm-project/commit/bddebca61ea73d45d5eafc38aaf9fe7605f5a9b3 DIFF: https://github.com/llvm/llvm-project/commit/bddebca61ea73d45d5eafc38aaf9fe7605f5a9b3.di

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham created this revision. jingham added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham requested review of this revision. Herald added a subscriber: JDevlieghere. Prevent a crash using SBStructuredData.GetDescription. For s

[Lldb-commits] [PATCH] D88264: [intel-pt] Refactor the JSON parsing

wallace created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Recently https://reviews.llvm.org/D88103 introduced a nice API for converting a JSON object into C++ types, which

[Lldb-commits] [lldb] a079f61 - [LLDB] Add a defensive check for member__f_

Author: shafik Date: 2020-09-24T14:48:21-07:00 New Revision: a079f619b5a1959af8af37cabdea27ae542903db URL: https://github.com/llvm/llvm-project/commit/a079f619b5a1959af8af37cabdea27ae542903db DIFF: https://github.com/llvm/llvm-project/commit/a079f619b5a1959af8af37cabdea27ae542903db.diff LOG: [

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

kastiglione added a comment. I agree it's nice to have somewhere, but git history should be fine. I should elaborate on motivations, 1. ensure everyone is using the script so that any issues are surfaced, 2. prevent missteps in the manual process, which may also be bit rotting if everyone is us

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I don't mind keeping it around, but I also haven't used the manual steps since the script's inception, so LGTM. We can always reinstate it if someone complains. Repository: rG

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. The `macos-setup-codesign.sh` script has been in place for over two years. If there

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

clayborg added a comment. I am fine with trying "localhost" and seeing if we run into any issues. Hopefully slow DNS isn't a problem anymore on Macs. Everyone else ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I meant to accept this, we can land this and deal with my suggestion as a follow up. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

JDevlieghere added a comment. Good catch, thank you! I wanted to suggest making the `SBAddress` constructor take the `Address` by const-reference but wanted to see how much work that'd be which resulted in D88249 . Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, werat. JDevlieghere requested review of this revision. Every call to the protected SBAddress constructor takes the address of a valid object which means we might as well pass it as a const reference instead of a pointer an

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; } ---

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat created this revision. werat added a reviewer: labath. werat added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: JDevlieghere. werat requested review of this revision. SBAddress constructor accepts a pointer to `lldb_private::Address`, but th

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

stella.stamenova added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1701 } else { if (command.GetArgumentCount() == 1) { auto load_addr_str = command[0].ref(); Actually, I would change the logic here a littl

[Lldb-commits] [lldb] ada1e2f - [lldb/examples] Add missing declaration in heap.py

Author: Dave Lee Date: 2020-09-24T08:44:45-07:00 New Revision: ada1e2ffa1172ede1790b4b42ef8ab01508d3a47 URL: https://github.com/llvm/llvm-project/commit/ada1e2ffa1172ede1790b4b42ef8ab01508d3a47 DIFF: https://github.com/llvm/llvm-project/commit/ada1e2ffa1172ede1790b4b42ef8ab01508d3a47.diff LOG:

[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGada1e2ffa117: [lldb/examples] Add missing declaration in heap.py (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88158/new/ https:/

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. This is probably pretty trivial but my first dive into win32 stuff so wanted to double check my logic before relanding. References: https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualqueryex http

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

DavidSpickett created this revision. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. This reverts commit c65627a1fe3be7521fc232d633bb6df577f55269