[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

2020-09-14 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. Herald added a reviewer: JDevlieghere. This seems fine to me with some minor nits. Also do you plan on writing a Linux API test for this which test memory regions on Linux? I couldnt locate one already written. Comment at: lldb/source/API/SBMemoryReg

[Lldb-commits] [PATCH] D87626: Fix .debug_aranges parsing.

2020-09-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87626/new/ https://reviews.llvm.org/D87626 __

[Lldb-commits] [PATCH] D87640: Add '<' meta command to read in code from external file

2020-09-14 Thread Patrick Beard via Phabricator via lldb-commits
pcbeard updated this revision to Diff 291742. pcbeard added a comment. Reformatted whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87640/new/ https://reviews.llvm.org/D87640 Files: lldb/source/Expression/REPL.cpp Index: lldb/source/E

[Lldb-commits] [PATCH] D87640: Add '<' meta command to read in code from external file

2020-09-14 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. This will get tests on the swift side till we have a REPL for C++ we can use to test this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D87640: Add '<' meta command to read in code from external file

2020-09-14 Thread Patrick Beard via Phabricator via lldb-commits
pcbeard created this revision. pcbeard added reviewers: jingham, teemperor. pcbeard created this object with visibility "All Users". pcbeard added a project: LLDB. Herald added a subscriber: JDevlieghere. pcbeard requested review of this revision. Perform all error handling in ReadCode() Add :hel

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

2020-09-14 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht created this revision. rupprecht added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Register the `faulthandler` module so we can see what lldb tests are doing when they misbehave (e.g. run u

[Lldb-commits] [PATCH] D87633: [lldb] Reword CompilerType docstring to not say "generic type"

2020-09-14 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Since "generic type" has a precise meaning in some lang

[Lldb-commits] [PATCH] D87626: Fix .debug_aranges parsing.

2020-09-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere. Herald added a project: LLDB. clayborg requested review of this revision. Code was added that used llvm error checking to parse .debug_aranges, but the error check after parsing the DWARFDebugArangesSet was r

[Lldb-commits] [lldb] a3bc040 - Fix 132e57bc597bd3f50174b7d286c43f76b47f11c1

2020-09-14 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2020-09-14T10:54:17-07:00 New Revision: a3bc0401d436d8c7d2dd5b54e13b81333d53bdff URL: https://github.com/llvm/llvm-project/commit/a3bc0401d436d8c7d2dd5b54e13b81333d53bdff DIFF: https://github.com/llvm/llvm-project/commit/a3bc0401d436d8c7d2dd5b54e13b81333d53bdff.di

[Lldb-commits] [lldb] 132e57b - Retry of D84974

2020-09-14 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2020-09-14T10:44:13-07:00 New Revision: 132e57bc597bd3f50174b7d286c43f76b47f11c1 URL: https://github.com/llvm/llvm-project/commit/132e57bc597bd3f50174b7d286c43f76b47f11c1 DIFF: https://github.com/llvm/llvm-project/commit/132e57bc597bd3f50174b7d286c43f76b47f11c1.di

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

2020-09-14 Thread Dmitry Antipov via Phabricator via lldb-commits
dmantipov updated this revision to Diff 291519. dmantipov added a comment. Drop prefixes and tweak the style to match clang-format requirements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441 Files: lldb

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

2020-09-14 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added inline comments. Comment at: lldb/docs/resources/test.rst:427 +actual hardware. QEMU helper scripts and README.txt document can be found under +llvm-project/lldb/scripts/lldb-test-qemu which can help setup a virtual testing +environment for LLDB using QEMU. These s