[Lldb-commits] [lldb] a65da5f - [LLDB] Update AArch64 Dwarf and EH frame register numbers

Author: Muhammad Omair Javaid Date: 2020-07-10T11:45:39+05:00 New Revision: a65da5f5924fbb7bad28bbb397e3e9a94959df4c URL: https://github.com/llvm/llvm-project/commit/a65da5f5924fbb7bad28bbb397e3e9a94959df4c DIFF: https://github.com/llvm/llvm-project/commit/a65da5f5924fbb7bad28bbb397e3e9a94959df

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm updated this revision to Diff 276894. aadsm added a comment. This update still doesn't add windows support but I just want to get a feel that I'm going on the right direction. It addresses the following: - redirect stdout/err as early as possible to avoid something writing to it, and only

[Lldb-commits] [lldb] fbef6c5 - [lldb] Declare extern template instantiation to fix linking issues.

Author: Jordan Rupprecht Date: 2020-07-09T18:43:53-07:00 New Revision: fbef6c55bc2f349110bd601b716889d73e101c92 URL: https://github.com/llvm/llvm-project/commit/fbef6c55bc2f349110bd601b716889d73e101c92 DIFF: https://github.com/llvm/llvm-project/commit/fbef6c55bc2f349110bd601b716889d73e101c92.di

[Lldb-commits] [lldb] 227db86 - Switch to using -debug-info-kind=constructor as default (from =limited)

Author: Amy Huang Date: 2020-07-09T15:26:46-07:00 New Revision: 227db86a1b7dd6f96f7df14890fcd071bc4fe1f5 URL: https://github.com/llvm/llvm-project/commit/227db86a1b7dd6f96f7df14890fcd071bc4fe1f5 DIFF: https://github.com/llvm/llvm-project/commit/227db86a1b7dd6f96f7df14890fcd071bc4fe1f5.diff LOG

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss added a comment. In D83023#2129985 , @labath wrote: > In D83023#2128475 , @friss wrote: > > > In D83023#2128298 , @labath wrote: > > > > > I think this is a very intere

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. I tested locally the standalone build of Clang with D83426 . I just want to make sure that we all agree this is right way moving forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss added a comment. This is the generic part of https://reviews.llvm.org/D83023 I modified to existing unittests to load their binary directly from memory, one ELF, one Mach-O. I tried to modify a PECOFF test to, but ObjectFilePECoff requires the file to be on the filesystem as it reopens it

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

shafik added a comment. @aprantl I think this Objective-C Runtime Programming Guide: Bye Encodings entry and this sample program answer the rest of your questions: #in

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss created this revision. friss added a reviewer: labath. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. This patch extends the ModuleSpec class to include a DataBufferSP which contains the module data. If this data is provided, LLDB

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

jingham added a comment. IIRC from when Shafik and I were looking at this the ObjC runtime data lists the same offset for all the members of the bitfield: the offset of the first member of the bitfield. Apparently the ObjC runtime doesn't need to know where the individual members are dynamical

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

jingham added a comment. I want to be careful not to conflate lldb's general event behavior with the way the command interpreter happens to run things. For instance, there's no requirement that the debugger be the event listener for processes. You can have a listener per process under the same

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

JDevlieghere added a comment. Seems like my thoughts got lost a bit with all the inline replies: we can solve this particular issue by making `process connect` block in synchronous mode. The fact that that's not happening today is a bug beyond the reproducers. I don't think we should change the

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yeah I got confused by the description. So, do we need to do any work at all with the bitfields offsets? With this patch we just keep adding them with whatever bogus bit-offset we get fr

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

clayborg accepted this revision. clayborg added a comment. I am all for unblocking support for -flimit-debug-info. The trade off here seems worth it IMHO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83302/new/ https://reviews.llvm.org/D83302

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

jingham added a comment. In D83446#2142350 , @JDevlieghere wrote: > In D83446#2142301 , @jingham wrote: > > > I think the proper way to gate this sort of "race" is to use the process > > state. If the current pro

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

JDevlieghere added a comment. In D83446#2142473 , @labath wrote: > In D83446#2142030 , @JDevlieghere > wrote: > > > Agreed. I believe at some point (long before I started working on LLDB) all > > the GDB communica

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

labath added a comment. In D83446#2142030 , @JDevlieghere wrote: > In D83446#2141713 , @labath wrote: > > > I'm wondering if this problem does not go beyond reproducers... The fact > > that we can have two threads

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

aprantl added a comment. @shafik It would be good to document what the expected behavior for bitfields ivars in Objective-C is. For the sake of this discussion, but really we also want this in a comment in the code, for future reference. IIUC, ivars don't have meaningful static offsets that we

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

shafik added a comment. We can never know the offsets statically b/c of how Objective-C deals with the fragile base class problem the runtime may have to shift fields over and we can not calculate this statically.

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

JDevlieghere added a comment. LGTM. I verified this works for the build-tree standalone build of LLDB, but please still keep an eye on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ after you land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor added a comment. I think I'm really out of the loop how this is supposed to work. From what I understand in the description it says we (=Clang when emitting DWARF?) is not generating offsets, but my DWARF dump of the test clearly has offsets (but they are clearly wrong). 0x0033

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

JDevlieghere added a comment. In D83446#2142301 , @jingham wrote: > I think the proper way to gate this sort of "race" is to use the process > state. If the current process state is "stopped" then that means we're done > with the stop processing and rea

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

jingham added a comment. I think the proper way to gate this sort of "race" is to use the process state. If the current process state is "stopped" then that means we're done with the stop processing and ready to allow commands that require the process to be stopped. When I originally did this

[Lldb-commits] [PATCH] D83496: [Reproducers] Add --reproducer-no-generate-on-signal to avoid installing the signal handler.

This revision was automatically updated to reflect the committed changes. Closed by commit rG10aa9e19fa2f: [LLDB/Reproducers] Add flag to avoid installing the signal handler. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 10aa9e1 - [LLDB/Reproducers] Add flag to avoid installing the signal handler.

Author: Jonas Devlieghere Date: 2020-07-09T11:50:45-07:00 New Revision: 10aa9e19fa2f4bf214131d30d7885f8b258b216f URL: https://github.com/llvm/llvm-project/commit/10aa9e19fa2f4bf214131d30d7885f8b258b216f DIFF: https://github.com/llvm/llvm-project/commit/10aa9e19fa2f4bf214131d30d7885f8b258b216f.d

[Lldb-commits] [lldb] 84557c1 - [lldb/Reproducers] Rename developer-oriented reproducer flags.

Author: Jonas Devlieghere Date: 2020-07-09T11:50:45-07:00 New Revision: 84557c18b3ca3cfc8d1f8ee988d8c19e2719f124 URL: https://github.com/llvm/llvm-project/commit/84557c18b3ca3cfc8d1f8ee988d8c19e2719f124 DIFF: https://github.com/llvm/llvm-project/commit/84557c18b3ca3cfc8d1f8ee988d8c19e2719f124.d

[Lldb-commits] [PATCH] D83496: [Reproducers] Add --reproducer-no-generate-on-signal to avoid installing the signal handler.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83496/new/ https://reviews.llvm.org/D83496 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D83496: [Reproducers] Add --reproducer-no-generate-on-signal to avoid installing the signal handler.

JDevlieghere updated this revision to Diff 276790. JDevlieghere retitled this revision from "[Reproducers] Add --reproducer-no-signal-handler to avoid installing the signal handler." to "[Reproducers] Add --reproducer-no-generate-on-signal to avoid installing the signal handler.". JDevlieghere a

[Lldb-commits] [PATCH] D83496: [Reproducers] Add --reproducer-no-signal-handler to avoid installing the signal handler.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, jasonmolenda. There are bugs where you don't want the signal handler to trigger, most notably when that will cause another crash. Examples of this are lldb running out of memory or a bug in the reproducer genera

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2612 -if ((this_field_info.bit_offset >= parent_bit_size) || -(last_field_info.IsBitfield() && - !last_field_info.NextBitfieldOffs

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

aprantl added a comment. I tried to do some radar archeology for more context, but I could neither find a radar mentioning that commit, nor a mention of a radar in that commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83302/new/ https://revie

[Lldb-commits] [lldb] f8f259c - [lldb/Function] Reflow doxygen comments for member variables, NFC

Author: Vedant Kumar Date: 2020-07-09T10:37:09-07:00 New Revision: f8f259ce4aca381896c114738a3d83a90c5c32be URL: https://github.com/llvm/llvm-project/commit/f8f259ce4aca381896c114738a3d83a90c5c32be DIFF: https://github.com/llvm/llvm-project/commit/f8f259ce4aca381896c114738a3d83a90c5c32be.diff

[Lldb-commits] [PATCH] D83359: [Function] Lock the function when parsing call site info

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cfc90b9b791: [Function] Lock the function when parsing call site info (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83359/new/ https://r

[Lldb-commits] [lldb] 6cfc90b - [Function] Lock the function when parsing call site info

Author: Vedant Kumar Date: 2020-07-09T10:37:09-07:00 New Revision: 6cfc90b9b791a023368b9384f57c2c3120894247 URL: https://github.com/llvm/llvm-project/commit/6cfc90b9b791a023368b9384f57c2c3120894247 DIFF: https://github.com/llvm/llvm-project/commit/6cfc90b9b791a023368b9384f57c2c3120894247.diff

[Lldb-commits] [PATCH] D83359: [Function] Lock the function when parsing call site info

vsk added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:661 + std::mutex + m_call_edges_lock; ///< Exclusive lock that controls read/write + /// access to m_call_edges and m_call_edges_resolved. aprantl wrote: > n

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks like a good cleanup. Hope someone with more CMake-fu to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83454/new/ https://review

[Lldb-commits] [PATCH] D83450: Delegate UpdateChildrenPointerType to the Root ValueObject

jingham added a comment. I am not selling this as the correct long-term structure for ValueObjects. So far as I can see, in all cases it should be possible to tell a ValueObject where it's going to find both its own store and the storage for pointer children when the ValueObject is created. I

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

aprantl added a comment. > The commit message claims this is a workaround for some kind of debug info > produced by gcc. However, it does not go into specifics, so it's hard to > reproduce or verify that this is indeed still a problem. Speaking for Darwin — while we try our best to not needless

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

shafik marked an inline comment as done. shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2612 -if ((this_field_info.bit_offset >= parent_bit_size) || -(last_field_info.IsBitfield() && -

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

JDevlieghere added a comment. In D83446#2141713 , @labath wrote: > Well, this is an interesting problem... IIUC, what's happening is that the > printing of the "stop reason" in the "event handler thread" is generating > some packets (to fetch the stop re

[Lldb-commits] [lldb] e529d77 - [lldb] Use enum constant instead of raw value

Author: Fred Riss Date: 2020-07-09T09:43:50-07:00 New Revision: e529d774c4d5d1eba13dcad5eef2195dd06741c6 URL: https://github.com/llvm/llvm-project/commit/e529d774c4d5d1eba13dcad5eef2195dd06741c6 DIFF: https://github.com/llvm/llvm-project/commit/e529d774c4d5d1eba13dcad5eef2195dd06741c6.diff LOG

[Lldb-commits] [PATCH] D83450: Delegate UpdateChildrenPointerType to the Root ValueObject

labath added a comment. Assuming the goal is to make this code ValueObjectVariable-only, the code is fine. I can't say I understand why should it be ValueObjectVariable-only (*), but given how different the ValueObjectConstResult hierarchy is, I think that may be for the best. It would still be

[Lldb-commits] [PATCH] D83446: [WIP][lldb/Reproducers] Synchronize the command interpreter with asynchronous events

labath added a reviewer: jingham. labath added a comment. Well, this is an interesting problem... IIUC, what's happening is that the printing of the "stop reason" in the "event handler thread" is generating some packets (to fetch the stop reason), and then the "cont" command produces some (c) t