[Lldb-commits] [lldb] 9eaf0ab - Revert "[lldb/Utility] Provide a stringify_append overload for function pointers."

Author: Jonas Devlieghere Date: 2020-04-16T17:52:09-07:00 New Revision: 9eaf0abebff9c61fa01c6ca69cbc74b1464efe14 URL: https://github.com/llvm/llvm-project/commit/9eaf0abebff9c61fa01c6ca69cbc74b1464efe14 DIFF: https://github.com/llvm/llvm-project/commit/9eaf0abebff9c61fa01c6ca69cbc74b1464efe14.d

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk planned changes to this revision. vsk added a comment. Sorry for the delay, I plan to have an update for this soon. In D77843#1978964 , @JDevlieghere wrote: > Have you asked the foundation people about the ASCII support in NSString? No, I'm not sur

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: jfb, arphaman, mgorny. No need to roll our own implementation for something that's covered by llvm. Repository: rLLDB LLDB https://reviews.llvm.org/D78337 Files: lldb/include/lldb/Host/TaskPo

[Lldb-commits] [PATCH] D78329: Allow lldb-test to combine -find with -dump-clang-ast

aprantl added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:8823 case clang::Type::Typedef: { const clang::TypedefType *typedef_type = shafik wrote: > Does it make sense to apply these change to non-objective-

[Lldb-commits] [PATCH] D78329: Allow lldb-test to combine -find with -dump-clang-ast

aprantl updated this revision to Diff 258197. aprantl marked 2 inline comments as done. aprantl added a comment. Address feedback from Shafik. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78329/new/ https://reviews.llvm.org/D78329 Files: lldb/include/lldb/Symbol/CompilerType

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

> On Apr 16, 2020, at 3:17 PM, Davidino Italiano wrote: > > > >> On Apr 16, 2020, at 2:37 PM, Shafik Yaghmour via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >>> >>> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere via lldb-commits >>> mailto:lldb-commits@lists.llvm.org>>

[Lldb-commits] [PATCH] D78329: Allow lldb-test to combine -find with -dump-clang-ast

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:8823 case clang::Type::Typedef: { const clang::TypedefType *typedef_type = Does it make sense to apply these change to non-objective-C cases? ==

[Lldb-commits] [lldb] ce77900 - [DWARF] Rename a function and comment it for clarity.

Author: Davide Italiano Date: 2020-04-16T15:37:09-07:00 New Revision: ce7790044faa48a1ec49b6339797180e05520cef URL: https://github.com/llvm/llvm-project/commit/ce7790044faa48a1ec49b6339797180e05520cef DIFF: https://github.com/llvm/llvm-project/commit/ce7790044faa48a1ec49b6339797180e05520cef.dif

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

I thought it was just undefined behavior, but apparently it's illegal because there's no guarantee pointers to function and pointers to objects share the same address space. TIL. I've pushed an overload in d10386e1779599d217b5b849a079f29dfbe17024 On Thu, Apr 16, 2020 at 3:17 PM Davidino Italiano

[Lldb-commits] [lldb] d10386e - [lldb/Utility] Provide a stringify_append overload for function pointers.

Author: Jonas Devlieghere Date: 2020-04-16T15:35:51-07:00 New Revision: d10386e1779599d217b5b849a079f29dfbe17024 URL: https://github.com/llvm/llvm-project/commit/d10386e1779599d217b5b849a079f29dfbe17024 DIFF: https://github.com/llvm/llvm-project/commit/d10386e1779599d217b5b849a079f29dfbe17024.d

[Lldb-commits] [lldb] 7fa342b - Remove attach-failed-due-to-SIP checks which were not working

Author: Jason Molenda Date: 2020-04-16T15:22:14-07:00 New Revision: 7fa342bd2a6be51998c399f145143d8f45da1f4d URL: https://github.com/llvm/llvm-project/commit/7fa342bd2a6be51998c399f145143d8f45da1f4d DIFF: https://github.com/llvm/llvm-project/commit/7fa342bd2a6be51998c399f145143d8f45da1f4d.diff

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

> On Apr 16, 2020, at 2:37 PM, Shafik Yaghmour via lldb-commits > wrote: > >> >> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere via lldb-commits >> wrote: >> >> >> Author: Jonas Devlieghere >> Date: 2020-04-16T14:03:55-07:00 >> New Revision: 9f6a308457d1bfebf1cee94b0306e738f270e512 >> >>

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

On Thu, Apr 16, 2020 at 2:37 PM Shafik Yaghmour wrote: > > > On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > > > Author: Jonas Devlieghere > > Date: 2020-04-16T14:03:55-07:00 > > New Revision: 9f6a308457d1bfebf1cee94b0306e738f270e512

[Lldb-commits] [PATCH] D78333: Add Objective-C property accessors loaded from Clang module DWARF to lookup

aprantl created this revision. aprantl added reviewers: teemperor, shafik. aprantl added a parent revision: D78329: Allow lldb-test to combine -find with -dump-clang-ast. This patch fixes a bug when synthesizing an ObjC property from -gmodules debug info. Because the method declaration that is i

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-04-16T14:03:55-07:00 > New Revision: 9f6a308457d1bfebf1cee94b0306e738f270e512 > > URL: > https://github.com/llvm/llvm-project/commit/9f6a308457d1bfebf1cee94b0306e738f270e51

[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix passive replay for functions returning string as (char*, size_t).

JDevlieghere updated this revision to Diff 258172. JDevlieghere added a comment. Remove duplication similar to D77602 . Honestly, at this point I'm not convinced that the difference between active and passive replay warrants special handling. Other than the sligh

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:305 if (is_trivially_serializable::value) - return; + return const_cast(t); // We need to make a copy as the original object might go out of scope. --

[Lldb-commits] [PATCH] D78329: Allow lldb-test to combine -find with -dump-clang-ast

aprantl created this revision. aprantl added reviewers: shafik, teemperor, jingham, labath. This patch threads an lldb::DescriptionLevel through the typesystem to allow dumping the full Clang AST (level=verbose) of any lldb::Type in addition to the human-readable source description (default leve

Re: [Lldb-commits] [lldb] 1fae85a - [DWARF] Add instructions to regenerate this test, if needed.

> On Apr 16, 2020, at 2:01 PM, Robinson, Paul wrote: > > > >> -Original Message- >> From: lldb-commits > > On Behalf Of >> Davide Italiano via lldb-commits >> Sent: Thursday, April 16, 2020 4:32 PM >> To: lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

Author: Jonas Devlieghere Date: 2020-04-16T14:03:55-07:00 New Revision: 9f6a308457d1bfebf1cee94b0306e738f270e512 URL: https://github.com/llvm/llvm-project/commit/9f6a308457d1bfebf1cee94b0306e738f270e512 DIFF: https://github.com/llvm/llvm-project/commit/9f6a308457d1bfebf1cee94b0306e738f270e512.d

Re: [Lldb-commits] [lldb] 1fae85a - [DWARF] Add instructions to regenerate this test, if needed.

> -Original Message- > From: lldb-commits On Behalf Of > Davide Italiano via lldb-commits > Sent: Thursday, April 16, 2020 4:32 PM > To: lldb-commits@lists.llvm.org > Subject: [Lldb-commits] [lldb] 1fae85a - [DWARF] Add instructions to > regenerate this test, if needed. > > > Author: D

[Lldb-commits] [lldb] 1fae85a - [DWARF] Add instructions to regenerate this test, if needed.

Author: Davide Italiano Date: 2020-04-16T13:31:32-07:00 New Revision: 1fae85a8534ec51ca893899314bd244b3e9684c7 URL: https://github.com/llvm/llvm-project/commit/1fae85a8534ec51ca893899314bd244b3e9684c7 DIFF: https://github.com/llvm/llvm-project/commit/1fae85a8534ec51ca893899314bd244b3e9684c7.dif

[Lldb-commits] [lldb] 8cac6d1 - [Shell] Remove incorrectly cargo-culted UNSUPPORTED.

Author: Davide Italiano Date: 2020-04-16T13:22:46-07:00 New Revision: 8cac6d1875e094f2b78621f3ff12e61553cd12ec URL: https://github.com/llvm/llvm-project/commit/8cac6d1875e094f2b78621f3ff12e61553cd12ec DIFF: https://github.com/llvm/llvm-project/commit/8cac6d1875e094f2b78621f3ff12e61553cd12ec.dif

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

JDevlieghere updated this revision to Diff 258123. JDevlieghere marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77602/new/ https://reviews.llvm.org/D77602 Files: lldb/include/lldb/Utility/Reproducer.h lldb/include/lldb/Utility/ReproducerInstrumentation

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

JDevlieghere closed this revision. JDevlieghere added a comment. Closed by 3a6b60fa623da6e311b61c812932917085067cd3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78242/new/ https://reviews.llvm.org/D78242

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8173 + // If a RecordDecl has base classes they won't be imported and we will + // be missing anything that we inherit from those bases. + if (FromRecor

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 258084. shafik added a comment. - Added unit test - Modified condition for defining `FromRecord` to whether it has an `ExternalSource` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 Files: clang/lib/AST/

[Lldb-commits] [lldb] 3a6b60f - [lldb/Docs] Add some more info about the test suite structure

Author: Jonas Devlieghere Date: 2020-04-16T10:17:59-07:00 New Revision: 3a6b60fa623da6e311b61c812932917085067cd3 URL: https://github.com/llvm/llvm-project/commit/3a6b60fa623da6e311b61c812932917085067cd3 DIFF: https://github.com/llvm/llvm-project/commit/3a6b60fa623da6e311b61c812932917085067cd3.d

[Lldb-commits] [PATCH] D78141: [lldb/Reproducers] Simplify LLDB_RECORD macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3237f861cc2: [lldb/Reproducers] Simplify LLDB_RECORD macros (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78141/new/ https://re

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

JDevlieghere marked 11 inline comments as done. JDevlieghere added a comment. Thanks a lot for the feedback everyone! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78242/new/ https://reviews.llvm.org/D78242 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] a3237f8 - [lldb/Reproducers] Simplify LLDB_RECORD macros

Author: Jonas Devlieghere Date: 2020-04-16T09:55:28-07:00 New Revision: a3237f861cc2b4c3cd29d86f0a0212dfd4d38d56 URL: https://github.com/llvm/llvm-project/commit/a3237f861cc2b4c3cd29d86f0a0212dfd4d38d56 DIFF: https://github.com/llvm/llvm-project/commit/a3237f861cc2b4c3cd29d86f0a0212dfd4d38d56.d

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri updated this revision to Diff 258034. yuri added a comment. Added @skipIfWindows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 Files: lldb/source/Target/RemoteAwarePlatform.cpp lldb/test/API/func

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri added a comment. > I don't believe this test will pass on windows, because of the different path > styles. I don't think it's possible to meaningfully test this on windows, as > it requires the path in the core file to match a host path. So, I think you > can just slap `@skipIfWindows` on

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

kwk added a comment. This looks good overall. I would add a section describing which test suite to use when you're interested in a particular DWARF feature for example. I heard from my GDB colleagues that the don't use a compiler, because that might change and produce a different DWARF. Instead

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 258004. kwk added a comment. - Remove not needed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lldb/s

[Lldb-commits] [lldb] d5c26f8 - [lldb/unittests] Better error messages when creating sockets fails

Author: Pavel Labath Date: 2020-04-16T11:59:37+02:00 New Revision: d5c26f871b7ee81e7bc6cc17cfddc9d08befe971 URL: https://github.com/llvm/llvm-project/commit/d5c26f871b7ee81e7bc6cc17cfddc9d08befe971 DIFF: https://github.com/llvm/llvm-project/commit/d5c26f871b7ee81e7bc6cc17cfddc9d08befe971.diff

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry, this got burried in my inbox. I think this looks good. I don't believe this test will pass on windows, because of the different path styles. I don't think it's possible to meaningfully

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

labath added a comment. Another interesting aspect of the "shell" tests is that there you can often get away with a broken/incomplete binary, whereas the "api" tests almost always require a fully functional executable. This enables testing of (some) aspects of handling of binaries with non-nati

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri added a comment. @labath, please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

labath accepted this revision. labath added a comment. I think this is a really good writeup. Thanks for doing this. Comment at: lldb/docs/resources/test.rst:156-157 +of variants. It's very tempting to add more variants because it's an easy way +to increase test coverage. It do

[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix passive replay for functions returning string as (char*, size_t).

labath added a comment. The thing which bugs me here (besides the duplication, which I think we now know how to handle) is that the definition of the behavior for the char*+size functions is spread out over REGISTER and RECORD macros -- one define the behavior of active replay, one for passive.

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

labath added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:305 if (is_trivially_serializable::value) - return; + return const_cast(t); // We need to make a copy as the original object might go out of scope.

[Lldb-commits] [PATCH] D78141: [lldb/Reproducers] Simplify LLDB_RECORD macros

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Very nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78141/new/ https://reviews.llvm.org/D78141 ___ lldb-commits mailing list lldb-c