[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. Those errors don't look like they could possibly be related to these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 __

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. thanks @vadimcn for pointing this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere, vadimcn. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lawrence_danna added a comment. thanks @vadimcn for pointing this out. The buffer protocol does not allow us

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup. In D77376#1961410 , @kwk wrote: > so I had to update the diff by hand with a bit of trouble. I was told h

[Lldb-commits] [PATCH] D77460: [lldb] NFC: Fix trivial typo in comments, documents, and messages

kiszk created this revision. Herald added subscribers: lldb-commits, atanasyan, MaskRay, jrtc27, kbarton, mgorny, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77460 Files: lldb/bindings/inte

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk added a comment. @jankratochvil for now I've re-added the `AddressPasses` functions and the `FIXME` comment. Can you approve? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 ___ lldb-commits mai

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255026. kwk edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFilter.cpp Index: lldb/source/Core/SearchFi

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk added a subscriber: lattner. kwk added a comment. Had some problem with my `arc diff` reporting that another git was running which it wasn't so I had to update the diff by hand with a bit of trouble. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255024. kwk marked 3 inline comments as done. kwk added a comment. Re-added `AddressPasses` with FIXME comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255022. kwk added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFilter.cp

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255013. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255012. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:70-71 const dw_tag_t die_tag = die_info_array[i].tag; -if (die_tag == 0 || die_tag == DW_TAG_class_type || -d