[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-22 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. Have you run the build with address sanitizer? Comment at: lldb/source/Commands/CommandObjectCommands.cpp:530 OptionsWithRaw args_with_suffix(raw_command_line); -const char *remainder = args_with_suffix.GetRawPart().c_str(); +llvm::St

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-22 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. I don't know why is `clang-tidy` failing. I haven't changed the import or any other file than `CommandObjectCommands.cpp`. @jingham @aprantl Could you please help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-22 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76569 Files: lldb/source/Commands/CommandObjectCommands.cpp Index: lldb/source/Commands/CommandObjectCommands.cpp =