[Lldb-commits] [PATCH] D75330: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

2020-02-28 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. Nice fix! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75330/new/ https://reviews.llvm.org/D75330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D75330: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

2020-02-28 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Great! You might want to do a git grep for LLDB_CONFIGURATION_DEBUG to find other instances, too. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75330/new/

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

2020-02-28 Thread Unnar Freyr Erlendsson via Phabricator via lldb-commits
unnar updated this revision to Diff 247211. unnar marked 2 inline comments as done. unnar added a comment. As discussed with labath@ I made a separate struct called AugmentedEntry that is used internally but we only ever expose the Entry part to the user. CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 7369ad3 - [lldb] Use llvm MC as the source of dwarf/eh register numbers for X86 ABIs

2020-02-28 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-02-28T10:49:08+01:00 New Revision: 7369ad38f8decb4a85b168bbf9a9869fa4e648ee URL: https://github.com/llvm/llvm-project/commit/7369ad38f8decb4a85b168bbf9a9869fa4e648ee DIFF: https://github.com/llvm/llvm-project/commit/7369ad38f8decb4a85b168bbf9a9869fa4e648ee.diff

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

2020-02-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D74759#1896100 , @unnar wrote: > In D74759#1895748 , @labath wrote: > > > That is a fair point. I suppose the reason why I see this as different is > > because this field is an implementa