[Lldb-commits] [lldb] 904d54d - [lldb/Test] Sort substr for TestDataFormatterStdMap.py (2/2)

2020-02-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-03T20:59:21-08:00 New Revision: 904d54de9ba9f71e937b24e04ad5941281cd50b7 URL: https://github.com/llvm/llvm-project/commit/904d54de9ba9f71e937b24e04ad5941281cd50b7 DIFF: https://github.com/llvm/llvm-project/commit/904d54de9ba9f71e937b24e04ad5941281cd50b7.d

[Lldb-commits] [lldb] 0c16a22 - [lldb/Test] Fix substr order in asan & ubsan tests

2020-02-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-03T20:57:57-08:00 New Revision: 0c16a22a2ebd1fc4238b6bd1c6e7d4d72d496b1f URL: https://github.com/llvm/llvm-project/commit/0c16a22a2ebd1fc4238b6bd1c6e7d4d72d496b1f DIFF: https://github.com/llvm/llvm-project/commit/0c16a22a2ebd1fc4238b6bd1c6e7d4d72d496b1f.d

[Lldb-commits] [PATCH] D73914: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches

2020-02-03 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG98594a44aaa8: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] 4c05019 - [lldb/Test] Fix typo in TestDataFormatterStdMap.py

2020-02-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-03T20:44:53-08:00 New Revision: 4c05019dc0cdf1b88bb229677f45c9a13074b84f URL: https://github.com/llvm/llvm-project/commit/4c05019dc0cdf1b88bb229677f45c9a13074b84f DIFF: https://github.com/llvm/llvm-project/commit/4c05019dc0cdf1b88bb229677f45c9a13074b84f.d

[Lldb-commits] [lldb] 70cea38 - [lldb/Test] Sort substr for TestDataFormatterStdMap.py

2020-02-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-03T20:35:43-08:00 New Revision: 70cea38ff7faa21e760dc9b252d968160f808d23 URL: https://github.com/llvm/llvm-project/commit/70cea38ff7faa21e760dc9b252d968160f808d23 DIFF: https://github.com/llvm/llvm-project/commit/70cea38ff7faa21e760dc9b252d968160f808d23.d

[Lldb-commits] [lldb] c1912c7 - [lldb/Test] Use arrays instead of sets for build_and_run_expr

2020-02-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-03T20:32:36-08:00 New Revision: c1912c7542d6f49dfd6cce03193727981529db8a URL: https://github.com/llvm/llvm-project/commit/c1912c7542d6f49dfd6cce03193727981529db8a DIFF: https://github.com/llvm/llvm-project/commit/c1912c7542d6f49dfd6cce03193727981529db8a.d

[Lldb-commits] [lldb] e211a7d - Re-land "[lldb/Test] Make substrs argument to self.expect ordered."

2020-02-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-02-03T20:19:25-08:00 New Revision: e211a7d2aafeeb9536f3aa9492601099655b833c URL: https://github.com/llvm/llvm-project/commit/e211a7d2aafeeb9536f3aa9492601099655b833c DIFF: https://github.com/llvm/llvm-project/commit/e211a7d2aafeeb9536f3aa9492601099655b833c.d

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:29 +if (sizeof(std::string) == sizeof(garbage_string_sso)) + memcpy((void *)&garbage1, &garbage_string_sso, sizeof(std:

[Lldb-commits] [lldb] bc3f87c - Xfail this test temporarily until AdrianM or I can

2020-02-03 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2020-02-03T18:53:17-08:00 New Revision: bc3f87cc029e7f8519e584e38ba0b4b2500a7258 URL: https://github.com/llvm/llvm-project/commit/bc3f87cc029e7f8519e584e38ba0b4b2500a7258 DIFF: https://github.com/llvm/llvm-project/commit/bc3f87cc029e7f8519e584e38ba0b4b2500a7258.diff

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

2020-02-03 Thread Jason Molenda via lldb-commits
I'm going to xfail it for tonight; we end up copying the base filename into the ModuleSpec that we use for searching, if (!module_spec.GetUUID().IsValid()) { if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) module_spec.GetFileSpec().GetFilename() = symbol_fs

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it.

2020-02-03 Thread Davide Italiano via Phabricator via lldb-commits
davide created this revision. davide added reviewers: jingham, friss, vsk. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73938 Files: lldb/source/Host/macosx/objcxx/Host.mm Index: lldb/source/Host/macosx/objcxx/Host.mm =

[Lldb-commits] [PATCH] D73935: [lldb] Remove clang classes from lldb-forward.h

2020-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This is right. I would even go so far as to say that no plugin forward-declarations should be in that file. Based on a quick glance, I think this is mostly true already.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:833 +LLDB_LOGF(log, "Parsing a Subprogram that has no name"); +assert(false && "Subprograms require a name"); + } JDevlieghere wrote: > aprantl wrote:

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

2020-02-03 Thread Vedant Kumar via Phabricator via lldb-commits
vsk planned changes to this revision. vsk added a comment. I'll update this tomorrow with checks in TestDataFormatterLibcxxString.py for how lldb formats garbage{1,2}. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 __

[Lldb-commits] [lldb] 246097a - [TestKernVerStrLCNOTE] Strengthen a check. NFC.

2020-02-03 Thread Davide Italiano via lldb-commits
Author: Davide Italiano Date: 2020-02-03T16:39:49-08:00 New Revision: 246097a091bfddca081f4d0f7d84530579e3bb33 URL: https://github.com/llvm/llvm-project/commit/246097a091bfddca081f4d0f7d84530579e3bb33 DIFF: https://github.com/llvm/llvm-project/commit/246097a091bfddca081f4d0f7d84530579e3bb33.dif

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

2020-02-03 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:29 +if (sizeof(std::string) == sizeof(garbage_string_sso)) + memcpy((void *)&garbage1, &garbage_string_sso, sizeof(std::st

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

2020-02-03 Thread Jason Molenda via lldb-commits
This is causing a test failure on the macos cmake bot in TestAddDsymCommand.py where we load a binary with uuid A, then try to add-dsym a dSYM uuid B and the test is looking for the error text, error: symbol file 'FILENAME' does not match any existing module but we're now getting, error: the o

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Symbol/TypeSystemClang.cpp:1283 + identifier_info, template_param_type, parameter_pack, + ast.getTrivialTypeSourceInfo(template_param_type))); } else { There is another `push_back` with

[Lldb-commits] [PATCH] D73935: [lldb] Remove clang classes from lldb-forward.h

2020-02-03 Thread Alex Langford via Phabricator via lldb-commits
xiaobai created this revision. xiaobai added a reviewer: LLDB. Herald added a project: LLDB. lldb-forward.h is convenient in many ways, but having clang-based class forward declarations in there makes it easy to proliferate uses of clang outside of plugins. Removing them makes you much more consci

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Vedant Kumar via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7b90cdedd1d3: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] bb6646c - [lldb/DataExtractor] Use an early return in GetMaxS64Bitfield, NFC

2020-02-03 Thread Vedant Kumar via lldb-commits
Author: Vedant Kumar Date: 2020-02-03T15:57:32-08:00 New Revision: bb6646ce0a2e59eda682f63696915d2dc7db40db URL: https://github.com/llvm/llvm-project/commit/bb6646ce0a2e59eda682f63696915d2dc7db40db DIFF: https://github.com/llvm/llvm-project/commit/bb6646ce0a2e59eda682f63696915d2dc7db40db.diff

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:29 +if (sizeof(std::string) == sizeof(garbage_string_sso)) + memcpy((void *)&garbage1, &garbage_string_sso, sizeof(std:

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. Is this missing additions to `TestDataFormatterLibcxxString.py`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73860/new/ https://reviews.llvm.org/D73860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. DWARFASTParserClang looks to me the wrong layer to fix this. Why can't this be caught in the generic DWARF Parser? I also believe that it's better if dwarfdump -verify crashes on this, rather than lldb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new/ h

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. `DWARFASTParserClang` looks to me the right layer to fix this. Why can't this be caught in the generic DWARF Parser? I also believe that it's better if `dwarfdump -verify` crashes on this, rather than lldb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:833 +LLDB_LOGF(log, "Parsing a Subprogram that has no name"); +assert(false && "Subprograms require a name"); + } aprantl wrote: > "Subprograms r

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:832 + if (tag == DW_TAG_subprogram && !attrs.name) { +LLDB_LOGF(log, "Parsing a Subprogram that has no name"); +assert(false && "Subprograms require a name");

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:832 + if (tag == DW_TAG_subprogram && !attrs.name) { +LLDB_LOGF(log, "Parsing a Subprogram that has no name"); +assert(false && "Subprograms require a name");

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Vedant Kumar via Phabricator via lldb-commits
vsk marked an inline comment as done. vsk added inline comments. Comment at: lldb/source/Utility/DataExtractor.cpp:610 int64_t sval64 = GetMaxS64(offset_ptr, size); if (bitfield_bit_size > 0) { int32_t lsbcount = bitfield_bit_offset; shafik wrote: > We

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

2020-02-03 Thread Adrian McCarthy via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e362d82b97f: Improve help text for (lldb) target symbols add (authored by amccarth). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D73589?vs=241013&id=242189#toc Repo

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

2020-02-03 Thread Adrian McCarthy via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc25938d57b1c: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols (authored by amccarth). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

2020-02-03 Thread Adrian McCarthy via lldb-commits
Author: Adrian McCarthy Date: 2020-02-03T14:22:05-08:00 New Revision: c25938d57b1cf9534887313405bc409e570a9b69 URL: https://github.com/llvm/llvm-project/commit/c25938d57b1cf9534887313405bc409e570a9b69 DIFF: https://github.com/llvm/llvm-project/commit/c25938d57b1cf9534887313405bc409e570a9b69.dif

[Lldb-commits] [lldb] 0e362d8 - Improve help text for (lldb) target symbols add

2020-02-03 Thread Adrian McCarthy via lldb-commits
Author: Adrian McCarthy Date: 2020-02-03T14:22:05-08:00 New Revision: 0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd URL: https://github.com/llvm/llvm-project/commit/0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd DIFF: https://github.com/llvm/llvm-project/commit/0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd.dif

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

2020-02-03 Thread Aaron Ballman via Phabricator via lldb-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

2020-02-03 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth added a comment. This is low risk and it did get positive comments from one non-reviewer, so I'm going to land this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added reviewers: aprantl, jingham, labath, JDevlieghere. This is just an enforcement of the DWARF requirement that a `DW_TAG_subprogram` should have a `DW_AT_name`. This came up when updating how we generating some debug info and one of the possible change c

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, thanks for taking care of this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73913/new/ https://reviews.llvm.org/D73913 ___ lldb-

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. In D73913#1855486 , @shafik wrote: > I wish I had caught that one when I did D70992 > , might be worth checking out more of the > code for similar issues. I guess this is why we have tooling =)

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Utility/DataExtractor.cpp:610 int64_t sval64 = GetMaxS64(offset_ptr, size); if (bitfield_bit_size > 0) { int32_t lsbcount = bitfield_bit_offset; We could do an early exit if `bitfield_bit_size` is z

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. I wish I had caught that one when I did D70992 , might be worth checking out more of the code for similar issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73913/new/ https://reviews.llvm.org/D73913 __

[Lldb-commits] [PATCH] D73914: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches

2020-02-03 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added a reviewer: labath. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Scale segment identifier up to user_id_t before negating it. This fixes the identifers being wrongly e.g. 0xfffe instead of 0xfffe.

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

2020-02-03 Thread Vedant Kumar via Phabricator via lldb-commits
vsk created this revision. vsk added reviewers: labath, JDevlieghere, teemperor. DataExtractor::GetMaxS64Bitfield performs a shift with UB in order to construct a bitmask when bitfield_bit_size is 64. The current implementation actually does “work” in this case, because the assumption that the shi

[Lldb-commits] [lldb] 3014efe - [lldb] Remove unused parameter from ValueObject::GetExpressionPath

2020-02-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-03T10:50:38-08:00 New Revision: 3014efe071988724b67f2dc106d36002aa03fa7d URL: https://github.com/llvm/llvm-project/commit/3014efe071988724b67f2dc106d36002aa03fa7d DIFF: https://github.com/llvm/llvm-project/commit/3014efe071988724b67f2dc106d36002aa03fa7d.diff

[Lldb-commits] [PATCH] D73827: [lldb] Delete ClangForward.h

2020-02-03 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5b0c8dd3a4fd: [lldb] Delete ClangForward.h (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73827/new/ https://reviews.llvm.org/D73827

[Lldb-commits] [lldb] 5b0c8dd - [lldb] Delete ClangForward.h

2020-02-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-03T10:43:12-08:00 New Revision: 5b0c8dd3a4fdeafd0a4414e43c94c10732d3d2d8 URL: https://github.com/llvm/llvm-project/commit/5b0c8dd3a4fdeafd0a4414e43c94c10732d3d2d8 DIFF: https://github.com/llvm/llvm-project/commit/5b0c8dd3a4fdeafd0a4414e43c94c10732d3d2d8.diff

[Lldb-commits] [lldb] fad012b - Reland "[lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates""

2020-02-03 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-02-03T14:59:55+01:00 New Revision: fad012bce1c3e26db05f61c7f00763530fd4400f URL: https://github.com/llvm/llvm-project/commit/fad012bce1c3e26db05f61c7f00763530fd4400f DIFF: https://github.com/llvm/llvm-project/commit/fad012bce1c3e26db05f61c7f00763530fd4400f.dif

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

2020-02-03 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 242030. jankratochvil added a comment. OK, `LINK_INTERFACE_MULTIPLICITY` also works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73847/new/ https://reviews.llvm.org/D73847 Files: lldb/source/Core/CMa

[Lldb-commits] [PATCH] D73871: [lldb] Make the order in which ClusterManager calls destructors deterministic

2020-02-03 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7f4cb2e7b67a: [lldb] Make the order in which ClusterManager calls destructors deterministic (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] 7f4cb2e - [lldb] Make the order in which ClusterManager calls destructors deterministic

2020-02-03 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-02-03T13:33:44+01:00 New Revision: 7f4cb2e7b67afd177cf8f8939d4bf5dcff33f20b URL: https://github.com/llvm/llvm-project/commit/7f4cb2e7b67afd177cf8f8939d4bf5dcff33f20b DIFF: https://github.com/llvm/llvm-project/commit/7f4cb2e7b67afd177cf8f8939d4bf5dcff33f20b.dif

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

2020-02-03 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D73839#1854333 , @mstorsjo wrote: > In D73839#1854328 , @teemperor wrote: > > > I guess this is causing the windows failure on the bot: > > http://lab.llvm.org:8011/builders/lldb-x64-wi

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

2020-02-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Seems like this was nondeterministic? http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13321 Maybe a dependency issue on the tblgen.exe... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73839/new/ https://

[Lldb-commits] [PATCH] D73847: `Debug` (but not `Release`): error: undefined reference to `ThreadPlanCallFunctionUsingABI` ctor && `ThreadPlanCallUserExpression` ctor

2020-02-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Lldb has a lot of circular dependencies, so it is not totally surprising that code move can cause this error to perk up. It the past we've worked around this by increasing the LINK_INTERFACE_MULTIPLICITY property in `lldb/Core/CMakeLists.txt`, and it seems like we should

[Lldb-commits] [PATCH] D73871: [lldb] Make the order in which ClusterManager calls destructors deterministic

2020-02-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, abidh, mgrang. Herald added a project: LLDB. ClusterManager is using a SmallPtrSet to store the objects in it. We always only add every object once so using a set is not neces

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

2020-02-03 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D73839#1854328 , @teemperor wrote: > I guess this is causing the windows failure on the bot: > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320 Yeah, I saw that - highly strange. I'll try to see if I can

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

2020-02-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73839/new/ https://reviews.llvm.org/D73839 __

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

2020-02-03 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5ee9275d7a: [LLDB] Add missing declarations for linking to psapi (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73839/new/ https://

[Lldb-commits] [lldb] 0afdc7b - Revert "[lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates"

2020-02-03 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-02-03T11:09:45+01:00 New Revision: 0afdc7bed8adb9516dec8581af7f969b7d087946 URL: https://github.com/llvm/llvm-project/commit/0afdc7bed8adb9516dec8581af7f969b7d087946 DIFF: https://github.com/llvm/llvm-project/commit/0afdc7bed8adb9516dec8581af7f969b7d087946.dif

[Lldb-commits] [lldb] 500c324 - [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

2020-02-03 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-02-03T10:59:35+01:00 New Revision: 500c324fa13eec2b171f4ea4dbed2ac1251f5aae URL: https://github.com/llvm/llvm-project/commit/500c324fa13eec2b171f4ea4dbed2ac1251f5aae DIFF: https://github.com/llvm/llvm-project/commit/500c324fa13eec2b171f4ea4dbed2ac1251f5aae.dif

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

2020-02-03 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG500c324fa13e: [lldb] Increase the rate at which ConstString's memory allocator scales the… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

Re: [Lldb-commits] [lldb] 2637769 - [lldb] Remove LanguageRuntime::GetOverrideExprOptions

2020-02-03 Thread Pavel Labath via lldb-commits
BTW, I am not aware of anyone actively developing/testing/using the renderscript support in lldb, and I wouldn't be surprised if it has actually bitrotted. I think this is also one of the things we could consider removing if it turns out it's standing in the way of making progress elsewhere. pl O