[Lldb-commits] [PATCH] D72377: [ldlb/SWIG] Refactor extensions to be non Python-specific.

JDevlieghere updated this revision to Diff 236763. JDevlieghere added a comment. Include `ConstString.h` once in `extensions.swig`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72377/new/ https://reviews.llvm.org/D72377 Files: lldb/scripts/Python/python-extensions.swig lldb/script

[Lldb-commits] [PATCH] D72377: [ldlb/SWIG] Refactor extensions to be non Python-specific.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/scripts/extensions.swig:9 +size_t desc_len = stream.GetSize(); +if (desc_len > 0 && (desc[desc_len-1] == '\n' || desc[desc_len-1] == '\r')) + --desc_len; -

[Lldb-commits] [lldb] fc6f15d - [lldb/CMake] Only auto-enable Python when SWIG is found

Author: Jonas Devlieghere Date: 2020-01-07T21:57:32-08:00 New Revision: fc6f15d4d2c4a051c8e31fe4de0bfaf9d3535f6e URL: https://github.com/llvm/llvm-project/commit/fc6f15d4d2c4a051c8e31fe4de0bfaf9d3535f6e DIFF: https://github.com/llvm/llvm-project/commit/fc6f15d4d2c4a051c8e31fe4de0bfaf9d3535f6e.d

[Lldb-commits] [lldb] adee645 - [lldb/Test] Try to appease the Windows bot

Author: Jonas Devlieghere Date: 2020-01-07T21:40:07-08:00 New Revision: adee6454b7ac8e7a489ec63e338e1d4a5705e2f1 URL: https://github.com/llvm/llvm-project/commit/adee6454b7ac8e7a489ec63e338e1d4a5705e2f1 DIFF: https://github.com/llvm/llvm-project/commit/adee6454b7ac8e7a489ec63e338e1d4a5705e2f1.d

[Lldb-commits] [PATCH] D72377: [ldlb/SWIG] Refactor extensions to be non Python-specific.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: LLDB. JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/scripts/extensions.swig:4 + const char *lldb::SBTarget::__str__ (){ +l

[Lldb-commits] [PATCH] D72377: [ldlb/SWIG] Refactor extensions to be non Python-specific.

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/scripts/extensions.swig:4 + const char *lldb::SBTarget::__str__ (){ +lldb::SBStream stream; +$self->GetDescription (stream, lldb::eDescriptionLevelBrief);

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

JDevlieghere updated this revision to Diff 236721. JDevlieghere added a comment. Typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72290/new/ https://reviews.llvm.org/D72290 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig.cmake =

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

JDevlieghere updated this revision to Diff 236720. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72290/new/ https://reviews.llvm.org/D72290 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig.cmake ==

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() compnerd wrote: > labath wrote: > > JDevlieghere wrote: > > > k

[Lldb-commits] [lldb] 6563826 - Revert "Re-land "[lldb/Lua] Add string conversion operator for SBTarget.""

Author: Jonas Devlieghere Date: 2020-01-07T16:45:43-08:00 New Revision: 6563826ff0f83cc8ef6c84154841245834a5b37e URL: https://github.com/llvm/llvm-project/commit/6563826ff0f83cc8ef6c84154841245834a5b37e DIFF: https://github.com/llvm/llvm-project/commit/6563826ff0f83cc8ef6c84154841245834a5b37e.d

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

compnerd added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() labath wrote: > JDevlieghere wrote: > > kwk wrote: > > > labath wrote: > > > > Why is this under `if(APPLE)` ? > >

[Lldb-commits] [lldb] 5e2f4dc - Rewrite comment about what watchpoints Aarch64 supports.

Author: Jason Molenda Date: 2020-01-07T16:13:23-08:00 New Revision: 5e2f4dc37b1bf72bd27e929a68fec18ae1f5cfa8 URL: https://github.com/llvm/llvm-project/commit/5e2f4dc37b1bf72bd27e929a68fec18ae1f5cfa8 DIFF: https://github.com/llvm/llvm-project/commit/5e2f4dc37b1bf72bd27e929a68fec18ae1f5cfa8.diff

Re: [Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:40 PM John McCall wrote: > > On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote: > > It seems like GCC doesn't do good things when trying to link two > > functions with empty asm labels but Clang does seem to do something > > reasonable. I can't quite tell whether this is

[Lldb-commits] [lldb] 06d122b - Re-land "[lldb/Lua] Add string conversion operator for SBTarget."

Author: Jonas Devlieghere Date: 2020-01-07T13:43:40-08:00 New Revision: 06d122bc4236bf0d049eab72d883c98cfc2a9901 URL: https://github.com/llvm/llvm-project/commit/06d122bc4236bf0d049eab72d883c98cfc2a9901 DIFF: https://github.com/llvm/llvm-project/commit/06d122bc4236bf0d049eab72d883c98cfc2a9901.d

[Lldb-commits] [lldb] 512b2c7 - [lldb/Test] Remove old binary created by TestConvenienceVariables

Author: Jonas Devlieghere Date: 2020-01-07T13:21:47-08:00 New Revision: 512b2c7dc74adb58404bb564bbd81b9cfdaf215c URL: https://github.com/llvm/llvm-project/commit/512b2c7dc74adb58404bb564bbd81b9cfdaf215c DIFF: https://github.com/llvm/llvm-project/commit/512b2c7dc74adb58404bb564bbd81b9cfdaf215c.d

[Lldb-commits] [PATCH] D72359: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in Debug builds

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. Herald added a project: LLDB. In Debug builds we call VerifyDecl in ClangASTContext::CreateFunctionDeclaration which in turn calls `getAccess` on the created Functio

[Lldb-commits] [lldb] 4c935c6 - [lldb/Test] Make TestConvenienceVariables more strict

Author: Jonas Devlieghere Date: 2020-01-07T13:06:13-08:00 New Revision: 4c935c66c43c6026d6ba565b1c6098e0f02d6962 URL: https://github.com/llvm/llvm-project/commit/4c935c66c43c6026d6ba565b1c6098e0f02d6962 DIFF: https://github.com/llvm/llvm-project/commit/4c935c66c43c6026d6ba565b1c6098e0f02d6962.d

[Lldb-commits] [lldb] fe27e8e - Revert "[lldb/Lua] Add string conversion operator for SBTarget."

Author: Jonas Devlieghere Date: 2020-01-07T12:47:00-08:00 New Revision: fe27e8ee80c708b1b79b08eb217f94f3d87d4052 URL: https://github.com/llvm/llvm-project/commit/fe27e8ee80c708b1b79b08eb217f94f3d87d4052 DIFF: https://github.com/llvm/llvm-project/commit/fe27e8ee80c708b1b79b08eb217f94f3d87d4052.d

Re: [Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote: > It seems like GCC doesn't do good things when trying to link two > functions with empty asm labels but Clang does seem to do something > reasonable. I can't quite tell whether this is a case for a diagnostic > or not. Note the generated assembl

Re: [Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:13 PM John McCall wrote: > > On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote: > > On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits > > wrote: > > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > > > wrote: > > > > Sorry to dredge up an old r

Re: [Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote: > On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits > wrote: > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > > wrote: > > > Sorry to dredge up an old review, but I recently ran into a bug in this > > > area and am n

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

JDevlieghere updated this revision to Diff 236662. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72290/new/ https://reviews.llvm.org/D72290 Files: lldb/cmake/modules/FindLibXml28.cmake lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake/modules/LLDBConfig.cmake ==

Re: [Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits wrote: > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > wrote: > > aaron.ballman added inline comments. > > > > > > > > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 > > +// do not add a "\01" prefix.

[Lldb-commits] [lldb] 640d0ba - [lldb/Lua] Add string conversion operator for SBTarget.

Author: Jonas Devlieghere Date: 2020-01-07T12:01:56-08:00 New Revision: 640d0ba8760051afc002c672121c6989517fc94e URL: https://github.com/llvm/llvm-project/commit/640d0ba8760051afc002c672121c6989517fc94e DIFF: https://github.com/llvm/llvm-project/commit/640d0ba8760051afc002c672121c6989517fc94e.d

Re: [Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator wrote: > aaron.ballman added inline comments. > > > > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 > +// do not add a "\01" prefix. > +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { > +

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

raj.khem added a comment. In D70764#1807405 , @smeenai wrote: > In D70764#1803559 , @raj.khem wrote: > > > this is now in master, and I am seeing build failures in cross-building > > clang, e.g. when building clang

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:46 + m_lua(std::make_unique()) { + llvm::cantFail(GetLua().EnterSession(debugger.GetID())); +}

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

JDevlieghere updated this revision to Diff 236642. JDevlieghere added a comment. - Address feedback Pavel - Add test for nested session CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71801/new/ https://reviews.llvm.org/D71801 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

aaron.ballman added inline comments. Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 +// do not add a "\01" prefix. +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { + Out << ALA->getLabel(); Sorry to dredge up an old review, but

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

jingham added a comment. In D70238#1808135 , @labath wrote: > Greg, Jim, any thoughts on pidless processes? First off, it would be useful to know that the PID for a process couldn't be recovered. For instance when inspecting a dump file, you might want

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

JDevlieghere marked 5 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:49 +if (llvm::Error e = +Run(llvm::formatv("package.path = package.path .. \";{0}\"", + fi

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

JDevlieghere updated this revision to Diff 236624. JDevlieghere added a comment. - Validate extension - Safely double quote strings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 Files: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp lldb

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

labath added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() JDevlieghere wrote: > kwk wrote: > > labath wrote: > > > Why is this under `if(APPLE)` ? > > To me this looks as if

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() kwk wrote: > labath wrote: > > Why is this under `if(APPLE)` ?

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

labath added a comment. Greg, Jim, any thoughts on pidless processes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70238/new/ https://reviews.llvm.org/D70238 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] 57835d0 - [lldb] Initialize some bitfields in FuncUnwinders.cpp

Author: Pavel Labath Date: 2020-01-07T18:01:59+01:00 New Revision: 57835d0198418ca6e397f4b0a50dc6057d93c04c URL: https://github.com/llvm/llvm-project/commit/57835d0198418ca6e397f4b0a50dc6057d93c04c DIFF: https://github.com/llvm/llvm-project/commit/57835d0198418ca6e397f4b0a50dc6057d93c04c.diff

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

smeenai added a comment. In D70764#1803559 , @raj.khem wrote: > this is now in master, and I am seeing build failures in cross-building > clang, e.g. when building clang for arm on a x86_64 host. its resorting to > finding, libz from buildhost instead of

[Lldb-commits] [lldb] 9daa44c - Remove extraneous spaces

Author: Med Ismail Bennani Date: 2020-01-07T16:46:04+01:00 New Revision: 9daa44c9935053508b38d0203ac47130c8156b02 URL: https://github.com/llvm/llvm-project/commit/9daa44c9935053508b38d0203ac47130c8156b02 DIFF: https://github.com/llvm/llvm-project/commit/9daa44c9935053508b38d0203ac47130c8156b02.

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin added a comment. In D72133#1806822 , @clayborg wrote: > So as long as the following are true from this patch I am ok: > > - if I ask for the array element type of "str" in the test that was added, it > should return "MCHAR". We shouldn't be removing

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

labath added a comment. In D71575#1803321 , @paolosev wrote: > In D71575#1793791 , @labath wrote: > > > A bunch more comments from me. :) > > > > A higher level question I have is whether there's something suitable

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

This revision was automatically updated to reflect the committed changes. Closed by commit rG65fdb34219f3: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D72161?vs=236066&id=236552#toc Repository

[Lldb-commits] [lldb] 65fdb34 - [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

Author: Raphael Isemann Date: 2020-01-07T13:03:56+01:00 New Revision: 65fdb34219f33b2871a532a38814ac4ebea10abc URL: https://github.com/llvm/llvm-project/commit/65fdb34219f33b2871a532a38814ac4ebea10abc DIFF: https://github.com/llvm/llvm-project/commit/65fdb34219f33b2871a532a38814ac4ebea10abc.dif

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is fine. It also sounds like a good idea to solve the +1 vs snprintf inconsistency. Comment at: lldb/scripts/Python/python-typemaps.swig:124-125 } else { - llv

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1745 + "0x%8.8llx, length = %llu) => %p", + (uint64_t)addr, (uint64_t)length, static_cast(bp));

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 236542. teemperor edited the summary of this revision. teemperor added a comment. - Move change to SWIG type map. - Fixed some type in the test. The API never emulated the snprintf behavior as it includes a NULL byte when we pass a nullptr buffer (and that

[Lldb-commits] [PATCH] D71801: [lldb/Lua] Make lldb.debugger et al available to Lua

labath added a comment. In D71801#1807109 , @jingham wrote: > In D71801#1794758 , @labath wrote: > > > +Jim, for his thoughts on debugger+interpreter relationship > > > > I think this is the time to step back and di

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

labath added inline comments. Comment at: packages/Python/lldbsuite/test/test_result.py:119 +categories = set() while folder != '/': categories_file_name = os.path.join(folder, ".categories") JDevlieghere wrote: > labath wrote: > > I

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. In D72133#1806822 , @clayborg wrote: > So as long as the following are true from this patch I am ok: > > - if I ask for the array element type of "str" in the test that was added, it > should return "MCHAR". We shouldn't be remo

[Lldb-commits] [lldb] d364815 - [lldb][NFC] Take a llvm::Triple in ClangASTContext constructor

Author: Raphael Isemann Date: 2020-01-07T10:50:59+01:00 New Revision: d364815351a887cbcd4579bc41995f8b2eb185ff URL: https://github.com/llvm/llvm-project/commit/d364815351a887cbcd4579bc41995f8b2eb185ff DIFF: https://github.com/llvm/llvm-project/commit/d364815351a887cbcd4579bc41995f8b2eb185ff.dif

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

jarin marked 3 inline comments as done. jarin added inline comments. Comment at: lldb/source/API/SBType.cpp:215-218 + CompilerType canonical_type = + m_opaque_sp->GetCompilerType(true).GetCanonicalType(); + return LLDB_RECORD_RESULT( + SBType(TypeImplSP(new TypeImpl(c

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

kwk added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() labath wrote: > Why is this under `if(APPLE)` ? To me this looks as if this module file `FileLibXml28.cmake` is only re

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

labath added a comment. Sorry for the delay, I was OOO and I'm still processing the backlog... Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:39 + + ConstString module_name = file.GetFileNameStrippingExtension(); + if (!module_name) { I guess y

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

labath added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() Why is this under `if(APPLE)` ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72