[Lldb-commits] [PATCH] D64698: Handle EOF from `lldb-vscode`

This revision was automatically updated to reflect the committed changes. Closed by commit rL366187: [lldb] Handle EOF from `lldb-vscode` (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [lldb] r366187 - [lldb] Handle EOF from `lldb-vscode`

Author: jankratochvil Date: Mon Jul 15 23:34:44 2019 New Revision: 366187 URL: http://llvm.org/viewvc/llvm-project?rev=366187&view=rev Log: [lldb] Handle EOF from `lldb-vscode` Sometimes (when running lldb-vscode under strace) I get: read(0, "", 16) = 0 read(0, "", 16)

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet added a comment. > I'm guessing on this Linux system, you've got a trap receiver function on the > stack that is on its first instruction or something? So backing up the pc > value for *that* frame is the problem you're solving. > ... > Just just to check, we've got a backtrace

[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

JDevlieghere added a comment. In D64782#1586802 , @davide wrote: > LGTM. Thanks. I fear this might break some bots, but the best way to see if > that's the case is trying. I've updated swig on GreenDragon, and the Windows bot is running 3.0. I'm not su

[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Thanks. I fear this might break some bots, but the best way to see if that's the case is trying. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64782/ne

[Lldb-commits] [lldb] r366161 - [Target] Remove unused method Target::GetDefaultClangModuleSearchPaths

Author: xiaobai Date: Mon Jul 15 18:02:32 2019 New Revision: 366161 URL: http://llvm.org/viewvc/llvm-project?rev=366161&view=rev Log: [Target] Remove unused method Target::GetDefaultClangModuleSearchPaths Modified: lldb/trunk/include/lldb/Target/Target.h lldb/trunk/source/Target/Target.cp

[Lldb-commits] [PATCH] D64774: [DebugInfo] Move function from line table to the prologue (NFC)

phosek added a comment. This change broke lld: /b/s/w/ir/k/llvm-project/lld/ELF/InputFiles.cpp:323:28: error: conversion function from 'nullptr_t' to 'llvm::StringRef' invokes a deleted function it->second.file, nullptr, ^~~ /b/s/w/ir/k/llvm-proje

[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. Herald added a project: LLDB. The last swig 1.x release dates from 2009, now 10 years ago. Recently I fixed an issue that prevented us from using swig 4 (rL364974

[Lldb-commits] [PATCH] D64774: [DebugInfo] Move function from line table to the prologue (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366158: [DebugInfo] Move function from line table to the prologue (NFC) (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D64774?vs=209961&id=210001#toc Repos

[Lldb-commits] [lldb] r366156 - Update some file changes, but there's a dependency loop so

Author: jmolenda Date: Mon Jul 15 16:55:22 2019 New Revision: 366156 URL: http://llvm.org/viewvc/llvm-project?rev=366156&view=rev Log: Update some file changes, but there's a dependency loop so it doesn't quite work rigtht now. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: ll

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_args/main.cpp:1 +template +struct M {}; Clang format? Comment at: source/Symbol/ClangASTContext.cpp:1619 +

[Lldb-commits] [PATCH] D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL366148: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [lldb] r366148 - [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

Author: xiaobai Date: Mon Jul 15 15:56:12 2019 New Revision: 366148 URL: http://llvm.org/viewvc/llvm-project?rev=366148&view=rev Log: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin Summary: Following up to my CPPLanguageRuntime change, I'm moving ObjCLanguageRuntime into a plugin as wel

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

shafik created this revision. shafik added a reviewer: teemperor. In `ClangASTContext::CreateFunctionTemplateSpecializationInfo` a `TemplateArgumentList` is allocated on the stack but is treated as if it is persistent in subsequent calls. When we exit the function `func_decl` will still point t

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

jasonmolenda added a comment. Ah, regarding the S bit, looks good to me. I think I misunderstood the original problem you were working on. On Darwin systems, we have our friend __sigtramp. When an async interrupt is received, the kernel saves the register context to stack and then calls __si

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

jasonmolenda added a comment. In D63667#1558027 , @JosephTremoulet wrote: > I've updated this with code to recognize the 'S' in the eh_frame augmentation > and record it in a new bool member of UnwindPlan, > `m_plan_is_for_signal_trap`. I haven't hooke

[Lldb-commits] [PATCH] D64774: [DebugInfo] Move function from line table to the prologue (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: dblaikie, probinson, wolfgangp. JDevlieghere added a project: debug-info. Herald added subscribers: lldb-commits, hiraditya. Herald added projects: LLDB, LLVM. In LLDB, when parsing type units, we don't need to parse the whole line

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet added a subscriber: clayborg. JosephTremoulet added a comment. ping @jasonmolenda -- do the updates look like what you had in mind when you said " It'd be a good change to capture that information from the eh_frame though, even if we don't see a clear way to use it right now"? A

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

JosephTremoulet added a comment. Herald added subscribers: wuzish, MaskRay. > That LLDB frame #5 is a bit bogus Thanks for taking a look at this. I'm trying to reproduce what you're seeing and failing. This is what I see, in a fedora:latest docker container on an Ubuntu host on an x86_64 mach

[Lldb-commits] [PATCH] D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up

kusmour created this revision. kusmour added reviewers: xiaobai, labath. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Delete the android target from `libstdcpp` test category, since android no longer support libstdcxx Repository: rLLDB LLDB https://reviews.l

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

kusmour created this revision. kusmour added reviewers: xiaobai, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added a local variable to hold the return value to avoid delayed calculation on variables This issue occurred when using NDK 20 clang with `-O0` flag set

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

kusmour created this revision. kusmour added reviewers: xiaobai, labath. Herald added subscribers: lldb-commits, kristof.beyls, javed.absar, srhines. Herald added a project: LLDB. update some test decorates that can actually pass on andriod aarch64 Repository: rLLDB LLDB https://reviews.llvm.

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

shafik added a comment. This LGTM now but I will wait for @teemperor to take a look at it. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:620 if (predicate(decl->getKind())) { if (log) { I think a comment on the `predica

[Lldb-commits] [PATCH] D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, compnerd, jingham, clayborg. Herald added subscribers: arphaman, mgorny. Following up to my CPPLanguageRuntime change, I'm moving ObjCLanguageRuntime into a plugin as well. https://reviews.llvm.org/D64763 Files: include/lld

[Lldb-commits] [PATCH] D64670: [lldb][doc] Document how our LLDB table gen initialized options

This revision was automatically updated to reflect the committed changes. Closed by commit rL366083: [lldb][doc] Document how our LLDB table gen initialized options (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [lldb] r366083 - [lldb][doc] Document how our LLDB table gen initialized options

Author: teemperor Date: Mon Jul 15 10:10:44 2019 New Revision: 366083 URL: http://llvm.org/viewvc/llvm-project?rev=366083&view=rev Log: [lldb][doc] Document how our LLDB table gen initialized options Summary: This patch adds documentation that should make it easier to migrate from using the old

[Lldb-commits] [PATCH] D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout

This revision was automatically updated to reflect the committed changes. Closed by commit rL366078: [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D64698: Handle EOF from `lldb-vscode`

JDevlieghere added a comment. Looks solid to me, but I'll defer to Greg to accept. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64698/new/ https://reviews.llvm.org/D64698 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. In D61333#1583173 , @teemperor wrote: > @martong Sorry for the delay, feel free to ping me in the future about these > patches. I'll review them ASAP now that I'm back in office, so these delay's > hopefully won't happen again. >

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 209832. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImpo

[Lldb-commits] [PATCH] D64719: [zorg] [LLDB] getLLDBCMakeBuildFactory: New parameter testTimeout

jankratochvil created this revision. jankratochvil added reviewers: gkistanova, stella.stamenova, labath. jankratochvil added a project: LLDB. jankratochvil added a subscriber: kwk. Just for some difficult-to-catch buildbot failures. I think the patch is obvious, OK for check-in? Thanks. Reposi