[Lldb-commits] [lldb] r363653 - Fix windows build for r363357

Author: labath Date: Tue Jun 18 00:02:53 2019 New Revision: 363653 URL: http://llvm.org/viewvc/llvm-project?rev=363653&view=rev Log: Fix windows build for r363357 MSVC has trouble referencing the protected Compare class from from the friend Entry operator<. Just delete that operator, as it's used

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop updated this revision to Diff 205242. siedentop added a comment. @sgraenitz , good find. I've removed the leading dashes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

[Lldb-commits] [PATCH] D63467: [Reproducers] Make reproducer relocatable

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, bruno. Herald added a subscriber: dexonsmith. Herald added a project: LLDB. Before this patch, reproducers weren't relocatable. The reproducer contained hard coded paths in the VFS mapping, as well in the yaml file

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm updated this revision to Diff 205211. aadsm added a comment. - Add a test to cover cross page reads - Make cache_line_size a static const variable inside the function. - Fix how we're passing name_buffer to ReadCStringFromMemory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

asmith updated this revision to Diff 205178. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63166/new/ https://reviews.llvm.org/D63166 Files: source/Plugins/Process/Windows/Common/CMakeLists.txt source/Plugins/Process/Windows/Common/ProcessDebugger.cpp source/Plugins/Process/Windows

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

stella.stamenova added a comment. It looks like this broke the Windows bot. I am no longer receiving emails when the bot fails (as bot owner I used to always get the failure emails), so I am assuming for some reason notifications aren't working correctly. Can you have a look at the failure? ht

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363608: Add color to the default thread and frame format. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [lldb] r363608 - Add color to the default thread and frame format.

Author: jdevlieghere Date: Mon Jun 17 12:53:11 2019 New Revision: 363608 URL: http://llvm.org/viewvc/llvm-project?rev=363608&view=rev Log: Add color to the default thread and frame format. Now that we correctly ignore ASCII escape sequences when colors are disabled (r362240), I'd like to change t

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63441/new/ https://reviews.llvm.org/D63441 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jfb added a comment. In D63363#1546837 , @labath wrote: > In D63363#1546504 , @jfb wrote: > > > In D63363#1546490 , @xiaobai wrote: > > > > > In D63363#1546464

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

labath added a comment. In D63363#1546504 , @jfb wrote: > In D63363#1546490 , @xiaobai wrote: > > > In D63363#1546464 , @jfb wrote: > > > > > Can you describe what the goal o

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

labath marked 2 inline comments as done. labath added a comment. In D63399#1546330 , @clayborg wrote: > I am concerned that our mapping from DIERef to lldb::user_id_t won't work for > all cases now that we are/have expanded the DIERef class (including as

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

jankratochvil added a comment. LGTM but I will leave the approval for @labath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63441/new/ https://reviews.llvm.org/D63441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

jankratochvil added a comment. > It ll run on staging master until tests become stable. BTW the silent master is now dead since 2019-06-13. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63441/new/ https://reviews.llvm.org/D63441 ___ lldb-c

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jfb added a comment. In D63363#1546490 , @xiaobai wrote: > In D63363#1546464 , @jfb wrote: > > > Can you describe what the goal of your plugin architecture is? Maybe you > > need an RFC by email before moving stuff

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai added a comment. In D63363#1546464 , @jfb wrote: > Can you describe what the goal of your plugin architecture is? Maybe you need > an RFC by email before moving stuff around. > > I want to understand what you're going for because as they are today

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jfb added a comment. Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around. I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditi

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai added a comment. In D63363#1545427 , @labath wrote: > Although this is technically correct and pretty consistent with our other > "plugins", I can't help but feel that it's incredibly wasteful. Each of the > XXXSignals.cpp files is less than a 10

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

omjavaid created this revision. omjavaid added reviewers: labath, jankratochvil, gkistanova. Herald added subscribers: kristof.beyls, javed.absar. This patch adds lldb aarch64 linux builder. It ll run on staging master until tests become stable. https://reviews.llvm.org/D63441 Files: buildbo

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

clayborg added a comment. I am concerned that our mapping from DIERef to lldb::user_id_t won't work for all cases now that we are/have expanded the DIERef class (including as we add the DWO field). I voiced this concern in https://reviews.llvm.org/D63428. Let me know what you think.

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. About the regression of TestFormatters.py: I realized that the problem is about the wrong implementation of the ExternalASTSource interface. In the implementation of FindExternalLexicalDecls of this interface, we simply ignored those cases when the given predicate (passe

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 205093. martong added a comment. - Fix regression of TestFormatters.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp clang/un

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

clayborg added a comment. I am concerned with increasing the size of DIERef objects. If we go to 12 bytes per DIERef, and we mostly store these in NameToDIE in "lldb_private::UniqueCStringMap m_map;" maps, which contain a std::vector of UniqueCStringMap::Entry objects which are: struct Entry

[Lldb-commits] [PATCH] D63400: DWARF: Provide accessors to DIERef fields

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:48 + unsigned m_section : 1; + dw_offset_t m_unit_offset; + dw_offset_t m_die_offset; Never m

[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases

This revision was automatically updated to reflect the committed changes. Closed by commit rL363567: [lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more… (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [lldb] r363567 - [lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more testcases

Author: jankratochvil Date: Mon Jun 17 07:46:17 2019 New Revision: 363567 URL: http://llvm.org/viewvc/llvm-project?rev=363567&view=rev Log: [lldb] [test] Extend D55859 symbols.enable-external-lookup=false for more testcases D55859 has no effect for some of the t

[Lldb-commits] [PATCH] D63400: DWARF: Provide accessors to DIERef fields

clayborg added a comment. Just questioning if we want to increase the size of the DIERef struct. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:47-48 +private: + unsigned m_section : 1; + dw_offset_t m_unit_offset; + dw_offset_t m_die_offset; We we wan

[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D63339#1546091 , @jankratochvil wrote: > In D63339#1546076 , @labath wrote: > > > It looks like lldb-mi has

[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases

jankratochvil added a comment. In D63339#1546076 , @labath wrote: > It looks like lldb-mi has the `--source` option. Could that be used to set > this setting automatically via lit, as it is done with `%lldb` ? The problem is it generates additional `^do

[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases

labath added a comment. It looks like lldb-mi has the `--source` option. Could that be used to set this setting automatically via lit, as it is done with `%lldb` ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63339/new/ https://reviews.llvm.org/D63339

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

labath added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:169-170 + +Status ProcessDebugger::AttachProcess(lldb::pid_t pid, + const ProcessAttachInfo &attach_info, +

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:315 + lldb::addr_t &load_addr) { + return GetProcessBaseAddress(m_pid, load_addr); +} This doesn't look right. You're

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added subscribers: arphaman, dexonsmith, mehdi_amini. When dwo support was introduced, it used a trick where debug info entries were referenced by the offset of the compile unit in the main file, but the

[Lldb-commits] [lldb] r363551 - [lldb] [test] Watchpoint tests can be always run as root on NetBSD

Author: mgorny Date: Mon Jun 17 05:32:09 2019 New Revision: 363551 URL: http://llvm.org/viewvc/llvm-project?rev=363551&view=rev Log: [lldb] [test] Watchpoint tests can be always run as root on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

mgorny added a comment. In D63380#1545856 , @krytarowski wrote: > This check should contain additional check for uid==root. If we are root we > can read and write to DB registers. Will do. Repository: rL LLVM CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

krytarowski added a comment. Herald added a subscriber: ormris. This check should contain additional check for uid==root. If we are root we can read and write to DB registers. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63380/new/ https://reviews.llvm.org/D6338

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

sgraenitz added a comment. Thanks for the initiative! Three inline comments for cosmetics. Comment at: lldb/cmake/modules/LLDBConfig.cmake:143 PYTHONLIBS_VERSION_STRING "${python_version_str}") -message("-- Found Python version ${PYTHONLIBS_VERSION_STRING}") +

[Lldb-commits] [lldb] r363536 - [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

Author: mgorny Date: Mon Jun 17 02:49:05 2019 New Revision: 363536 URL: http://llvm.org/viewvc/llvm-project?rev=363536&view=rev Log: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled Skip watchpoint tests if security.models.extensions.user_set_dbregs is disabled. This indic

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rL363536: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D63400: DWARF: Provide accessors to DIERef fields

labath updated this revision to Diff 205006. labath added a comment. - s/DW_INVALID_OFFSET/llvm::None/ in HashedNameToDIE.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63400/new/ https://reviews.llvm.org/D63400 Files: source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp source/Plu

[Lldb-commits] [PATCH] D63400: DWARF: Provide accessors to DIERef fields

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a subscriber: arphaman. labath added a parent revision: D63399: DWARF: Make DIERefs always valid. labath added a comment. (also, cu_offset is renamed to unit_offset, as we now support type units too

[Lldb-commits] [PATCH] D63400: DWARF: Provide accessors to DIERef fields

labath added a comment. (also, cu_offset is renamed to unit_offset, as we now support type units too) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63400/new/ https://reviews.llvm.org/D63400 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added a subscriber: arphaman. labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:1 //===-- DIERef.cpp

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:1 //===-- DIERef.cpp --*- C++ -*-===// // I'm not deleting this file, because I'm going to

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1197 + return False, "security.models.extensions.user_set_dbregs disabled" +return True, "dbregs always

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

mgorny updated this revision to Diff 204995. mgorny added a comment. Updated as suggested above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63380/new/ https://reviews.llvm.org/D63380 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

mgorny updated this revision to Diff 204996. mgorny added a comment. Removed stale decorator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63380/new/ https://reviews.llvm.org/D63380 Files: lldb/packages/Python/lldbsuite/test/dotest.py Index: lldb/packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D63322: DWARF: Avoid storing DIERefs in long-lived containers

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL363528: DWARF: Avoid storing DIERefs in long-lived containers (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-com

[Lldb-commits] [PATCH] D63322: DWARF: Avoid storing DIERefs in long-lived containers

labath marked 2 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2970 if (die) { TypeSystem *type_system = aprantl wrote: > If you find the time: > > ``` > if (!die) > return {}; >

[Lldb-commits] [lldb] r363528 - DWARF: Avoid storing DIERefs in long-lived containers

Author: labath Date: Mon Jun 17 00:32:56 2019 New Revision: 363528 URL: http://llvm.org/viewvc/llvm-project?rev=363528&view=rev Log: DWARF: Avoid storing DIERefs in long-lived containers Summary: A user_id_t carries the same information as a DIERef, but it takes up less space. Furthermore, DIERe

[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

mgorny added a comment. In D63380#1545428 , @labath wrote: > This definitely aren't all of our watchpoint tests. What's the reason for > picking this particular bunch? Are they the only ones enabled on NetBSD right > now? Buildbot was down at the momen

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, modulo the inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:25-26 // NativeProcessProtocol Members +const size_t NativeProcessProtocol::g