[Lldb-commits] [PATCH] D59238: [Reproducers] Support capturing a reproducer without an explicit path.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, davide, labath. Herald added a subscriber: teemperor. Herald added a project: LLDB. Tablegen doesn't support options that serve both as flags and as arguments taking a value. I noticed this when doing the tablegen rewrite,

[Lldb-commits] [PATCH] D59232: [CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355887: [CMake] Avoid clang-tablegen-targets dependency when building sphinx docs… (authored by JDevlieghere, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.ll

[Lldb-commits] [lldb] r355887 - [CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)

Author: jdevlieghere Date: Mon Mar 11 17:49:10 2019 New Revision: 355887 URL: http://llvm.org/viewvc/llvm-project?rev=355887&view=rev Log: [CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental) Proposal to fix bot http://lab.llvm.org:8011/builders/lldb-sphinx-do

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah, I'm ok with this, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58347/new/ https://reviews.llvm.org/D58347 ___

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

Ah, I see. This doesn't seem terribly confusing, TypePair manages the TypeSP & CompilerType and keeps them in sync, so it just allows you to provide a higher quality representation if you have it. A lot of SBValues come from debug information so they will have TypeSP's around when they get ma

[Lldb-commits] [PATCH] D59230: Add a case in SymbolFile{Native, }PDB::TranslateLanguage for Swift

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355883: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift (authored by lanza, committed by ). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to co

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

zturner added a comment. In D59235#1425436 , @clayborg wrote: > My main concern with the LLVM DWARF parser is all of the asserts in the code. > If you attempt to use a DWARFDIE without first checking it for validity, it > will crash on you instead of ret

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

clayborg added a comment. My main concern with the LLVM DWARF parser is all of the asserts in the code. If you attempt to use a DWARFDIE without first checking it for validity, it will crash on you instead of returning a good error or default value. That makes me really nervous as we shouldn't

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

On Mon, Mar 11, 2019 at 4:15 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Just to be precise: TypeImpl stores a TypePair for the static type and a > CompilerType for the dynamic type. These two have different meanings. > There's no assumption about the relationship betwe

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

zturner added a subscriber: jankratochvil. zturner added a comment. In D59235#1425417 , @clayborg wrote: > What part of parsing DWARF64 wasn't working? I think the SPARC compiler was > the only one producing DWARF64. This patch originated from a thread

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

clayborg added a comment. If no one is depending on type_sp, then ok to delete. Should be easy to test by removing it and seeing what breaks (if anything). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59217/new/ https://reviews.llvm.org/D59217 __

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

Just to be precise: TypeImpl stores a TypePair for the static type and a CompilerType for the dynamic type. These two have different meanings. There's no assumption about the relationship between the static and dynamic type. In ObjC, the dynamic type need not even be in the same class hierarc

[Lldb-commits] [lldb] r355879 - [Reproducers] Make ReproducerInstrumentation a textual header

Author: jdevlieghere Date: Mon Mar 11 16:09:09 2019 New Revision: 355879 URL: http://llvm.org/viewvc/llvm-project?rev=355879&view=rev Log: [Reproducers] Make ReproducerInstrumentation a textual header The RECORD macro is context sensitive because it depends on the LLDB_GET_INSTRUMENTATION_DATA. T

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

clayborg added a comment. What part of parsing DWARF64 wasn't working? I think the SPARC compiler was the only one producing DWARF64. Be a shame to lose the support. What is the plan here after this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59235/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM, perhaps let's give this a day for others to chime in in case they missed the thread on lldb-dev. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59235/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D59232: [CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59232/new/ https://reviews.llvm.org/D59232 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

zturner created this revision. zturner added reviewers: clayborg, jasonmolenda, aprantl. Herald added a subscriber: jdoerfert. LLVM doesn't produce DWARF64, and neither does GCC. LLDB's support for DWARF64 is only partial, and if enabled appears to also not work. It also appears to have no tes

[Lldb-commits] [lldb] r355875 - Rewrite comment to be clearer

Author: xiaobai Date: Mon Mar 11 15:49:36 2019 New Revision: 355875 URL: http://llvm.org/viewvc/llvm-project?rev=355875&view=rev Log: Rewrite comment to be clearer Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Cl

[Lldb-commits] [PATCH] D59232: [CMake] Avoid clang-tablegen-targets dependency when building sphinx docs (experimental)

sgraenitz created this revision. sgraenitz added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. Proposal to fix bot http://lab.llvm.org:8011/builders/lldb-sphinx-docs/builds/1564/steps/cmake-configure/logs/stdio https://reviews.llvm.org/D59232 Files: cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

jingham added a comment. It's a little weird that the CommandObjectExpression is telling the REPL what its options should be, it would be more natural to go the other way. Maybe have the repl_sp provide a properly set up set of EvaluateExpressionOptions and then copy them over to this CommandO

[Lldb-commits] [lldb] r355866 - [Reproducers] Reinterpret cast to void*

Author: jdevlieghere Date: Mon Mar 11 14:32:20 2019 New Revision: 355866 URL: http://llvm.org/viewvc/llvm-project?rev=355866&view=rev Log: [Reproducers] Reinterpret cast to void* Apparently the log_append variant added in r355863 is considered ambiguous. At this point I'm out of ideas so a good o

[Lldb-commits] [lldb] r355863 - [Reproducers] Implement log_append for function pointers.

Author: jdevlieghere Date: Mon Mar 11 13:31:21 2019 New Revision: 355863 URL: http://llvm.org/viewvc/llvm-project?rev=355863&view=rev Log: [Reproducers] Implement log_append for function pointers. Changing the type in the DUMMY macro to void* doesn't actually fix the build error, because the argu

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/TestImportStdModule.py:19 +@skipIf(oslist=no_match(["linux"])) +@ski

[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355850: Fix a crasher in StackFrame::GetValueForVariableExpressionPath() (authored by gclayton, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59200

[Lldb-commits] [lldb] r355850 - Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

Author: gclayton Date: Mon Mar 11 11:16:20 2019 New Revision: 355850 URL: http://llvm.org/viewvc/llvm-project?rev=355850&view=rev Log: Fix a crasher in StackFrame::GetValueForVariableExpressionPath() There was a crash that would happen if an IDE would ask for a child of a shared pointer via any

Re: [Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

Yeah given the evidence, maybe it's fine left as is. I worked around it locally so I am not blocked. Thanks! On Monday, March 11, 2019, Jonas Devlieghere wrote: > It's weird that this only occurs when building with Xcode, none of the > bots seem affected. Anyway, I'm updating the macros and veri

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

zturner added a comment. SBType storing a pair of CompilerType and TypeSP seems like a very confusing interface and like it will be very easy to misuse or violate assumptions (perhaps even assumptions that nobody knows exists). Why exactly is this necessary? As far as I can tell, `SBType` use

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/TestImportStdModule.py:19 +@skipIf(oslist=no_match(["linux"])) +@skipIf(debug_info=no_match(["dwarf"]))

[Lldb-commits] [lldb] r355843 - Makefile.rules: Upstream SDKROOT handling code for Darwin.

Author: adrian Date: Mon Mar 11 10:24:10 2019 New Revision: 355843 URL: http://llvm.org/viewvc/llvm-project?rev=355843&view=rev Log: Makefile.rules: Upstream SDKROOT handling code for Darwin. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/package

[Lldb-commits] [lldb] r355842 - [Reproducers] Replace callbacks with void*

Author: jdevlieghere Date: Mon Mar 11 10:17:51 2019 New Revision: 355842 URL: http://llvm.org/viewvc/llvm-project?rev=355842&view=rev Log: [Reproducers] Replace callbacks with void* Callbacks in the LLDB_RECORD_DUMMY macros were causing build failures with the Xcode project. This patch replaces t

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

aprantl added a comment. Interesting find. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59217/new/ https://reviews.llvm.org/D59217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

zturner added inline comments. Comment at: source/Target/StackFrame.cpp:644-645 if (error.Fail()) { error.SetErrorStringWithFormatv( "Failed to dereference sythetic value: %s", deref_error); return ValueObjectSP(); No

Re: [Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

It's weird that this only occurs when building with Xcode, none of the bots seem affected. Anyway, I'm updating the macros and verifying the build works locally when using Xcode. On Sun, Mar 10, 2019 at 3:25 PM Dave Lee via Phabricator < revi...@reviews.llvm.org> wrote: > kastiglione added a comm

[Lldb-commits] [lldb] r355841 - Bring Doxygen comment syntax in sync with LLVM coding style.

Modified: lldb/trunk/source/Target/StackFrame.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=355841&r1=355840&r2=355841&view=diff == --- lldb/trunk/source/Target/StackFrame.cpp (or

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

clayborg added a comment. Since unwinding is Jason's thing, he should give the ok for this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58347/new/ https://reviews.llvm.org/D58347 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

clayborg added a comment. In D58347#1424745 , @labath wrote: > Greg, what do you make of this patch? Do you still want me to clear the > unwind table instead of resetting it? No, Jason seems ok with it so I am good. CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added a comment. This looks mostly good now. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/TestImportStdModule.py:19 +@skipIf(oslist=no_match(["linux"])) +@skipIf(debug_info=no_match(["dwarf"])) +def test(self):

[Lldb-commits] [lldb] r355838 - [lldb] [test] Mark more tests flakey on NetBSD

Author: mgorny Date: Mon Mar 11 10:01:31 2019 New Revision: 355838 URL: http://llvm.org/viewvc/llvm-project?rev=355838&view=rev Log: [lldb] [test] Mark more tests flakey on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindExpression.py

[Lldb-commits] [PATCH] D59198: Correctly look up declarations in inline namespaces

teemperor updated this revision to Diff 190111. teemperor added a comment. - Addressed Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59198/new/ https://reviews.llvm.org/D59198 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Symbol/CompilerDecl

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

labath added a comment. Greg, what do you make of this patch? Do you still want me to clear the unwind table instead of resetting it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58347/new/ https://reviews.llvm.org/D58347 ___ lldb-commits

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

labath created this revision. labath added reviewers: clayborg, aprantl. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. In my next step at cleaning up modify-python-lldb.py, I started focusing on equality comparison. To my surprise, I found out that both python a

[Lldb-commits] [PATCH] D59159: [third-party] Update pexpect to 4.6.

JDevlieghere added a comment. In D59159#1424250 , @labath wrote: > Removing the `tests` directory and similar sounds like a good idea, though I > would be fine with leaving it in too. Apart from that, this looks good to me. There's a bunch of directorie

[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

clayborg updated this revision to Diff 190102. clayborg added a comment. Adrian's suggestion was right, much simpler test case now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59200/new/ https://reviews.llvm.org/D59200 Files: packages/Python/lldbsuite/test/functionalities/var_path/

[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py:101 +# The hit count for the breakpoint should be 1. +self.assertTrue(breakpoint.GetHitCount() == 1) + until here. run_to_source_bre

[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py:69 + +def do_test(self): +exe = self.getBuildArtifact("a.out") If I'm not mistaken, you might be able to replace the first 40 lines or s

[Lldb-commits] [PATCH] D59198: Correctly look up declarations in inline namespaces

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Symbol/ClangASTContext.cpp:10269 +void *opaque_decl_ctx, void *other_opaque_decl_ctx) { + auto decl_ctx = (clang::DeclContext *)opaque_decl

[Lldb-commits] [lldb] r355830 - [lldb] [test] Mark a few tests flakey on NetBSD

Author: mgorny Date: Mon Mar 11 08:46:07 2019 New Revision: 355830 URL: http://llvm.org/viewvc/llvm-project?rev=355830&view=rev Log: [lldb] [test] Mark a few tests flakey on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs.py lldb/trunk/packag

[Lldb-commits] [lldb] r355827 - Attempt to fix MSVC build error after r355824

Author: labath Date: Mon Mar 11 08:00:11 2019 New Revision: 355827 URL: http://llvm.org/viewvc/llvm-project?rev=355827&view=rev Log: Attempt to fix MSVC build error after r355824 Adding parens should be enough to fix the "'operator bool': is ambiguous or is not a member of 'lldb::SBFoo'" errors.

[Lldb-commits] [lldb] r355817 - Fix invalid use of StringRef::data in Socket::DecodeHostAndPort

Author: labath Date: Mon Mar 11 03:34:57 2019 New Revision: 355817 URL: http://llvm.org/viewvc/llvm-project?rev=355817&view=rev Log: Fix invalid use of StringRef::data in Socket::DecodeHostAndPort the input StringRef is not guaranteed to be null-terminated, so using data to get the c string is wr

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor updated this revision to Diff 190054. teemperor added a comment. - Addressed Pavel's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58125/new/ https://reviews.llvm.org/D58125 Files: lldb/include/lldb/Expression/ExpressionSourceCode.h lldb/include/lldb/Target/Plat

[Lldb-commits] [PATCH] D59159: [third-party] Update pexpect to 4.6.

labath accepted this revision. labath added a comment. Removing the `tests` directory and similar sounds like a good idea, though I would be fine with leaving it in too. Apart from that, this looks good to me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59159/ne

[Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. I think we should eventually get rid of all the stl-container-wrapper classes. (Apart from the SB ones, or course.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59165/new/ htt

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

labath added a comment. Thanks Raphael. Apart from some inline nits, I have no further comments from my side, but hopefully someone with more familiarity with modules and clang ASTs can give this the final pass. Comment at: lldb/include/lldb/Expression/ExpressionSourceCode.h: