[Lldb-commits] [lldb] r352733 - Revert "[CMake] Unify scripts for generating VCS headers"

Author: phosek Date: Wed Jan 30 23:12:43 2019 New Revision: 352733 URL: http://llvm.org/viewvc/llvm-project?rev=352733&view=rev Log: Revert "[CMake] Unify scripts for generating VCS headers" This reverts commits r352729 and r352731: this broke Sanitizer Windows bots Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r352731 - [CMake] Migrate lldb to the new VCS script

Author: phosek Date: Wed Jan 30 22:47:10 2019 New Revision: 352731 URL: http://llvm.org/viewvc/llvm-project?rev=352731&view=rev Log: [CMake] Migrate lldb to the new VCS script This was accidentaly omitted from r352729 and broke lldb bots. Modified: lldb/trunk/source/CMakeLists.txt lldb/t

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thomasanderson added a comment. In D57466#1377696 , @davide wrote: > As long as this doesn't break macOS, it's fine. (just run the tests and watch > the bots). Latest revision fixes 2 test failures on Linux. The first was because ".+" was matching too

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thomasanderson updated this revision to Diff 184418. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 Files: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp Index: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp =

[Lldb-commits] [lldb] r352710 - [testsuite] Fix TestAppleSimulator so that it works with Python 3.

Author: davide Date: Wed Jan 30 17:17:47 2019 New Revision: 352710 URL: http://llvm.org/viewvc/llvm-project?rev=352710&view=rev Log: [testsuite] Fix TestAppleSimulator so that it works with Python 3. Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py lldb/trunk/packages/Py

[Lldb-commits] [lldb] r352709 - [Python] Fix gdb-remote and lldb-server utilities to work with Py3.

Author: davide Date: Wed Jan 30 17:01:53 2019 New Revision: 352709 URL: http://llvm.org/viewvc/llvm-project?rev=352709&view=rev Log: [Python] Fix gdb-remote and lldb-server utilities to work with Py3. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

[Lldb-commits] [lldb] r352706 - [Python] Python 2 and Python 3 disagree on `/`.

Author: davide Date: Wed Jan 30 16:43:36 2019 New Revision: 352706 URL: http://llvm.org/viewvc/llvm-project?rev=352706&view=rev Log: [Python] Python 2 and Python 3 disagree on `/`. One considers it integer division, the other doesn't. Move to `//` (floor division) so that this test passes indepen

[Lldb-commits] [lldb] r352703 - Add Sphinx generated html files as output to the build phase.

Author: jdevlieghere Date: Wed Jan 30 16:40:38 2019 New Revision: 352703 URL: http://llvm.org/viewvc/llvm-project?rev=352703&view=rev Log: Add Sphinx generated html files as output to the build phase. This will ensure we don't rerun Sphinx when the files exist. Modified: lldb/trunk/lldb.xcod

Re: [Lldb-commits] [lldb] r352701 - [Python] String(s) and bytes are two different entities in 3.7.

On Wed, Jan 30, 2019 at 4:11 PM Davide Italiano via lldb-commits wrote: > > Author: davide > Date: Wed Jan 30 16:11:33 2019 > New Revision: 352701 > > URL: http://llvm.org/viewvc/llvm-project?rev=352701&view=rev > Log: > [Python] String(s) and bytes are two different entities in 3.7. > > So, we ne

[Lldb-commits] [lldb] r352701 - [Python] String(s) and bytes are two different entities in 3.7.

Author: davide Date: Wed Jan 30 16:11:33 2019 New Revision: 352701 URL: http://llvm.org/viewvc/llvm-project?rev=352701&view=rev Log: [Python] String(s) and bytes are two different entities in 3.7. So, we need an explicit call to decode() here to let it work with both interpreters. Fixes TestXMMRe

[Lldb-commits] [lldb] r352696 - Add lldb-docs target to Xcode project

Author: jdevlieghere Date: Wed Jan 30 15:56:55 2019 New Revision: 352696 URL: http://llvm.org/viewvc/llvm-project?rev=352696&view=rev Log: Add lldb-docs target to Xcode project This patch adds the lldb-docs target which generates the Sphinx html documentation. Modified: lldb/trunk/lldb.xcode

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere added a comment. It doesn't really make sense to land this without the SBReproducer framework, so I'll leave it open until that gets accepted as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 __

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 184392. JDevlieghere added a comment. - Skip decls that have a canonical decl in the implementation file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeLists.txt tools/sbrepro/CM

[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning this in favor of D56322 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55582/new/ https://reviews.llvm.org/D55582 ___ lldb-commi

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere added a comment. I split off the framework (this revision) and the addition of the macros (D57475 ). I plan on updating the patch with tests, but I believe it's ready for review in the meantime. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. JDevlieghere added a project: LLDB. Herald added a reviewer: jfb. This patch adds the SBReproducer macros needed to capture and reply the corresponding calls. The patch was generated using the SBRepro tool (D56822

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 184367. JDevlieghere retitled this revision from "SBReproducer prototype" to "[Reproducers] SBReproducer framework". JDevlieghere edited the summary of this revision. JDevlieghere added reviewers: labath, davide, aprantl, zturner, jingham. JDevlieghere se

[Lldb-commits] [PATCH] D57363: Fix handling of CreateTemplateParameterList when there is an empty pack

This revision was automatically updated to reflect the committed changes. Closed by commit rL352677: Fix handling of CreateTemplateParameterList when there is an empty pack (authored by shafik, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [lldb] r352677 - Fix handling of CreateTemplateParameterList when there is an empty pack

Author: shafik Date: Wed Jan 30 13:48:56 2019 New Revision: 352677 URL: http://llvm.org/viewvc/llvm-project?rev=352677&view=rev Log: Fix handling of CreateTemplateParameterList when there is an empty pack Summary: When we are creating a ClassTemplateSpecializationDecl in ParseTypeFromDWARF(...)

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

aprantl added a comment. Thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57467/new/ https://reviews.llvm.org/D57467 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. As long as this doesn't break macOS, it's fine. (just run the tests and watch the bots). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://re

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57467/new/ https://reviews.llvm.org/D57467 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thakis added a comment. aprantl might be a good reviewer for this. The motivation here is that we set `_LIBCPP_ABI_VERSION` for chromium, which then confuses lldb. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

shafik created this revision. shafik added reviewers: aprantl, jingham. Herald added a reviewer: serge-sans-paille. The method find_matching_slice(self) uses `uuid_str` on one of the paths but the variable does not exist and so this results in a NameError exception if we take that path. https:

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thomasanderson created this revision. thomasanderson added reviewers: EricWF, thakis. Herald added subscribers: abidh, jfb. libc++ has programmable ABI versioning controllable with the _LIBCPP_ABI_VERSION macro. Currently there are at least 3 settings used in real systems (1 as the default, ndk1

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ok, looks good then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 ___ lldb-commits mailing li

Re: [Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

On Wed, Jan 30, 2019 at 10:53 AM Zachary Turner wrote: > > Oh I guess because one of them has const values? Oh well, ignore my > suggestion then :) > I think so. Too bad, it would've been a nice cleanup :) -- Davide ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

Oh I guess because one of them has const values? Oh well, ignore my suggestion then :) On Wed, Jan 30, 2019 at 10:50 AM Davide Italiano via Phabricator < revi...@reviews.llvm.org> wrote: > davide marked an inline comment as done. > davide added inline comments. > > > > Comment a

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:168 + swapped_words[6] = apint_words[1]; + swapped_words[7] = apint_words[0]; + apint_words = swapped_words; zturner wrote: > davide w

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

zturner added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:168 + swapped_words[6] = apint_words[1]; + swapped_words[7] = apint_words[0]; + apint_words = swapped_words; davide wrote: > davide wrote: > > aprantl wrote: > > > std::rever

[Lldb-commits] [lldb] r352643 - [Scalar] Remove partially wrong and unused functions.

Author: davide Date: Wed Jan 30 10:40:05 2019 New Revision: 352643 URL: http://llvm.org/viewvc/llvm-project?rev=352643&view=rev Log: [Scalar] Remove partially wrong and unused functions. I originally thought about fixing them, but hey, nobody is using them anyway. Modified: lldb/trunk/includ

[Lldb-commits] [lldb] r352641 - [Scalar] Hoist a duplicated (and sometimes wrong) comment.

Author: davide Date: Wed Jan 30 10:24:16 2019 New Revision: 352641 URL: http://llvm.org/viewvc/llvm-project?rev=352641&view=rev Log: [Scalar] Hoist a duplicated (and sometimes wrong) comment. Pointed out by Zachary and Adrian. Modified: lldb/trunk/source/Utility/Scalar.cpp Modified: lldb/tr

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:168 + swapped_words[6] = apint_words[1]; + swapped_words[7] = apint_words[0]; + apint_words = swapped_words; davide wrote: > aprantl w

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 184325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: source/Host/windows/ProcessLauncherWindows.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 184323. asmith retitled this revision from "Implement GetFileLoadAddress for the Windows process plugin" to "Implement GetLoadAddress for the Windows process plugin". asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] r352639 - [Scalar] Implement support for 512-bit values.

Author: davide Date: Wed Jan 30 10:05:36 2019 New Revision: 352639 URL: http://llvm.org/viewvc/llvm-project?rev=352639&view=rev Log: [Scalar] Implement support for 512-bit values. (useful, e.g. when reading 512-bits registers, a-la AVX-512). Modified: lldb/trunk/include/lldb/Utility/Scalar

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. This is really cool, thanks for doing this! Comment at: source/Expression/DWARFExpression.cpp:3253 - return false; + return true; } Why do we change t

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere added a comment. In D56822#1376770 , @labath wrote: > So, if I understand this correctly, a constructor like `SBFoo::SBFoo(){}` > will not be considered for macroization because it's empty? That doesn't > sound right to me. Even an empty con

[Lldb-commits] [PATCH] D57378: [CMake] Accept entitlements for code signing in add_lldb_library()

This revision was automatically updated to reflect the committed changes. Closed by commit rL352629: [CMake] Accept entitlements for code signing in add_lldb_library() (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[Lldb-commits] [lldb] r352629 - [CMake] Accept entitlements for code signing in add_lldb_library()

Author: stefan.graenitz Date: Wed Jan 30 07:13:16 2019 New Revision: 352629 URL: http://llvm.org/viewvc/llvm-project?rev=352629&view=rev Log: [CMake] Accept entitlements for code signing in add_lldb_library() Summary: D57334 added entitlements support in `add_llvm_library()` so we can use it for

[Lldb-commits] [PATCH] D57334: [CMake] Accept ENTITLEMENTS in llvm_add_library()

This revision was automatically updated to reflect the committed changes. Closed by commit rL352628: [CMake] Accept ENTITLEMENTS in llvm_add_library() (authored by stefan.graenitz, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57334/new/ https://rev

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. As D56725 committed, can you please look at latest changes here? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 __