[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

2019-01-13 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added a comment. In D56531#1352298 , @mgorny wrote: > Please don't risk merging this before the branching. +1 The official branch goal is Wednesday this week. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(

Re: [Lldb-commits] [PATCH] D56458: Fix unused private field warning.

2019-01-13 Thread David Blaikie via lldb-commits
Might be better to only define the variable if HAVE_LIBCOMPRESSION is defined? On Wed, Jan 9, 2019 at 8:58 AM Raphael Isemann via Phabricator via llvm-commits wrote: > This revision was not accepted when it landed; it landed in state "Needs > Review". > This revision was automatically updated to