[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

jingham accepted this revision. jingham added a comment. I think the ideal behavior would be "if we don't have debug info for the frame, choose ObjC++". But if you are in frame with debug info, obey that frame's language (except that we have to use C++ because the expression parser uses C++ re

[Lldb-commits] [lldb] r348232 - [PlatformDarwin] Simplify logic and use FileSystem

Author: jdevlieghere Date: Mon Dec 3 18:23:16 2018 New Revision: 348232 URL: http://llvm.org/viewvc/llvm-project?rev=348232&view=rev Log: [PlatformDarwin] Simplify logic and use FileSystem Simplify code path by using the FileSystem. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/Platfo

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

JDevlieghere updated this revision to Diff 176525. JDevlieghere added a comment. Initialize the FS in the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55240/new/ https://reviews.llvm.org/D55240 Files: include/lldb/Host/FileSystem.h source/Commands/CommandCompletions.cpp

Re: [Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

The idea is that if you specify -mode=compile, then no link happens and the output is potentially many object files. If there's only one object file, then we allow the user to specify the name of that output. But if there's multiple, then it's hard to specify that with a single command line invoc

Re: [Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

If that's the case, you specify -mode="compile-and-link" and you can specify the output. That will work fine. The condition in the code only checks for -mode='compile' On Mon, Dec 3, 2018 at 3:38 PM Stella Stamenova wrote: > Are there no cases where you want all of the input files to be compil

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

davide added a comment. No objections from me, but I would appreciate if @labath can take a look. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55240/new/ https://reviews.llvm.org/D55240 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath. JDevlieghere added a project: LLDB. Make use of the convenience helpers from FileSystem. Repository: rLLDB LLDB https://reviews.llvm.org/D55240 Files: include/lldb/Host/FileSystem.h source/Commands/CommandC

Re: [Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

Are there no cases where you want all of the input files to be compiled into a single executable? From: Zachary Turner Sent: Monday, December 3, 2018 3:36 PM To: reviews+d55230+public+74273d963dffb...@reviews.llvm.org Cc: pa...@labath.sk; Stella Stamenova ; aleksandr.ura...@jetbrains.com; clayb

Re: [Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

If you have -o and multiple input files, which output file are you specifying? It seems easier to just say that if multiple input files are present, the output file names are automatically calculated On Mon, Dec 3, 2018 at 2:48 PM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote:

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

stella.stamenova added inline comments. Comment at: lldb/lit/helper/build.py:664 +if args.output and args.mode == 'compile' and len(args.inputs) > 1: +raise ValueError('Cannot specify -o with mode=compile and multiple source files. Use --outdir instead.') +

[Lldb-commits] [lldb] r348207 - [FileSystem] Migrate MonitoringProcessLauncher

Author: jdevlieghere Date: Mon Dec 3 14:41:32 2018 New Revision: 348207 URL: http://llvm.org/viewvc/llvm-project?rev=348207&view=rev Log: [FileSystem] Migrate MonitoringProcessLauncher Use the FileSystem helpers instead of using the file system directly. Modified: lldb/trunk/source/Host/com

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

I will just add that once upon a time, there was a test in LLVM that worked similar to this, and so it would try to open a file like /foo/foo.txt, and expect it to fail (meaning that if it succeeded, the test would fail). I had once created that file on my hard drive by pure coincidence, and so th

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

zturner added a comment. In D55230#1317320 , @clayborg wrote: > What is the reason we aren't using cmake + ninja for this kind of stuff? Or > is it using it under the covers? CMake gives you a nice static configuration for how you want to build your hos

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

That wouldn't work because we try to create the directory which would succeeded in the temp dir. I'd have to be something you don't have access to, like the root or some network drive. On Mon, Dec 3, 2018 at 12:53 PM Zachary Turner wrote: > Perhaps use %t.bogus? instead of /bogus? > > On Mon, De

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

clayborg added a comment. What is the reason we aren't using cmake + ninja for this kind of stuff? Or is it using it under the covers? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55230/new/ https://reviews.llvm.org/D55230 ___ lldb-commit

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

Perhaps use %t.bogus? instead of /bogus? On Mon, Dec 3, 2018 at 12:39 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jdevlieghere > Date: Mon Dec 3 12:36:21 2018 > New Revision: 348186 > > URL: http://llvm.org/viewvc/llvm-project?rev=348186&view=rev > Log:

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

markmentovai added a comment. Very excited to see this work beginning! Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84 + if (os == llvm::Triple::Win32) { +// In binary form, the module id should have 20 bytes: 16 bytes for UUID, +// and 4 by

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere added a comment. In D55038#1317099 , @stella.stamenova wrote: > One of these tests fail on Windows (TestDriverOptions): > > http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1848/steps/test/logs/stdio Thanks, I've disabled the

[Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

Author: jdevlieghere Date: Mon Dec 3 12:36:21 2018 New Revision: 348186 URL: http://llvm.org/viewvc/llvm-project?rev=348186&view=rev Log: Skip TestDriverOptions on Windows It's not clear to me why this is failing on Windows. Maybe it has something to do with the path? Modified: lldb/trunk/l

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

zturner created this revision. zturner added reviewers: labath, stella.stamenova, aleksandr.urakov. Herald added a subscriber: mgorny. This patch introduces two improvements to the `build.py` script. First, it supports multiple build inputs and outputs. This is helpful if you want to run with `

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

stella.stamenova added a comment. One of these tests fail on Windows: Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55038/new/ https://reviews.llvm.org/D55038 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348152: [Reproducers] Change how reproducers are initialized. (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55038

[Lldb-commits] [lldb] r348152 - [Reproducers] Change how reproducers are initialized.

Author: jdevlieghere Date: Mon Dec 3 09:28:29 2018 New Revision: 348152 URL: http://llvm.org/viewvc/llvm-project?rev=348152&view=rev Log: [Reproducers] Change how reproducers are initialized. This patch changes the way the reproducer is initialized. Rather than making changes at run time we now

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

Ok, thank you! I'll contact you when I will be ready to work on the new plugin. Am Mo., 3. Dez. 2018, 20:07 hat Zachary Turner geschrieben: > Ok that makes sense. I’ll work on this soon, I’m trying to get all > existing dia PDB tests passing with the native plugin so i can delete old > plugin, s

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

Ok that makes sense. I’ll work on this soon, I’m trying to get all existing dia PDB tests passing with the native plugin so i can delete old plugin, so I’ll keep this in mind and probably do this next. I’m trying to fix some bugs in clang so that we emit compatible debug info to msvc, which curren

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

If I understand correctly, the native plugin processes for now globals and constants, but it can't create locals, right? But this FPO conversion is applicable to locals only, so we need to implement locals creation in the new plugin first, before moving the conversion there. That's why we need thes

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

Is the only reason we need these methods so that we can use lldb-test? If so, perhaps the tests can be written in terms of lldb itself, similar to the existing NativePDB tests On Mon, Dec 3, 2018 at 8:39 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov adde

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

aleksandr.urakov added a comment. I can do it, but unfortunately not this week... I want to join the native plugin development some later, at the end of this month, after some current work. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://revi

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

In that case, can we implement that method first? I was planning to do it this week, but if someone else wants to do it immediately that’s fine too On Mon, Dec 3, 2018 at 8:11 AM Leonid Mashinskiy via Phabricator < revi...@reviews.llvm.org> wrote: > leonid.mashinskiy added a comment. > > Seems lik

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. Seems like we can't move to NativePDB plugin right now, because there are still not implemented some methods like `ParseVariablesForContext` which this code integration based on. But when it will - we can easily do the transition. Repository: rLLDB LLDB CH

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 176411. leonid.mashinskiy added a comment. Added unit tests for translator and fix issues mentioned by review Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 Files: lit/

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This looks like a good start. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55214/new/ https://reviews.llvm.org/D55214 ___ lldb-comm

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

clayborg added a comment. Looks fine to me. Jim Ingham should ok this as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

On 29/11/2018 23:34, Greg Clayton wrote: On Nov 29, 2018, at 10:55 AM, Pavel Labath via Phabricator wrote: labath added a comment. I've recently started looking at adding a new symbol file format (breakpad symbols). While researching the best way to achieve that, I started comparing the

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov marked an inline comment as done. aleksandr.urakov added a comment. Ping! Can you look at this, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84 + if (os == llvm::Triple::Win32) { +// In binary form, the module id should have 20 bytes: 16 bytes for UUID, +// and 4 bytes for the "age". However, in the textual

[Lldb-commits] [lldb] r348136 - [PDB] Support PDB-backed expressions evaluation (+ fix stuck test)

Author: aleksandr.urakov Date: Mon Dec 3 05:31:13 2018 New Revision: 348136 URL: http://llvm.org/viewvc/llvm-project?rev=348136&view=rev Log: [PDB] Support PDB-backed expressions evaluation (+ fix stuck test) Summary: This patch contains several small fixes, which makes it possible to evaluate e

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath created this revision. labath added reviewers: clayborg, zturner, lemo, amccarth. Herald added subscribers: fedor.sergeev, mgorny. This patch adds the scaffolding necessary for lldb to recognise symbol files generated by breakpad. These (textual) files contain just enough information to be

[Lldb-commits] [PATCH] D55114: [CMake] Add LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR for custom dSYM target directory on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL348118: [CMake] Add LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR for custom dSYM target… (authored by stefan.graenitz, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D55128: [CMake] Store path to vendor-specific headers in clang-headers target property

This revision was automatically updated to reflect the committed changes. Closed by commit rL348116: [CMake] Store path to vendor-specific headers in clang-headers target property (authored by stefan.graenitz, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D55038#1314968 , @JDevlieghere wrote: > In D55038#1314336 , @labath wrote: > > > I think the canonical way

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

labath added a comment. I don't see any tests :(. Also, the three bullet points in the description sound like rather independent pieces of functionality. Would it be possible to split them up into separate patches? That would make things easier to review, particularly for those who don't look

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for adding the test. looks good to me. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:289-291 + mutable std::unique_ptr m_filespec_ap; + typedef llv