[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. @jingham If you're still willing to review this change to `command regex`, it is updated per our previous discussion, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

jingham added a comment. The exception breakpoints know that libobjc.B.dylib`objc_exception_throw is where you stop for exception breakpoints, and now the ObjCExceptionRecognizer knows the same thing. It always makes me nervous when two different places have the same hard-coded string. Can we

[Lldb-commits] [lldb] r347725 - [unittest] Fix the FileSystem test on Windows. (Attempt #2)

Author: jdevlieghere Date: Tue Nov 27 17:18:10 2018 New Revision: 347725 URL: http://llvm.org/viewvc/llvm-project?rev=347725&view=rev Log: [unittest] Fix the FileSystem test on Windows. (Attempt #2) This fixes the double escaping and compares FileSpecs instead of strings. Modified: lldb/trun

[Lldb-commits] [lldb] r347717 - [lldbsuite] Each lldb suite test must have a unique class name

Author: stella.stamenova Date: Tue Nov 27 14:18:02 2018 New Revision: 347717 URL: http://llvm.org/viewvc/llvm-project?rev=347717&view=rev Log: [lldbsuite] Each lldb suite test must have a unique class name A couple of new tests have been added that use existing class names. This causes failures

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347716: [Reproducers] Improve reproducer API and add unit tests. (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54

[Lldb-commits] [lldb] r347716 - [Reproducers] Improve reproducer API and add unit tests.

Author: jdevlieghere Date: Tue Nov 27 14:11:02 2018 New Revision: 347716 URL: http://llvm.org/viewvc/llvm-project?rev=347716&view=rev Log: [Reproducers] Improve reproducer API and add unit tests. When I landed the initial reproducer framework I knew there were some things that needed improvement.

[Lldb-commits] [lldb] r347712 - [unittest] Fix the FileSystem test on Windows.

Author: jdevlieghere Date: Tue Nov 27 13:20:35 2018 New Revision: 347712 URL: http://llvm.org/viewvc/llvm-project?rev=347712&view=rev Log: [unittest] Fix the FileSystem test on Windows. On Windows, when using the VFS without going through FileSpec, the absolute path to `/foo` is `\\foo`. This upd

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347709: [Driver] Use libOption with tablegen. (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54692?vs=175526&id=17

[Lldb-commits] [lldb] r347709 - [Driver] Use libOption with tablegen.

Author: jdevlieghere Date: Tue Nov 27 13:00:32 2018 New Revision: 347709 URL: http://llvm.org/viewvc/llvm-project?rev=347709&view=rev Log: [Driver] Use libOption with tablegen. This patch modifies the lldb driver to use libOption for option parsing. It allows us to decouple option parsing from op

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. In D54914#1309700 , @labath wrote: > I didn't look at the code in detail, as most of it deals with windows stuff, > and I don't know much about those anyway. However, the interesting question > for me would be how to make this us

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner updated this revision to Diff 175561. zturner added a comment. Updated with suggestions. Currently all NativePDB tests pass with this version of the script, and all other tests are unaffected since they don't use the new substitution. Subsequent followups will focus on getting other te

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54616/new/ https://reviews.llvm.org/D54616 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

labath added a comment. I haven't been following the reproducer work in detail, but this seems reasonable to me. Thanks for incorporating my drive-by suggestions. Comment at: include/lldb/Utility/Reproducer.h:104 + template T *Create() { +std::unique_ptr provider(new T(m

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

zturner added a comment. > Clang called from the builder shows errors on types like char16_t and > char32_t. That's why enums-layout.test and typedefs.test are made to use MSVC > instead; For me enums-layout.test crashes, but I see the same behavior in typedefs.test. This is because lld-link

[Lldb-commits] [lldb] r347693 - [CMake] Pass full libedit path to linker

Author: tkrasnukha Date: Tue Nov 27 11:41:30 2018 New Revision: 347693 URL: http://llvm.org/viewvc/llvm-project?rev=347693&view=rev Log: [CMake] Pass full libedit path to linker Otherwise, linker fails with "cannot find -ledit" in case of custom libedit installation. Modified: lldb/trunk/so

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

JDevlieghere added a comment. Does anybody want to have another look or can I land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54616/new/ https://reviews.llvm.org/D54616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere updated this revision to Diff 175526. JDevlieghere added a comment. - Add EXAMPLES section CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 Files: lit/Driver/Inputs/Print0.in lit/Driver/Inputs/Print2.in lit/Driver/Inputs/Print4

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:355-356 + if (addr_base == LLDB_INVALID_ADDRESS) +addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, + DW_AT_GNU_addr_base,

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

clayborg added a comment. I would be happy if we just have an EXAMPLES section much like many of the man pages for built in shell commands where we show a few examples. I would like to see setting up a target a program with arguments that might conflict with the argument parser like: % lldb

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. In D54914#1309901 , @aprantl wrote: > I would like to ask a general question that I (indirectly) also asked in > D54731 : Why do we want to implement support > for building inferiors in LIT-based

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

JDevlieghere updated this revision to Diff 175505. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Add lit test for command options. - Change usage with prose. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54692/new/ https://reviews.llvm.org/D54692 Fil

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

aprantl added a comment. I would like to ask a general question that I (indirectly) also asked in D54731 : Why do we want to implement support for building inferiors in LIT-based tests? IMHO, if we need to support for dealing with specific compilers, we should i

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. > Currently lit supports running shell commands through the use of the RUN: > prefix. This patch allows individual test suites to install their own run > handlers that can do thin

[Lldb-commits] [lldb] r347673 - Catch up with EvaluateAsInt() clang API change.

Author: davide Date: Tue Nov 27 08:40:21 2018 New Revision: 347673 URL: http://llvm.org/viewvc/llvm-project?rev=347673&view=rev Log: Catch up with EvaluateAsInt() clang API change. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp U

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

stella.stamenova added a comment. This looks fine, but let's see if Zachary's change lands first and how it looks like after it lands :). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 __

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

labath added inline comments. Comment at: source/Core/RichManglingContext.cpp:134-135 get(m_cxx_method_parser)->GetBasename(); +if (!m_buffer.data()) + m_buffer = llvm::StringRef("", 0); return; Why is this necessary? It looks like somebody

Re: [Lldb-commits] [lldb] r347615 - [FileSystem] Ignore nanoseconds when comparing oso_mod_time

You're right, fixed in r347660. On Tue, Nov 27, 2018 at 6:24 AM Pavel Labath wrote: > Was it necessary to modify FileSystem to achieve this. It looks like you > could have just as easily made the time_point_cast in > SymbolFileDWARFDebugMap (next to a comment explaining why that was needed). > >

[Lldb-commits] [lldb] r347660 - Move time cast to SymbolFileDWARFDebugMap

Author: jdevlieghere Date: Tue Nov 27 07:25:58 2018 New Revision: 347660 URL: http://llvm.org/viewvc/llvm-project?rev=347660&view=rev Log: Move time cast to SymbolFileDWARFDebugMap When trying to fix the bots we expected that the cast would be needed in different places. Ultimately it turned out

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

labath added a comment. I didn't look at the code in detail, as most of it deals with windows stuff, and I don't know much about those anyway. However, the interesting question for me would be how to make this useful for cross-compiling. Right now that sort of works for NativePDB tests because

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

labath added inline comments. Comment at: tools/driver/Driver.cpp:876-888 + usage << indent << tool_name +<< " -a -f [-c ] [-s ] [-o " + "] [-S ] [-O ] [-k ] [-K ] " + "[-Q] [-b] [-e] [-x] [-X] [-l ] [-d] [-z " + "] [[--] [ ...]]\n"; + u

Re: [Lldb-commits] [lldb] r347615 - [FileSystem] Ignore nanoseconds when comparing oso_mod_time

Was it necessary to modify FileSystem to achieve this. It looks like you could have just as easily made the time_point_cast in SymbolFileDWARFDebugMap (next to a comment explaining why that was needed). The extra nanosecond_precision argument looks fairly odd, and diverges from how the llvm in

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

asmith accepted this revision. asmith added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar updated this revision to Diff 175456. grimar added a comment. - Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751 Files: lit/Breakpoint/Inputs/split-dwarf-5-addrbase.dwo.yaml lit/Breakpoint/Inputs/split-dwarf-

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov marked 2 inline comments as done. aleksandr.urakov added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:404 -// non-Apple platforms, but for now it is needed. -m_compiler->getLangOpts().ObjC = true; break

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov updated this revision to Diff 175443. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 Files: packages/Python/lldbsuite/test/expression_command/options/TestExprOptions.py packages/Python/lldbsuite/test/expression_command/option

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

aleksandr.urakov added a comment. In D54914#1308919 , @zturner wrote: > @aleksandr.urakov Would you also mind giving this a try? I think it will > mean that you can re-write the SymbolFile/PDB tests to not be dependent on > running from a VS command pro

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, stella.stamenova. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch makes old PDB plugin tests to use the new builder (see D54914