[Lldb-commits] [PATCH] D53506: [ClangASTContext] Extract VTable pointers from C++ objects

aleksandr.urakov added a comment. Ping! Is it ok to proceed with it? Does anyone have objections? Repository: rLLDB LLDB https://reviews.llvm.org/D53506 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D54135: Add convenience method in FileSystem to check if a path/filespec is a directory.

krytarowski added a comment. Why? We already put a lot of effort into reusing code from LLVM. Repository: rLLDB LLDB https://reviews.llvm.org/D54135 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D54135: Add convenience method in FileSystem to check if a path/filespec is a directory.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. JDevlieghere added a project: LLDB. Herald added subscribers: teemperor, emaste. Replace calls to LLVM's is_directory with calls to LLDB's FileSytem class. For this I introduced a new convenience method that, like t

Re: [Lldb-commits] [lldb] r346186 - [TestVLA] Fix a python decorator.

Thanks!! You could also change the import line to > from lldbsuite.test.decorators import * and leave the decorator as-is. -- adrian > On Nov 5, 2018, at 4:21 PM, Davide Italiano wrote: > > @Adrian, this should be fairly straightforward, but a post-commit > review is always appreciated. >

Re: [Lldb-commits] [lldb] r346186 - [TestVLA] Fix a python decorator.

@Adrian, this should be fairly straightforward, but a post-commit review is always appreciated. On Mon, Nov 5, 2018 at 4:20 PM Davide Italiano via lldb-commits wrote: > > Author: davide > Date: Mon Nov 5 16:18:17 2018 > New Revision: 346186 > > URL: http://llvm.org/viewvc/llvm-project?rev=346186&

[Lldb-commits] [lldb] r346186 - [TestVLA] Fix a python decorator.

Author: davide Date: Mon Nov 5 16:18:17 2018 New Revision: 346186 URL: http://llvm.org/viewvc/llvm-project?rev=346186&view=rev Log: [TestVLA] Fix a python decorator. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [PATCH] D52672: Set stdout/stdin to binary mode on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346174: Set stdout/stdin to binary mode on Windows (authored by lanza, committed by ). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D52672?vs=168705&id=1

[Lldb-commits] [lldb] r346172 - Skip this test on older versions of clang.

Author: adrian Date: Mon Nov 5 14:19:22 2018 New Revision: 346172 URL: http://llvm.org/viewvc/llvm-project?rev=346172&view=rev Log: Skip this test on older versions of clang. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [PATCH] D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346171: Add a relocation to ObjectFileELF::ApplyRelocations and a test (authored by lanza, committed by ). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

shafik added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:336 + llvm::itanium_demangle::Node *parseType() { +if (llvm::StringRef(First, Last - First).startswith(Search)) { + Result += llvm::StringRef(Written, First - Written); ---

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. Thanks for your patience! Repository: rL LLVM https://reviews.llvm.org/D53530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

This revision was automatically updated to reflect the committed changes. Closed by commit rL346165: Fix (and improve) the support for C99 variable length array types (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [lldb] r346165 - Fix (and improve) the support for C99 variable length array types

Author: adrian Date: Mon Nov 5 12:49:07 2018 New Revision: 346165 URL: http://llvm.org/viewvc/llvm-project?rev=346165&view=rev Log: Fix (and improve) the support for C99 variable length array types Clang recently improved its DWARF support for C VLA types. The DWARF now looks like this: 0x0

[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected

cameron314 added a comment. Ping? Repository: rLLDB LLDB https://reviews.llvm.org/D53412 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r346162 - Fix the Xcode project for the removal of the Go, Java & OCaml

Author: jingham Date: Mon Nov 5 12:15:27 2018 New Revision: 346162 URL: http://llvm.org/viewvc/llvm-project?rev=346162&view=rev Log: Fix the Xcode project for the removal of the Go, Java & OCaml plugins. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj

[Lldb-commits] [PATCH] D54060: Remove OCaml debugger plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL346159: Remove OCaml debugger plugin (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54060?vs=172464&id=172627#toc

[Lldb-commits] [lldb] r346159 - Remove OCaml debugger plugin

Author: jdevlieghere Date: Mon Nov 5 11:34:03 2018 New Revision: 346159 URL: http://llvm.org/viewvc/llvm-project?rev=346159&view=rev Log: Remove OCaml debugger plugin In January Davide sent an e-mail to the mailing list to suggest removing unmaintained language plugins such as Go and Java. The p

Re: [Lldb-commits] [lldb] r346149 - Add a target modules dump ast command.

r346156. On Mon, Nov 5, 2018 at 11:09 AM Davide Italiano wrote: > On Mon, Nov 5, 2018 at 9:42 AM Zachary Turner via lldb-commits > wrote: > > > > Author: zturner > > Date: Mon Nov 5 09:40:28 2018 > > New Revision: 346149 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=346149&view=rev > >

[Lldb-commits] [lldb] r346156 - Properly cast from DeclContext to Decl.

Author: zturner Date: Mon Nov 5 11:25:39 2018 New Revision: 346156 URL: http://llvm.org/viewvc/llvm-project?rev=346156&view=rev Log: Properly cast from DeclContext to Decl. Apparently there's a special procedure for doing this. Not following this silently breaks builds. Modified: lldb/trun

Re: [Lldb-commits] [lldb] r346149 - Add a target modules dump ast command.

On Mon, Nov 5, 2018 at 9:42 AM Zachary Turner via lldb-commits wrote: > > Author: zturner > Date: Mon Nov 5 09:40:28 2018 > New Revision: 346149 > > URL: http://llvm.org/viewvc/llvm-project?rev=346149&view=rev > Log: > Add a target modules dump ast command. > > This is useful for investigating th

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

erik.pilkington added a comment. Looks good to me too, thanks! https://reviews.llvm.org/D54074 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

Thanks for doing this! Why do we care about the file name of the test, shouldn't we be using the test class name for everything (that one I did remember to change...) Jim > On Nov 3, 2018, at 11:18 PM, Jan Kratochvil via Phabricator > wrote: > > jankratochvil added a comment. > > In https

[Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

jingham added a subscriber: aprantl. jingham added a comment. Thanks for doing this! Why do we care about the file name of the test, shouldn't we be using the test class name for everything (that one I did remember to change...) Jim Repository: rL LLVM https://reviews.llvm.org/D54056 _

[Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL346149: Add a target modules dump ast command. (authored by zturner, committed by ). Herald added a subscriber: llvm-commi

[Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

zturner added a comment. I updated the patch to not dump color. We can address the color issue in a followup. So for now it just goes to the result object's output stream. Perhaps we can add a `-c` option that ignores the result object's outptu stream (and is documented as doing so), but I'l

[Lldb-commits] [lldb] r346149 - Add a target modules dump ast command.

Author: zturner Date: Mon Nov 5 09:40:28 2018 New Revision: 346149 URL: http://llvm.org/viewvc/llvm-project?rev=346149&view=rev Log: Add a target modules dump ast command. This is useful for investigating the clang ast as you reconstruct it via by parsing debug info. It can also be used to writ

[Lldb-commits] [PATCH] D54059: Remove Java debugger plugin

tberghammer added inline comments. Comment at: tools/lldb-test/SystemInitializerTest.cpp:194 SystemRuntimeMacOSX::Initialize(); RenderScriptRuntime::Initialize(); - JavaLanguageRuntime::Initialize(); davide wrote: > Aside, do you know why we have renderscr

[Lldb-commits] [PATCH] D54059: Remove Java debugger plugin

davide added inline comments. Comment at: tools/lldb-test/SystemInitializerTest.cpp:194 SystemRuntimeMacOSX::Initialize(); RenderScriptRuntime::Initialize(); - JavaLanguageRuntime::Initialize(); Aside, do you know why we have renderscript support? maybe th

[Lldb-commits] [PATCH] D54057: Remove Go debugger plugin

davide accepted this revision. davide added a comment. LGTM. Thanks for picking up the slack. https://reviews.llvm.org/D54057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Nice. For parameter lists of `reset` and `substitute` indentation could be fixed, but otherwise this looks really good to me. https://reviews.llvm.org/D54074

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for making the changes! https://reviews.llvm.org/D53530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [PATCH] D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter

clayborg added a comment. LGTM. lldbassert to check that AST in "enum_type" is the same as "this" since we now can after switching to CompilerType as arg instead of opaque clang type pointer. Comment at: include/lldb/Symbol/ClangASTContext.h:909 clang::EnumConstantDecl *Ad

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

clayborg added a comment. So it depends on what code was retrieving the symbol table from the object file. Can you detail where this was happening? Repository: rLLDB LLDB https://reviews.llvm.org/D53368 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

clayborg added a comment. Just a few nits, but _very_ close. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:65 typedef std::vector CompileUnitColl; + typedef std::unordered_map TypeSignatureMap; Use llvm::DenseMap here? Co

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

labath updated this revision to Diff 172583. labath added a comment. Thanks for the review. I think that creating the new BumpPtrAllocator every call doesn't matter much here, this function get's called only on a few symbols for each evaluated expression. However, it also wasn't too hard to reu

[Lldb-commits] [PATCH] D54072: Add a command to dump a module's clang ast.

labath added a comment. If it comes down to choosing between colored output going to stderr and plain output going where it should, i'd go with the second option. The way I'd implement this to support both things is approximately this: - add color (`has_colors`, `changeColor` and friends) suppo

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

sgraenitz added a comment. Hi Pavel, thanks for working on this. The code looks really great. I have no actual concerns about landing it like this. Two minor remarks: - We still have no coverage for substitution failures in `CPlusPlusLanguageTest.cpp` test case `FindAlternateFunctionManglings`

[Lldb-commits] [PATCH] D54060: Remove OCaml debugger plugin

tberghammer added a comment. I have no memory about the history/background of the OCaml plugin but no objection from my side. Repository: rLLDB LLDB https://reviews.llvm.org/D54060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D54059: Remove Java debugger plugin

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. LGTM. Thank you for removing it. Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:84 Token = 19, - JavascriptData = 20, SystemMemoryInfo = 21, ---

[Lldb-commits] [PATCH] D54057: Remove Go debugger plugin

tberghammer added a reviewer: ribrdb. tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. LGTM. Adding Ryan as a reviewer as he was the original implementer but I am not sure if his account (and the linked e-mail) is still active. ht

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 172549. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/lldbsuite/test/plugins/builder_bas

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 172548. jankratochvil retitled this revision from "DWARFConcatenatingDataExtractor for D32167" to "Contiguous .debug_info+.debug_types for D32167". jankratochvil edited the summary of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D51