Author: kuba.brecka
Date: Tue Oct 30 21:43:09 2018
New Revision: 345694
URL: http://llvm.org/viewvc/llvm-project?rev=345694&view=rev
Log:
Fixup the Python-less build of ScriptedRecognizedStackFrame
Modified:
lldb/trunk/source/Commands/CommandObjectFrame.cpp
lldb/trunk/source/Target/StackF
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345693: [lldb] Introduce StackFrameRecognizer [take 3]
(authored by kuba.brecka, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44603?vs=171848&id=171860#toc
Repository:
rL LLVM
Author: kuba.brecka
Date: Tue Oct 30 21:00:22 2018
New Revision: 345693
URL: http://llvm.org/viewvc/llvm-project?rev=345693&view=rev
Log:
[lldb] Introduce StackFrameRecognizer [take 3]
This patch introduces a concept of "frame recognizer" and "recognized frame".
This should be an extensible mech
zturner added a comment.
In https://reviews.llvm.org/D52461#1280527, @aleksandr.urakov wrote:
> Update the diff according to the discussion, making it possible to parse MSVC
> demangled names by `CPlusPlusLanguage`. The old PDB plugin still uses
> `MSVCUndecoratedNameParser` directly because:
>
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
Good catch! Thank you so much.
https://reviews.llvm.org/D53917
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
Author: kuba.brecka
Date: Tue Oct 30 18:22:48 2018
New Revision: 345688
URL: http://llvm.org/viewvc/llvm-project?rev=345688&view=rev
Log:
Revert r345686 due to build failures
Removed:
lldb/trunk/include/lldb/Target/StackFrameRecognizer.h
lldb/trunk/packages/Python/lldbsuite/test/functiona
smeenai created this revision.
smeenai added a reviewer: xiaobai.
Herald added a subscriber: mgorny.
We need the install-liblldb-stripped target to also depend on the
llvm-framework target in order for the installation to be guaranteed to
behave as intended. I believe this is simply a typo.
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345686: [lldb] Introduce StackFrameRecognizer [take 2]
(authored by kuba.brecka, committed by ).
Herald added subscribers: teemperor, abidh.
Changed prior to commit:
https://reviews.llvm.org/D44603?v
Author: kuba.brecka
Date: Tue Oct 30 17:36:20 2018
New Revision: 345686
URL: http://llvm.org/viewvc/llvm-project?rev=345686&view=rev
Log:
[lldb] Introduce StackFrameRecognizer [take 2]
This patch introduces a concept of "frame recognizer" and "recognized frame".
This should be an extensible mech
Author: kuba.brecka
Date: Tue Oct 30 17:29:17 2018
New Revision: 345680
URL: http://llvm.org/viewvc/llvm-project?rev=345680&view=rev
Log:
Revert r345678 (build failure on Linux machines).
Modified:
lldb/trunk/include/lldb/API/SBVariablesOptions.h
lldb/trunk/include/lldb/Interpreter/Optio
JDevlieghere updated this revision to Diff 171845.
JDevlieghere added a comment.
Add static initializers.
https://reviews.llvm.org/D53532
Files:
include/lldb/Host/FileSystem.h
include/lldb/Utility/FileSpec.h
source/Core/Disassembler.cpp
source/Core/Module.cpp
source/Core/ModuleList.cp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345678: [lldb] Introduce StackFrameRecognizer (authored by
kuba.brecka, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44603?vs=170809&id=171
Author: kuba.brecka
Date: Tue Oct 30 17:21:03 2018
New Revision: 345678
URL: http://llvm.org/viewvc/llvm-project?rev=345678&view=rev
Log:
[lldb] Introduce StackFrameRecognizer
This patch introduces a concept of "frame recognizer" and "recognized frame".
This should be an extensible mechanism tha
Author: davide
Date: Tue Oct 30 15:49:22 2018
New Revision: 345668
URL: http://llvm.org/viewvc/llvm-project?rev=345668&view=rev
Log:
[testsuite] Skip an already failing test on MacOS.
Due to some libcxx changes to inlining, this now also crashes,
so it gets reported as "failure" by the bot. This
JDevlieghere added a comment.
In https://reviews.llvm.org/D53532#1280880, @labath wrote:
> Yes, right now it certainly seems to be the case that we parse cmdline late
> in the game. However, it's not clear to me whether that has to be the case.
>
> I can't say I have thought this through to the
labath added a comment.
In https://reviews.llvm.org/D53532#1280734, @JDevlieghere wrote:
> In https://reviews.llvm.org/D53532#1280018, @labath wrote:
>
> > In https://reviews.llvm.org/D53532#1279022, @JDevlieghere wrote:
> >
> > > Address Pavel's feedback:
> > >
> > > - Change to `Initialize` met
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345629: [NativePDB] Add support for dumping global variables
of class type. (authored by zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
Author: zturner
Date: Tue Oct 30 11:57:08 2018
New Revision: 345629
URL: http://llvm.org/viewvc/llvm-project?rev=345629&view=rev
Log:
[NativePDB] Add support for dumping global variables of class type.
Previous patches added support for dumping global variables of
primitive types, so we now do th
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for working on this!
https://reviews.llvm.org/D44603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
kubamracek added a comment.
Ping.
https://reviews.llvm.org/D44603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere added a comment.
In https://reviews.llvm.org/D53532#1280018, @labath wrote:
> In https://reviews.llvm.org/D53532#1279022, @JDevlieghere wrote:
>
> > Address Pavel's feedback:
> >
> > - Change to `Initialize` method which can only be called once.
>
>
> I suppose this is slightly bette
clayborg added a comment.
Looks fine to me. Make sure no one else has any objections.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53506
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
labath added a comment.
Ok, if that's how you guys feel, then I won't stand in your way. I am fine with
this patch then.
https://reviews.llvm.org/D52618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
grimar added a comment.
I have a patch for `DW_FORM_rnglistx`. Will be happy to land this one first
though, as they share a code in DWARFUnit.h/cpp a bit.
https://reviews.llvm.org/D53813
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
aleksandr.urakov updated this revision to Diff 171707.
aleksandr.urakov retitled this revision from "[PDB] Introduce `PDBNameParser`"
to "[PDB] Introduce `MSVCUndecoratedNameParser`".
aleksandr.urakov edited the summary of this revision.
aleksandr.urakov added a reviewer: shafik.
aleksandr.urakov
aleksandr.urakov added a comment.
Ping! Can you take a look at this, please?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53506
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Looks awesome, thank you!
https://reviews.llvm.org/D53822
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345577: [x86] Fix issues with a realigned stack in MSVC
compiled applications (authored by aleksandr.urakov, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53435
Files:
include/
Author: aleksandr.urakov
Date: Tue Oct 30 03:07:08 2018
New Revision: 345577
URL: http://llvm.org/viewvc/llvm-project?rev=345577&view=rev
Log:
[x86] Fix issues with a realigned stack in MSVC compiled applications
Summary:
This patch fixes issues with a stack realignment.
MSVC maintains two frame
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345577: [x86] Fix issues with a realigned stack in MSVC
compiled applications (authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
aleksandr.urakov updated this revision to Diff 171650.
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Update the patch according to comments.
https://reviews.llvm.org/D53435
Files:
include/lldb/Symbol/UnwindPlan.h
source/Plugins/Process/Utility/Register
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Thank you! I'll update the patch.
Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.h:195
// Get the CFA register for a given frame.
+ bool ReadFrameAddress(lldb::RegisterKin
aleksandr.urakov added a comment.
Thank you!
https://reviews.llvm.org/D53761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
In https://reviews.llvm.org/D53532#1279022, @JDevlieghere wrote:
> Address Pavel's feedback:
>
> - Change to `Initialize` method which can only be called once.
I suppose this is slightly better, but what I meant was to have a `static`
(like all other functions with the
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
35 matches
Mail list logo
