[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1278491, @malaperle wrote: > Simply checks *Simplify https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 171451. malaperle added a comment. Simply checks I think those =breakpoint-modified checks are a bit overzealous. The important check is whether of not we hit the breakpoint in a resolved location, i.e. not 0x. So, at the *stopped. The presence and

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

zturner added a comment. Is this still blocked on anything? https://reviews.llvm.org/D52618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. Here it is: build/bin/llvm-lit -avv llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test -- Testing: 1 tests, 1 threads -- FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of 1) TEST 'lldb

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. I only have these options: build/bin/llvm-lit -avv --dump-input-on-failure llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test usage: llvm-lit [-h] [--version] [-j N] [--config-prefix NAME] [-D NAME=VAL] [-q] [-s] [-v] [

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 171436. malaperle added a comment. Remove need for second -file-exec-and-symbols https://reviews.llvm.org/D52953 Files: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c tools/ll

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4 +# +# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g +# RUN: %lldbmi < %s | FileCheck %s apolyakov wrote: > malaperle wrote: > > apolyakov wrote: >

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1278331, @apolyakov wrote: > I ran the test and got a fail: Can you paste the full input of the failure? You can add "--dump-input-on-failure" arg to FileCheck in the test. The test passes for me but it might be that a regex needs

[Lldb-commits] [PATCH] D53511: [NativePDB] Support type lookup by name

labath added a comment. > For the purposes of testing I decided to bypass lldb-test and go with a > scripted lldbinit file. I'm sticking with this approach wherever possible to > prove that this is "true" cross-platform debugger functionality. However, > there are definite limitations. For exam

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. I ran the test and got a fail: build/bin/llvm-lit -avv llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test -- Testing: 1 tests, 1 threads -- FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of 1) ***