malaperle updated this revision to Diff 170301.
malaperle added a comment.
Clang-format it
https://reviews.llvm.org/D52953
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
tools/lldb-mi/MICmdCmdBreak.cpp
tools/lldb-mi/MICmdCmdGdbSet.cpp
tools/lldb-mi/MICmdCm
> On Oct 19, 2018, at 5:37 PM, Vedant Kumar wrote:
>
> Hi Stella,
>
> The logs are really helpful, thanks. This part is unexpected:
>
> python Finding frames between main and sink(), retn-pc=0x4005b8
> python GetCallEdges: Attempting to parse call site info for main
> pyth
Hi Stella,
The logs are really helpful, thanks. This part is unexpected:
python Finding frames between main and sink(), retn-pc=0x4005b8
python GetCallEdges: Attempting to parse call site info for main
python CollectCallEdges: Found call site info in main
python
JDevlieghere updated this revision to Diff 170258.
JDevlieghere added a comment.
- Back to the right diff.
- Use `-f` as per the other patch.
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
lit/Settings/TestExport.test
source/Commands/CommandObjectSettings.cp
JDevlieghere updated this revision to Diff 170257.
JDevlieghere added a comment.
Only clear setting when the force flag is set (as suggested offline by
@jingham).
https://reviews.llvm.org/D52772
Files:
lit/Settings/TestSettingsSet.test
source/Commands/CommandObjectSettings.cpp
Index: sou
JDevlieghere updated this revision to Diff 170252.
JDevlieghere added a comment.
Only clear setting when the force flag is set (as suggested offline by
@jingham).
https://reviews.llvm.org/D52651
Files:
lit/Settings/TestSettingsSet.test
source/Commands/CommandObjectSettings.cpp
Index: sou
jingham added a reviewer: apolyakov.
jingham added a comment.
This looks okay to me, there's a trivial comment nit... But Alexander has been
doing the most work on MI recently, he might want to give this a look-over.
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
JDevlieghere updated this revision to Diff 170242.
JDevlieghere retitled this revision from "[DWARFSymbolFile] Adds the module
lock to all virtual methods from SymbolFile" to "[DWARFSymbolFile] Add the
module lock where necessary and assert that we own it.".
JDevlieghere edited the summary of thi
Author: asmith
Date: Fri Oct 19 12:30:59 2018
New Revision: 344809
URL: http://llvm.org/viewvc/llvm-project?rev=344809&view=rev
Log:
[PDB] Test variadic function type in PDB
This adds back the test case reverted in commit:
d260a269200824c5c1c8c6de531fd5aa63db9c35
Modified:
lldb/trunk/unitte
asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.
Thanks for adding the cache. We noticed the slowdown also and were discussing
the same thing. This LGTM if the other reviewers done have any comments.
Repository:
rLLDB LLDB
https://review
labath added a comment.
Yes it sounds like the situation is very much similar here as it is in dwarf
land -- the compilers there also don't tend to emit unwind info for prologues
and epilogues.
The thing to realize about the instruction emulation is that it is always going
to be a best effort
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344798: [lldb] Add support in Status::AsCString to
retrieve win32 system error strings (authored by asmith, committed b
Author: asmith
Date: Fri Oct 19 11:58:24 2018
New Revision: 344798
URL: http://llvm.org/viewvc/llvm-project?rev=344798&view=rev
Log:
[lldb] Add support in Status::AsCString to retrieve win32 system error strings
Reviewers: rnk, zturner, aleksandr.urakov
Subscribers: lldb-commits
Differential Re
asmith added inline comments.
Comment at: unittests/Utility/StatusTest.cpp:68-74
+ EXPECT_STREQ("Access is denied. ", s.AsCString());
+
+ s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32);
+ EXPECT_STREQ("Negotiation timed out ", s.AsCString());
+
+ s.SetError
jingham added a reviewer: clayborg.
jingham added a comment.
This seems like the sort of thing Greg should have a look at as well.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
And tick the checkbox...
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
jingham added a comment.
Presumably you are doing this so one scripted thread plan can use another one?
This is the right way to do that, so this is great. Not sure why I didn't
think of it.
BTW, looks like I added this without any tests. Totally my bad, this was a
weekend experiment and wa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344788: [lldbsuite, windows] Disable two tail call frames
tests that fail on Windows (authored by stella.stamenova, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
Author: stella.stamenova
Date: Fri Oct 19 09:00:58 2018
New Revision: 344788
URL: http://llvm.org/viewvc/llvm-project?rev=344788&view=rev
Log:
[lldbsuite, windows] Disable two tail call frames tests that fail on Windows
Summary: These tests fail on Windows because of known limitations (a.k.a. bug
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
grimar added a comment.
Since .debug_loclists contains locations descriptions for objects
that can change location during lifetime, I do not see a way to
write the test without relying on a compiler that has support for
DWARF5. We should compile and run executable to test that location
was calcula
grimar created this revision.
grimar added reviewers: clayborg, LLDB.
Herald added subscribers: JDevlieghere, arichardson, aprantl, emaste.
Herald added a reviewer: espindola.
This implements the support for .debug_loclists section, which is
DWARF 5 version of .debug_loc.
Currently, clang is able
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: labath, zturner, jasonmolenda,
stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, abidh.
This patch fixes issues with a stack realignment.
MSVC maintains two frame pointers (`
23 matches
Mail list logo
