[Lldb-commits] [lldb] r344648 - Delete commented-out code.

Author: adrian Date: Tue Oct 16 15:01:49 2018 New Revision: 344648 URL: http://llvm.org/viewvc/llvm-project?rev=344648&view=rev Log: Delete commented-out code. Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [PATCH] D53309: Return a useful "Error" for an expression that completes but produces no result

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344647: Return a named error in the result object of an expression with no result (authored by jingham, committed by ).

[Lldb-commits] [lldb] r344647 - Return a named error in the result object of an expression with no result

Author: jingham Date: Tue Oct 16 14:58:40 2018 New Revision: 344647 URL: http://llvm.org/viewvc/llvm-project?rev=344647&view=rev Log: Return a named error in the result object of an expression with no result Before we returned an error that was not exposed in the SB API and no useful error messag

[Lldb-commits] [lldb] r344646 - Fixed an issue that a bot found with my changes

Author: jmolenda Date: Tue Oct 16 14:49:31 2018 New Revision: 344646 URL: http://llvm.org/viewvc/llvm-project?rev=344646&view=rev Log: Fixed an issue that a bot found with my changes in r344626 & recommitting. Original commit msg: Simplify LocateDSYMInVincinityOfExecutable by moving some redund

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil added a comment. In https://reviews.llvm.org/D53321#1266912, @clayborg wrote: > Looks good. Nice cleanup. Thanks for the cleanups and fixes. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] r344644 - Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

Author: jankratochvil Date: Tue Oct 16 13:49:15 2018 New Revision: 344644 URL: http://llvm.org/viewvc/llvm-project?rev=344644&view=rev Log: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children It merges DWARFDebugInfoEntry's m_empty_children into m_has_children. m_empty_children was impleme

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344644: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children (authored by jankratochvil, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53321 Files: source/Plugins/Symbol

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Nice cleanup. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil marked an inline comment as done. jankratochvil added a comment. Also changed `assert()`->`lldbassert()` for `m_abbr_idx` 16-bit overflow as that could be a tough bug to catch if it ever happens. Repository: rLLDB LLDB https://reviews.llvm.org/D53321

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil updated this revision to Diff 169873. jankratochvil added a comment. Done the conversion of bitfield to uint16_t. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFDebug

[Lldb-commits] [lldb] r344636 - Revert r344626 while I address a testsuite failure from a bot.

Author: jmolenda Date: Tue Oct 16 11:25:46 2018 New Revision: 344636 URL: http://llvm.org/viewvc/llvm-project?rev=344636&view=rev Log: Revert r344626 while I address a testsuite failure from a bot. Modified: lldb/trunk/source/Host/common/Symbols.cpp Modified: lldb/trunk/source/Host/common/S

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Once we’re no longer using DIA this should be a lot easier to control on our side On Tue, Oct 16, 2018 at 11:17 AM Vedant Kumar wrote: > > > On Oct 16, 2018, at 10:59 AM, Stella Stamenova > wrote: > > The windows error is because the names are different, as you expected: > > AssertionError: 'voi

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 16, 2018, at 10:59 AM, Stella Stamenova wrote: > > The windows error is because the names are different, as you expected: > > AssertionError: 'void sink(void)' != 'sink()' > > You can probably update the test to look for a different name on Windows > (though if I recall correctly,

[Lldb-commits] [lldb] r344635 - Tiny testsuite tweaks. Don't run the apple simulator

Author: jmolenda Date: Tue Oct 16 11:14:30 2018 New Revision: 344635 URL: http://llvm.org/viewvc/llvm-project?rev=344635&view=rev Log: Tiny testsuite tweaks. Don't run the apple simulator tests when targetting a device. Add an include to safe-to-call-func to work around a modules issue with a c

[Lldb-commits] [lldb] r344634 - Use a relaxed substring check for function names in a test

Author: vedantk Date: Tue Oct 16 11:13:42 2018 New Revision: 344634 URL: http://llvm.org/viewvc/llvm-project?rev=344634&view=rev Log: Use a relaxed substring check for function names in a test The TestTailCallFrameSBAPI.py test checks that function names in a backtrace are equal to an expected va

[Lldb-commits] [lldb] r344633 - Don't run TestBreakpointIt.py on arm64 devices;

Author: jmolenda Date: Tue Oct 16 11:11:17 2018 New Revision: 344633 URL: http://llvm.org/viewvc/llvm-project?rev=344633&view=rev Log: Don't run TestBreakpointIt.py on arm64 devices; it is armv7 specific. Modified: lldb/trunk/packages/Python/lldbsuite/test/arm/breakpoint-it/TestBreakpointIt.

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

The windows error is because the names are different, as you expected: AssertionError: 'void sink(void)' != 'sink()' You can probably update the test to look for a different name on Windows (though if I recall correctly, different versions of the DIA sdk provide different detail on the names, s

Re: [Lldb-commits] [lldb] r344628 - For a built & test bot, add an environment variable PLATFORM_SDK_DIRECTORY,

Would it be possible to use a setting instead of an environment variable? We could make some settings initialize or append addition values from an environment variables by building that logic into the code? > On Oct 16, 2018, at 10:31 AM, Jason Molenda via lldb-commits > wrote: > > Author: j

[Lldb-commits] [lldb] r344628 - For a built & test bot, add an environment variable PLATFORM_SDK_DIRECTORY,

Author: jmolenda Date: Tue Oct 16 10:31:33 2018 New Revision: 344628 URL: http://llvm.org/viewvc/llvm-project?rev=344628&view=rev Log: For a built & test bot, add an environment variable PLATFORM_SDK_DIRECTORY, which PlatformRemoteDarwinDevice::UpdateSDKDirectoryInfosIfNeeded which examine for any

[Lldb-commits] [PATCH] D53305: Simplify LocateDSYMInVincinityOfExecutable a bit, and call Symbols::DownloadObjectAndSymbolFile for .dSYM.yaa archives

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344626: Simplify LocateDSYMInVincinityOfExecutable by moving (authored by jmolenda, committed by ). Repository: rLLD

[Lldb-commits] [lldb] r344626 - Simplify LocateDSYMInVincinityOfExecutable by moving

Author: jmolenda Date: Tue Oct 16 10:26:04 2018 New Revision: 344626 URL: http://llvm.org/viewvc/llvm-project?rev=344626&view=rev Log: Simplify LocateDSYMInVincinityOfExecutable by moving some redundant code into a separate function, LookForDsymNextToExecutablePath, and having that function also

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

clayborg added a comment. See inlined comment. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:287 + m_has_children : 1; uint32_t m_abbr_idx : DIE_ABBR_IDX_BITSIZE, m_tag : 16; // A copy of the DW_TAG value so we don't

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil updated this revision to Diff 169850. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h source/Plugins/S

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:285-287 +// It is zero if a DIE says it had +

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344623: [lldbsuite] Fix the mac version decorator to work on non-mac platforms (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53208 Files: package

[Lldb-commits] [lldb] r344623 - [lldbsuite] Fix the mac version decorator to work on non-mac platforms

Author: stella.stamenova Date: Tue Oct 16 10:13:45 2018 New Revision: 344623 URL: http://llvm.org/viewvc/llvm-project?rev=344623&view=rev Log: [lldbsuite] Fix the mac version decorator to work on non-mac platforms Summary: On non-mac platforms, mac_ver returns an empty string which when converte

[Lldb-commits] [PATCH] D53331: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, zturner. Herald added subscribers: lldb-commits, abidh. They fail similarly to some of the other breakpoint tests on Windows, so I suspect the cause is the same. I've linked to the same bug. Repository: rLLDB LL

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov added a comment. Yes, it's simpler to move it to the `CPlusPlusLanguage::MethodName` (or `CPlusPlusNameParser`?) I think. The only question left is how to differentiate MSVC demangled names from others? May be it would be ok to treat name as an MSVC name if it contains a grave

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

labath added a comment. In https://reviews.llvm.org/D52461#1266302, @aleksandr.urakov wrote: > `operator<'::`2'::B::operator> > The reason we had to use clang lexer for parsing itanium names is because parsing itanium demangled names is tricky precisely for cases like these. If the MSVC dem

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

clayborg added a comment. m_has_children was used to represent what was in the DWARF in the byte that follows the DW_TAG. m_empty_children was used for DIEs that said they had children but actually only contain a single NULL tag. It is fine to not differentiate between the two. =

[Lldb-commits] [PATCH] D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

jankratochvil added a comment. In https://reviews.llvm.org/D53255#1265520, @aprantl wrote: > Out of curiosity: why do we allow for both an empty array and an empty > children sentinel? Is that distinction useful? Filed for that new https://reviews.llvm.org/D53321. Repository: rL LLVM http

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil created this revision. jankratochvil added reviewers: aprantl, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. As @aprantl suggested I have merged `DWARFDebugInfoEntry`'s `m_empty_children` into `m_has

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

This revision was automatically updated to reflect the committed changes. Closed by commit rL344605: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front())… (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [lldb] r344605 - Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

Author: jankratochvil Date: Tue Oct 16 04:38:22 2018 New Revision: 344605 URL: http://llvm.org/viewvc/llvm-project?rev=344605&view=rev Log: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked xbolva00 bugreported $subj in: https://reviews.llv

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov added a comment. Yes, I mean exactly the same case. For sequences like you've written yes, the unwind should work, but there must be some problems with saved registers. `x86AssemblyInspectionEngine` doesn't handle instructions like `and %-8, %esp`, so the register save would wo

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov added a comment. In https://reviews.llvm.org/D52461#1265633, @zturner wrote: > Just handle the `anonymous namespace' thing specially before passing to > `CPlusPlusNameParser`. Yes, it's an interesting idea to somehow preprocess an MSVC demangled name and make a GCC demangled

[Lldb-commits] [PATCH] D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

grimar added a comment. In https://reviews.llvm.org/D53193#1266080, @JDevlieghere wrote: > The code and test look correct, so this LGTM but I'll leave it open for now > in case someone else wants to have a look too. Thanks for looking, Jonas! https://reviews.llvm.org/D53193 __