Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 4:46 PM, Frédéric Riss wrote: > > > >> On Oct 15, 2018, at 4:40 PM, Vedant Kumar > > wrote: >> >> >> >>> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator >>> mailto:revi...@reviews.llvm.org>> wrote: >>> >>> stella.stamenova added

[Lldb-commits] [lldb] r344581 - Use assertEqual to improve test failure logging

Author: vedantk Date: Mon Oct 15 20:31:33 2018 New Revision: 344581 URL: http://llvm.org/viewvc/llvm-project?rev=344581&view=rev Log: Use assertEqual to improve test failure logging Some tests in test/functionalities/tail_call_frames are failing on non-Darwin platforms. Use assertEqual to improve

[Lldb-commits] [PATCH] D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

JDevlieghere added a comment. The code and test look correct, so this LGTM but I'll leave it open for now in case someone else wants to have a look too. https://reviews.llvm.org/D53193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D53309: Return a useful "Error" for an expression that completes but produces no result

jingham created this revision. Herald added subscribers: lldb-commits, abidh, JDevlieghere. When you run an expression like: (lldb) expr int $x = 10 the expression has no result. The ValueObject (and then SBValue) you get back from the expression signals that by putting an error indicating thi

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That seems more convenient to me, it makes the mac version only relevant if you are on a mac. Repository: rLLDB LLDB https://reviews.llvm.org/D53208 __

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

jingham added a comment. I wouldn't be surprised if Jonas isn't familiar enough with the Windows port to answer the question. But if you have a running lldb you can tell easily. Just do: lldb SomeBinaryThatLoadsSharedLibraries (lldb) image list Do you get only SomeBinaryThatLoadsSharedLibrar

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 4:40 PM, Vedant Kumar wrote: > > > >> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator >> wrote: >> >> stella.stamenova added a comment. >> >> In https://reviews.llvm.org/D50478#1262717, @vsk wrote: >> >>> In https://reviews.llvm.org/D50478#1262710, @st

[Lldb-commits] [PATCH] D53305: Simplify LocateDSYMInVincinityOfExecutable a bit, and call Symbols::DownloadObjectAndSymbolFile for .dSYM.yaa archives

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: abidh. Host/common/Symbols.cpp has a method LocateDSYMInVincinityOfExecutable which looks for a dSYM next to a binary ("foo" + "foo.dSYM") and it looks for a

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > In https://reviews.llvm.org/D50478#1262717, @vsk wrote: > >> In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote: >> >>> Unfortunately, the bots are broken beca

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

stella.stamenova added a comment. In https://reviews.llvm.org/D50478#1262717, @vsk wrote: > In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote: > > > Unfortunately, the bots are broken because of the FileCheck issue, so I > > can't confirm with them, but I see a number of these

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

stella.stamenova added a comment. Thanks. I guess the more explicit question is: which platforms is this feature (and test) applicable to? The test should be disabled on other platforms. It is already disabled on Linux because it is not applicable and it is failing to even build on Windows in i

[Lldb-commits] [lldb] r344557 - Convert code to use early exits in prepraration for future changes. (NFC)

Author: adrian Date: Mon Oct 15 14:35:45 2018 New Revision: 344557 URL: http://llvm.org/viewvc/llvm-project?rev=344557&view=rev Log: Convert code to use early exits in prepraration for future changes. (NFC) Modified: lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILa

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

stella.stamenova added a comment. In https://reviews.llvm.org/D53208#1264056, @jingham wrote: > We do compose the decorators in a bunch of places (like Shafik's usage here). > That will work more naturally if the categories that the decorators assert > are as decoupled as possible. So the sta

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344547: [lldbsuite] Make the names of test classes unique (authored by stella.stamenova, committed by ). Repository:

[Lldb-commits] [lldb] r344547 - [lldbsuite] Make the names of test classes unique

Author: stella.stamenova Date: Mon Oct 15 12:51:21 2018 New Revision: 344547 URL: http://llvm.org/viewvc/llvm-project?rev=344547&view=rev Log: [lldbsuite] Make the names of test classes unique Summary: If the names are not unique, the tests overwrite each other's results and logs. This also caus

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

clayborg added a comment. It would be great if we can detect this when all of the test files are loaded and emit an error instead of waiting for results to be overwritten Repository: rLLDB LLDB https://reviews.llvm.org/D53297 ___ lldb-commits ma

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

labath added a comment. In https://reviews.llvm.org/D53086#1261704, @aleksandr.urakov wrote: > As for aligned stack cross-platform problems, I mean also problems with stack > unwinding. They seem to appear on non-Windows too. It's because > `x86AssemblyInspectionEngine` doesn't support stack al

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

stella.stamenova created this revision. stella.stamenova added reviewers: jasonmolenda, asmith. Herald added subscribers: lldb-commits, kbarton, nemanjai. If the names are not unique, the tests overwrite each other's results and logs. This also causes failures on platforms where the files are loc

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344543: [lldbsuite] Disable Test128BitsInteger on Windows (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53226 Files: packages/Python/lldbsuite/t

[Lldb-commits] [lldb] r344543 - [lldbsuite] Disable Test128BitsInteger on Windows

Author: stella.stamenova Date: Mon Oct 15 11:51:28 2018 New Revision: 344543 URL: http://llvm.org/viewvc/llvm-project?rev=344543&view=rev Log: [lldbsuite] Disable Test128BitsInteger on Windows Summary: This test is failing on Windows because lldb does not support JIT on Windows. Reviewers: davi

[Lldb-commits] [PATCH] D53090: [Windows] Fix a bug that causes lldb to freeze

labath added a comment. Do we have a test for this? It sounds like it shouldn't be hard to replicate the dependent library load failure in a test... Repository: rLLDB LLDB https://reviews.llvm.org/D53090 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

zturner added a comment. In https://reviews.llvm.org/D52461#1265335, @aleksandr.urakov wrote: > Hello! > > I just have tried to patch `CPlusPlusNameParser` in the way to support MSVC > demangled names, but there is a problem. `CPlusPlusNameParser` splits an > incoming name in tokens with `clang

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

aprantl added a comment. Out of curiosity: why do we allow for both an empty array and an empty children sentinel? Is that distinction useful? Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov added a subscriber: labath. aleksandr.urakov added a comment. Hello! I just have tried to patch `CPlusPlusNameParser` in the way to support MSVC demangled names, but there is a problem. `CPlusPlusNameParser` splits an incoming name in tokens with `clang::Lexer`. I've lexed the

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. assert fix looks fine Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt