[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

zturner added a comment. In https://reviews.llvm.org/D53086#1263001, @zturner wrote: > In https://reviews.llvm.org/D53086#1261697, @aleksandr.urakov wrote: > > > Thanks a lot for so detailed answer, it helps! > > > > So we need to parse a FPO program and to convert it in a DWARF expression > > t

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

zturner added a comment. In https://reviews.llvm.org/D53086#1261697, @aleksandr.urakov wrote: > Thanks a lot for so detailed answer, it helps! > > So we need to parse a FPO program and to convert it in a DWARF expression > too. The problem here (in the DIA case) is that I don't know how to retri

[Lldb-commits] [lldb] r344323 - Remove references to source/Plugins/SymbolFile/NativePDB.

Author: jmolenda Date: Thu Oct 11 17:53:55 2018 New Revision: 344323 URL: http://llvm.org/viewvc/llvm-project?rev=344323&view=rev Log: Remove references to source/Plugins/SymbolFile/NativePDB. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbx

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Can we get the Xcode build to generate lldb-dotest, just like the cmake build does? That way there's no need to duplicate build system logic into dotest.py. It would just live in one place, and we'd all invoke lldb-dotest the same way. vedant > On Oct 11, 2018, at 3:53 PM, Jason Molenda via Pha

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Does this look reasonable to you? I'm not sure how to test this. diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py index 5a1b2e87..62152924 100644 --- a/zorg/buildbot/builders/LLDBBuilder.py +++ b/zorg/buildbot/builders/LLDBBuilder.py @@ -270,6 +270,7 @@ d

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

jasonmolenda added a comment. I've been meaning to look at this - for the command line style "cd test; ./dotest.py" approach, we could use similar logic to what packages/Python/lldbsuite/test/dotest.py does in getOutputPaths() where it finds an lldb binary in the "typical" location. for an Xco

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

jasonmolenda added a comment. (obviously this would only be the behavior if a filecheck path was not specified) https://reviews.llvm.org/D53175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova added a comment. The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode. I think the file that needs to be updated is: zorg\buildbot\builders\LLDBBuilder.py https://reviews.llvm.org/D53175 _

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

> On Oct 11, 2018, at 3:30 PM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > I spent a bit more time on this and I think I have a better idea of what's > happening. > > Vedant added functionality so that we can use FileCheck-style checks inside > non-l

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

It's probably not, it's just that the --filecheck arg is missing. I wrote things this way because I was advised that dotest.py shouldn't assume where FileCheck is on the filesystem. vedant > On Oct 11, 2018, at 3:22 PM, Zachary Turner wrote: > > Why is FileCheck missing in the first place? >

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova added a comment. I spent a bit more time on this and I think I have a better idea of what's happening. Vedant added functionality so that we can use FileCheck-style checks inside non-lit LLDB tests. Part of that change was to require a parameter --filecheck to be passed when c

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

zturner added a subscriber: vsk. zturner added a comment. Why is FileCheck missing in the first place? https://reviews.llvm.org/D53175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Why is FileCheck missing in the first place? On Thu, Oct 11, 2018 at 3:13 PM Vedant Kumar via Phabricator < revi...@reviews.llvm.org> wrote: > vsk created this revision. > vsk added reviewers: stella.stamenova, zturner. > > This allows bots which haven't updated to pass in --filecheck to dotest.py

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

vsk created this revision. vsk added reviewers: stella.stamenova, zturner. This allows bots which haven't updated to pass in --filecheck to dotest.py to run more tests. FileCheck-dependent tests will continue to fail. https://reviews.llvm.org/D53175 Files: lldb/packages/Python/lldbsuite/test

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

zturner added a subscriber: aprantl. zturner added a comment. https://reviews.llvm.org/D53002 Is the thread I'm referring to. Repository: rLLDB LLDB https://reviews.llvm.org/D50478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

https://reviews.llvm.org/D53002 Is the thread I'm referring to. On Thu, Oct 11, 2018 at 2:59 PM Zachary Turner via Phabricator < revi...@reviews.llvm.org> wrote: > zturner added a subscriber: vsk. > zturner added a comment. > > See the other email thread. The bots have been broken since Septemb

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

See the other email thread. The bots have been broken since September, all of them complain about missing FileCheck executable On Thu, Oct 11, 2018 at 2:58 PM Vedant Kumar via Phabricator < revi...@reviews.llvm.org> wrote: > vsk added a comment. > > In https://reviews.llvm.org/D50478#1262710, @s

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

zturner added a subscriber: vsk. zturner added a comment. See the other email thread. The bots have been broken since September, all of them complain about missing FileCheck executable Repository: rLLDB LLDB https://reviews.llvm.org/D50478 ___ l

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk added a comment. In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote: > Unfortunately, the bots are broken because of the FileCheck issue, so I can't > confirm with them, but I see a number of these tests fail in our local > testing. Some fail on both Windows and Linux and s

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

stella.stamenova added a comment. Unfortunately, the bots are broken because of the FileCheck issue, so I can't confirm with them, but I see a number of these tests fail in our local testing. Some fail on both Windows and Linux and some just fail on Linux. Here are the failing tests: Linux:

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

zturner added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:2230-2233 +# In Python 2, communicate sends byte strings. In Python 3, communicate sends bytes. +# If we got a string (and not a byte string), encode it before sending. +

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

stella.stamenova created this revision. stella.stamenova added reviewers: zturner, asmith. Herald added a subscriber: lldb-commits. This is another string/byte conversion issue between Python 2 and 3. In Python 2, the subprocess communication expects a byte string, but in Python 3, it expects by

Re: [Lldb-commits] [lldb] r344279 - Revert SymbolFileNativePDB plugin.

thanks. On Thu, Oct 11, 2018 at 11:47 AM Zachary Turner via lldb-commits wrote: > > Author: zturner > Date: Thu Oct 11 11:45:44 2018 > New Revision: 344279 > > URL: http://llvm.org/viewvc/llvm-project?rev=344279&view=rev > Log: > Revert SymbolFileNativePDB plugin. > > This was originally causing s

[Lldb-commits] [lldb] r344279 - Revert SymbolFileNativePDB plugin.

Author: zturner Date: Thu Oct 11 11:45:44 2018 New Revision: 344279 URL: http://llvm.org/viewvc/llvm-project?rev=344279&view=rev Log: Revert SymbolFileNativePDB plugin. This was originally causing some test failures on non-Windows platforms, which required fixes in the compiler and linker. After

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

davide accepted this revision. davide added a comment. LGTM too. Thanks for taking the time to address the comments. https://reviews.llvm.org/D52851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] r344277 - Fix this comment so it is consistent with all the others.

Author: jmolenda Date: Thu Oct 11 11:41:34 2018 New Revision: 344277 URL: http://llvm.org/viewvc/llvm-project?rev=344277&view=rev Log: Fix this comment so it is consistent with all the others. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.cpp Modified: lldb/

[Lldb-commits] [lldb] r344275 - Don't mark an LC_BUILD_VERSION as giving us a

Author: jmolenda Date: Thu Oct 11 11:37:53 2018 New Revision: 344275 URL: http://llvm.org/viewvc/llvm-project?rev=344275&view=rev Log: Don't mark an LC_BUILD_VERSION as giving us a correct version if it has a major verison 0. Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMa

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks great, thanks for making this work, it will be SO helpful for debugging std::function uses. https://reviews.llvm.org/D52851 ___ lld

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

shafik added a comment. @jingham removed code and made it NO_DEBUG_INFO_TESTCASE https://reviews.llvm.org/D52851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

shafik updated this revision to Diff 169259. shafik marked an inline comment as done. shafik added a comment. Removing uneeded code and making test NO_DEBUG_INFO_TESTCASE https://reviews.llvm.org/D52851 Files: include/lldb/Target/CPPLanguageRuntime.h packages/Python/lldbsuite/test/lang/cpp

[Lldb-commits] [lldb] r344269 - Better support for POSIX paths in PDBs.

Author: zturner Date: Thu Oct 11 11:01:55 2018 New Revision: 344269 URL: http://llvm.org/viewvc/llvm-project?rev=344269&view=rev Log: Better support for POSIX paths in PDBs. While it doesn't make a *ton* of sense for POSIX paths to be in PDBs, it's possible to occur in real scenarios involving cr

Re: [Lldb-commits] [lldb] r344154 - Create a SymbolFile plugin for cross-platform PDB access.

Great, thanks for the update. I'll wait then. There's also an assertion failure in DebugInfo/MSF, which was, incidentally, caused by another test we added yesterday. I think it might be related (be in your area). Thanks, -- Davide On Thu, Oct 11, 2018 at 9:47 AM Zachary Turner wrote: > > I'm wor

Re: [Lldb-commits] [lldb] r344154 - Create a SymbolFile plugin for cross-platform PDB access.

I'm working on a fix for this and several other issues right now. For this one I think we just need to add -- on the command line. On Thu, Oct 11, 2018 at 9:36 AM Davide Italiano wrote: > On Wed, Oct 10, 2018 at 9:40 AM Zachary Turner via lldb-commits > wrote: > > > > Author: zturner > > Date:

Re: [Lldb-commits] [lldb] r344154 - Create a SymbolFile plugin for cross-platform PDB access.

On Wed, Oct 10, 2018 at 9:40 AM Zachary Turner via lldb-commits wrote: > > Author: zturner > Date: Wed Oct 10 09:39:07 2018 > New Revision: 344154 > > URL: http://llvm.org/viewvc/llvm-project?rev=344154&view=rev > Log: > Create a SymbolFile plugin for cross-platform PDB access. > Hey Zach, I'm af

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

clayborg added a comment. See inlined comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:150-151 +case DW_RLE_base_address: { + dw_addr_t base = data.GetMaxU64(offset_ptr, addrSize); + rangeList.push_back({DW_RLE_base_address, base, 0}); +

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for making the changes. Looks good! https://reviews.llvm.org/D52689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added a subscriber: JDevlieghere. The patch implements the support for DW_RLE_base_address and DW_RLE_offset_pair .debug_rnglists entries https://reviews.llvm.org/D53140 Files: lit/Breakpoint/Inputs/debug_rnglist_of

[Lldb-commits] [lldb] r344252 - [lldb] Surpress copy-elison warning.

Author: ioeric Date: Thu Oct 11 07:52:33 2018 New Revision: 344252 URL: http://llvm.org/viewvc/llvm-project?rev=344252&view=rev Log: [lldb] Surpress copy-elison warning. Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Modified: lldb/trunk/source/Plugins/Symbo

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar updated this revision to Diff 169209. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52689 Files: lit/Breakpoint/Inputs/implicit_const_form_support.yaml lit/Breakpoint/implicit_const_form_support.test source/Plugins/SymbolFile/DWARF/DWARFAbbreviation

[Lldb-commits] [lldb] r344250 - [lldb] rename MinOS::minor to MinOS::minor_version etc. NFC

Author: ioeric Date: Thu Oct 11 07:44:12 2018 New Revision: 344250 URL: http://llvm.org/viewvc/llvm-project?rev=344250&view=rev Log: [lldb] rename MinOS::minor to MinOS::minor_version etc. NFC The constructor initializer minor(...)/major(...) can be confused with system macros `#define minor(...)

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

clayborg added a comment. Down to just modifying the DWARFFormValue constructor to be able to take a CU only. Looks good. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:241-242 +for (uint32_t i = 0; i < numAttributes; ++i) { + DWARFFormVal

[Lldb-commits] [PATCH] D53096: [lldb-test] Add a lit test for dependent modules in PECOFF

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM after https://reviews.llvm.org/D53094 will be done! Repository: rLLDB LLDB https://reviews.llvm.org/D53096 ___ lldb-c

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

aleksandr.urakov added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:801-804 + if (m_filespec_ap.get()) +return m_filespec_ap->GetSize(); + + m_filespec_ap.reset(new FileSpecList()); I'm afraid of a race condition here.

[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

aleksandr.urakov added a comment. Otherwise LGTM! Comment at: unittests/Utility/StatusTest.cpp:68-74 + EXPECT_STREQ("Access is denied. ", s.AsCString()); + + s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32); + EXPECT_STREQ("Negotiation timed out ", s.AsCStri

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov added subscribers: zturner, jasonmolenda, labath. aleksandr.urakov added a comment. As for aligned stack cross-platform problems, I mean also problems with stack unwinding. They seem to appear on non-Windows too. It's because `x86AssemblyInspectionEngine` doesn't support stack a

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov updated this revision to Diff 169181. https://reviews.llvm.org/D53086 Files: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script Index: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script =

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov added a comment. Thanks a lot for so detailed answer, it helps! So we need to parse a FPO program and to convert it in a DWARF expression too. The problem here (in the DIA case) is that I don't know how to retrieve the required FPO range (we have a symbol context when creating

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:23 + DWARFAttribute(dw_attr_t attr, dw_form_t form, + DWARFFormValue::ValueType value) + : m_attr(attr), m_form(form), m_value(value) {} clayborg wrot

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar updated this revision to Diff 169177. grimar marked 4 inline comments as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52689 Files: lit/Breakpoint/Inputs/implicit_const_form_support.yaml lit/Breakpoint/implicit_const_form_support.test source/P