On Wed, Oct 10, 2018 at 6:38 PM Hui Huang via Phabricator <
revi...@reviews.llvm.org> wrote:
> Hui added inline comments.
>
>
>
> Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:810
> +
> + std::lock_guard guard(module_sp->GetMutex());
> +
>
> z
Hui added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:810
+
+ std::lock_guard guard(module_sp->GetMutex());
+
zturner wrote:
> Does this actually need to be a `recursive_mutex`?
I think there is access to the member 'm_file
Author: jmolenda
Date: Wed Oct 10 17:28:35 2018
New Revision: 344209
URL: http://llvm.org/viewvc/llvm-project?rev=344209&view=rev
Log:
Upstreaming the BridgeOS device support and the
LC_BUILD_VERSION load command handling - this
commit is a combination of patches by Adrian
Prantl and myself. llv
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Couple more lines you can delete from the test case, and I think you should
make this a debug-variant insensitive test. Do that and this is good.
Comment at:
p
jingham added a comment.
IIRC, the test is disabled on Linux not because of problems with building the
test executables, but because the Linux port doesn't currently load the
dependencies of an binary when it loads the binary. So the test was irrelevant
on Linux, as was the feature.
Reposito
stella.stamenova added a comment.
This test has been failing on Windows since it was added as it doesn't build
correctly. I noticed some of the tests are also disabled on Linux. Is this
supposed to pass on all platforms?
Error when building test subject.
Build Command:
make
VPATH=E:\_wor
shafik added a comment.
@jingham I believe I addressed your comments, please review again.
https://reviews.llvm.org/D52851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
shafik updated this revision to Diff 169105.
shafik marked 5 inline comments as done.
shafik added a comment.
- Addressing comments
- Adding test to make sure we step through a std::function wrapping a member
variable
https://reviews.llvm.org/D52851
Files:
include/lldb/Target/CPPLanguageRunt
xbolva00 added a comment.
In https://reviews.llvm.org/D53010#1260956, @aprantl wrote:
> Currently `v` is an alias for `version`. I'd wager that — compared to
> printing a variable — LLDB user's almost never want to print LLDB's version.
> Would it make sense to re-purpose the single-letter `v`
aprantl added a comment.
Currently `v` is an alias for `version`. I'd wager that — compared to printing
a variable — LLDB user's almost never want to print LLDB's version. Would it
make sense to re-purpose the single-letter `v` abbreviation for the much more
frequently used `frame variable` act
Author: zturner
Date: Wed Oct 10 11:52:37 2018
New Revision: 344173
URL: http://llvm.org/viewvc/llvm-project?rev=344173&view=rev
Log:
[SymbolFileNativePDB] Fix compilation errors with gcc.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
lldb/trunk/source/Plugins/Symb
Author: asmith
Date: Wed Oct 10 11:30:32 2018
New Revision: 344168
URL: http://llvm.org/viewvc/llvm-project?rev=344168&view=rev
Log:
[Windows] Fix a bug that causes lldb to freeze
Summary:
If the process exits before any initial stop then notify the debugger
of the error otherwise WaitForDebugge
zturner added a comment.
If you plan to invest in more substantial changes in `ObjectFilePECOFF`, it
might worth considering a complete re-write in terms of `llvm::object::coff`.
It has pretty comprehensive support for the PE/COFF spec, so it's just a matter
of implementing `ObjectFilePECOFF`
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Nice find, thanks
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
zturner added a comment.
You didn't include it here, but I notice the test file just writes `clang-cl
/Zi`. Should we be passing `-m32` or `-m64`? Currently, the test just runs
with whatever architecture happens to be set via the VS command prompt. The
behavior here is different on x86 and x
zturner added a comment.
> By the way, what do you think, how can we make LLDB support aligned stacks?
> As far as I know, similar alignment problems are reproducible on non-Windows
> too.
When you see VFRAME, you need to look in FPO data. As you might have guessed,
VFRAME only occurs in X86.
asmith created this revision.
asmith added reviewers: rnk, zturner, aleksandr.urakov.
Herald added a subscriber: lldb-commits.
Add a new subcommand to lldb-test called 'dep-modules' to test
dependent modules in PECOFF.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53096
Files:
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
Could you document that in the test?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53086
___
lldb-commits mailing list
asmith created this revision.
asmith added reviewers: rnk, zturner, aleksandr.urakov, lldb-commits.
Herald added subscribers: teemperor, mgrang, mgorny.
This parses entries in pecoff import tables for imported DLLs and
is intended as the first step to allow LLDB to load a PE's shared
modules when
asmith created this revision.
asmith added reviewers: rnk, zturner, aleksandr.urakov.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53092
Files:
source/Utility/Status.cpp
unittests/Utility/StatusTest.cpp
Index: unittests/Utility/StatusTest.cpp
asmith created this revision.
asmith added reviewers: rnk, zturner, aleksandr.urakov.
Herald added a subscriber: lldb-commits.
If the process exits before any initial stop then notify the debugger
of the error otherwise WaitForDebuggerConnection() will be blocked.
An example of this issue is when
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few things inlined. Very close. DumpAttribute will need to take a
DWARFFormValue in order to dump the value correctly.
Comment at: source/Plugins/SymbolFile/
Author: zturner
Date: Wed Oct 10 09:39:07 2018
New Revision: 344154
URL: http://llvm.org/viewvc/llvm-project?rev=344154&view=rev
Log:
Create a SymbolFile plugin for cross-platform PDB access.
The existing SymbolFilePDB only works on Windows, as it is written
against a closed-source Microsoft SDK
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, rnk, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, abidh, JDevlieghere, aprantl.
This patch fixes the flaky test `variables-locations.test`. The test began
flakin
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:51
+ uint32_t idx, dw_attr_t &attr, dw_form_t &form,
+ DWARFFormValue::ValueType *val = nullptr) const {
+m_attributes[idx].get(attr, form, val);
---
grimar updated this revision to Diff 169005.
grimar marked 12 inline comments as done.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52689
Files:
lit/Breakpoint/Inputs/implicit_const_form_support.yaml
lit/Breakpoint/implicit_const_form_support.test
source/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344119: [LLDB] - Add basic support for .debug_rnglists
section (DWARF5) (authored by grimar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5
27 matches
Mail list logo
