This revision was automatically updated to reflect the committed changes.
Closed by commit rL344102: Add "var" and "vo" aliases for
"frame variable" and "frame variable -O". (authored by
jingham, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: jingham
Date: Tue Oct 9 17:51:30 2018
New Revision: 344102
URL: http://llvm.org/viewvc/llvm-project?rev=344102&view=rev
Log:
Add "var" and "vo" aliases for "frame variable" and "frame variable -O".
Differential Revision: https://reviews.llvm.org/D53010
Modified:
lldb/trunk/source/Co
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:51
+ uint32_t idx, dw_attr_t &attr, dw_form_t &form,
+
grimar added a comment.
In https://reviews.llvm.org/D52981#1257888, @clayborg wrote:
> For space savings it seems like we would want to support the
> DW_RLE_base_address and DW_RLE_offset_pair pretty soon.
I am working on a follow-up patch to support those.
https://reviews.llvm.org/D52981
grimar added a comment.
Ping.
https://reviews.llvm.org/D52689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:134-144
+uint8_t encoding = data.GetU8(offset_ptr);
+
+if (encoding == DW_RLE_end_of_list)
+ return true;
+
+if (encoding == DW_RLE_start_length) {
+ dw_addr_t beg
grimar updated this revision to Diff 168759.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52981
Files:
include/lldb/lldb-enumerations.h
lit/Breakpoint/Inputs/debug_rnglist_basic.yaml
lit/Breakpoint/debug_rnglist_basic.test
source/Core/Section.cpp
sour
