[Lldb-commits] [PATCH] D53010: Add an alias "var" for "frame var" and "vo" for "frame var -O"

2018-10-08 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LG. If you can add a line to an existing inline test, I think it would be excellent. Repository: rLLDB LLDB https://reviews.llvm.org/D53010 _

[Lldb-commits] [PATCH] D53010: Add an alias "var" for "frame var" and "vo" for "frame var -O"

2018-10-08 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. Herald added subscribers: lldb-commits, abidh. "expression" is a hugely inefficient way to get the value of a local variable. There are a few cases where "frame variable" and "expression" will produce different results on the same expression (e.g. "foo->bar" when

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

2018-10-08 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Just a couple of trivial requests, mostly about comments... Comment at: packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py:27-28 + +@add_test_categories(["libc++"]) +def test(self): +

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

2018-10-08 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. For space savings it seems like we would want to support the DW_RLE_base_address and DW_RLE_offset_pair pretty soon. https://reviews.llvm.org/D52981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

2018-10-08 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just add a switch statement when handling the encodings and a lldbassert as mentioned in inlined comments and this will be good to go. Comment at: source/Plugi

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

2018-10-08 Thread George Rimar via Phabricator via lldb-commits
grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, arichardson, emaste. Herald added a reviewer: espindola. This adds a basic support of the .debug_rnglists section. Only the DW_RLE_start_length and DW_RLE_end_of_list entries are supported

[Lldb-commits] [PATCH] D52941: NativeProcessProtocol: Simplify breakpoint setting code

2018-10-08 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. The NetBSD part looks fine. I will be out of the office soon as I will visit California for GSoC Mentor Summit and MeetBSDCa (until October 23rd). https://reviews.llvm.org/D52941