vsk updated this revision to Diff 166394.
vsk added a comment.
Teach SBThread::StepOut and SBThread::ReturnFromFrame to behave as-if
artificial frames were not present.
This preserves the current behavior of "finish" and "thread return". The
alternatives -- stepping out into an artificial frame
vsk planned changes to this revision.
vsk added a comment.
In https://reviews.llvm.org/D50478#1241264, @jingham wrote:
> Can you add a test that makes sure that when you stop in a frame that has
> artificial frames above it, and then you do "finish", or "step out" past the
> end of frame 0, the
Author: vedantk
Date: Thu Sep 20 16:56:39 2018
New Revision: 342699
URL: http://llvm.org/viewvc/llvm-project?rev=342699&view=rev
Log:
[lldbtest] Fix self.filecheck check file lookup
The 'test_filename' property in TestBase changes over time, so
attempting to find a check file relative to the dire
jingham added a comment.
Really "step out past the end of the frame" isn't really necessary, since that
doesn't pay any attention to the frames above it, it just runs the code till
the frame ID changes. But "finish" does look at the parent frame, so it might
get confused.
https://reviews.llv
compnerd added a comment.
It definitely shouldn't be `PUBLIC`, `PRIVATE` makes sense for this inclusion.
Is there a library that pulls in the dependency (that is, do the other
libraries need it due to `lldbHost`? If so, just adding it as `INTERFACE` on
that library should be sufficient).
Re
jingham added a comment.
Can you add a test that makes sure that when you stop in a frame that has
artificial frames above it, and then you do "finish", or "step out" past the
end of frame 0, the presence of the artificial frame doesn't confuse us? I am
pretty sure that will just work, but it
vsk updated this revision to Diff 166378.
vsk added a comment.
I've added SB API support (SBFrame::IsArtificial), a SB API test, fleshed out
the remaining tests, and rebased. PTAL, thanks!
https://reviews.llvm.org/D50478
Files:
lldb/include/lldb/API/SBFrame.h
lldb/include/lldb/Core/FormatE
lemo added a comment.
Hi Greg, looking at request_evaluate() I noticed that it will evaluate the
string as a lldb command if prefixed by ` .
This is a great feature (it allows building REPL consoles on top of DAP),
but I'm curious how you picked up this convention? For example I believe
that the
Hi Greg, looking at request_evaluate() I noticed that it will evaluate the
string as a lldb command if prefixed by ` .
This is a great feature (it allows building REPL consoles on top of DAP),
but I'm curious how you picked up this convention? For example I believe
that the gdb DAP uses -exec 'com
apolyakov added a comment.
In https://reviews.llvm.org/D52139#1240835, @apolyakov wrote:
> Can you provide some logs? For example, you might be able to run this test
> (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and
> filecheck processes if they hang. Also, information abo
teemperor added a comment.
I'm accepting this as seems to improve the situation, even though it's not a
complete fix.
(Not sure about the 2-minute timeout value though, but we'll see how the bots
react).
https://reviews.llvm.org/D52139
___
lldb-c
apolyakov updated this revision to Diff 166337.
apolyakov edited the summary of this revision.
apolyakov added a comment.
Thanks to @tatyana-krasnukha for the idea about a timer. Added a timer to
target-select-so-path test.
https://reviews.llvm.org/D52139
Files:
lit/tools/lldb-mi/target/inpu
Author: tkrasnukha
Date: Thu Sep 20 10:57:24 2018
New Revision: 342671
URL: http://llvm.org/viewvc/llvm-project?rev=342671&view=rev
Log:
Replace boolean parameter with enum value according r342633
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
Modified: lldb/tr
tatyana-krasnukha requested changes to this revision.
tatyana-krasnukha added a comment.
This revision now requires changes to proceed.
Alexander, please add a timeout to be sure that the test is not hanging even if
something goes wrong. A possible solution for Python 2:
F7266803: target-select-s
apolyakov added a comment.
Can you provide some logs? For example, you might be able to run this test
(llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and filecheck
processes if they hang. Also, information about which processes hang would be
useful too (lldb-mi or filecheck or
teemperor added a comment.
FYI, for me the test is still hanging on Arch Linux.
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
stella.stamenova added inline comments.
Comment at: lldb/trunk/source/Target/Target.cpp:1449
ObjectFile *executable_objfile = executable_sp->GetObjectFile();
+bool load_dependens;
+switch (load_dependent_files) {
I think it's a good idea to either in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342663: Refactor FindVariable() core functionality into
StackFrame out of SBFrame (authored by shafik, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
stella.stamenova added a comment.
This broke the windows build:
##[error]llvm\tools\lldb\source\plugins\process\windows\common\processwindows.cpp(840,0):
Error C2664: 'void lldb_private::Target::SetExecutableModule(lldb::ModuleSP
&,lldb_private::LoadDependentFiles)': cannot convert argument
Author: shafik
Date: Thu Sep 20 10:06:34 2018
New Revision: 342663
URL: http://llvm.org/viewvc/llvm-project?rev=342663&view=rev
Log:
Refactor FindVariable() core functionality into StackFrame out of SBFrame
rdar://problem/14365983
Patch by Shafik Yaghmour
Differential Revision: https://reviews.
clayborg accepted this revision.
clayborg added a comment.
Looks good
https://reviews.llvm.org/D52247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tatyana-krasnukha accepted this revision.
tatyana-krasnukha added a comment.
This revision is now accepted and ready to land.
These changes fixed the issue for me.
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm
shafik updated this revision to Diff 166308.
shafik added a comment.
Adjusting documentation based on feedback
https://reviews.llvm.org/D52247
Files:
include/lldb/Target/StackFrame.h
source/API/SBFrame.cpp
source/Target/StackFrame.cpp
Index: source/Target/StackFrame.cpp
=
apolyakov updated this revision to Diff 166290.
apolyakov retitled this revision from "[lldb-mi] Improve lldb-mi LIT tests" to
"[lldb-mi] Fix hanging of target-select-so-path.test".
apolyakov edited the summary of this revision.
apolyakov added a comment.
I found out that the reason of hanging of
tatyana-krasnukha updated this revision to Diff 166258.
tatyana-krasnukha added a comment.
Unfortunately, doing this only on `lldbHost` is not enough, because CMake
doesn't propagate include directories to dependent projects. I added these
lines to every project that includes "Editline.h".
Rep
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342634: [target] Change target create's behavior wrt
loading dependent files. (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51934?vs=166244&id=166245#t
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342633: [NFC] Turn "load dependent files" boolean
into an enum (authored by JDevlieghere, committed by ).
Herald added a s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342634: [target] Change target create's behavior wrt
loading dependent files. (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51934?vs=165727&id=166244#toc
Author: jdevlieghere
Date: Thu Sep 20 02:09:05 2018
New Revision: 342633
URL: http://llvm.org/viewvc/llvm-project?rev=342633&view=rev
Log:
[NFC] Turn "load dependent files" boolean into an enum
This is an NFC commit to refactor the "load dependent files" parameter
from a boolean to an enum value.
Author: jdevlieghere
Date: Thu Sep 20 02:09:13 2018
New Revision: 342634
URL: http://llvm.org/viewvc/llvm-project?rev=342634&view=rev
Log:
[target] Change target create's behavior wrt loading dependent files.
When creating a target, lldb loads all dependent files (i.e. libs in
LC_LOAD_DYLIB for M
30 matches
Mail list logo
