Author: friss
Date: Tue Sep 4 16:09:49 2018
New Revision: 341425
URL: http://llvm.org/viewvc/llvm-project?rev=341425&view=rev
Log:
Change TestCompletion to only ever look inside of BaseDir
TestCompletion was failing quite frequently on our Linux bots. Some tracing
revealed that when we are itera
aprantl created this revision.
aprantl added reviewers: jingham, jasonmolenda.
Herald added a subscriber: kubamracek.
This patch allows LLDB to print column info in backtraces et al. if available,
which is useful when the backtrace contains a frame like the following:
`f(can_crash(0), can_crash(
xbolva00 updated this revision to Diff 163882.
xbolva00 added a comment.
- Updated
https://reviews.llvm.org/D51615
Files:
source/Core/Debugger.cpp
Index: source/Core/Debugger.cpp
===
--- source/Core/Debugger.cpp
+++ source/Core
xbolva00 planned changes to this revision.
xbolva00 added a comment.
I will reuse the accepted code which arrives with
https://reviews.llvm.org/D51611 here also.
https://reviews.llvm.org/D51615
___
lldb-commits mailing list
lldb-commits@lists.llvm.
xbolva00 added a comment.
In https://reviews.llvm.org/D51604#1223455, @clayborg wrote:
> In https://reviews.llvm.org/D51604#1223451, @xbolva00 wrote:
>
> > Thanks for review, commited as https://reviews.llvm.org/rL341387
>
>
> If you include the text:
>
> Differential Revision: https://reviews.
clayborg added a comment.
In https://reviews.llvm.org/D51604#1223451, @xbolva00 wrote:
> Thanks for review, commited as https://reviews.llvm.org/rL341387
If you include the text:
Differential Revision: https://reviews.llvm.org/D51604
It will automatically close this and put in a comment wit
xbolva00 added a comment.
Thanks for review, commited as https://reviews.llvm.org/rL341387
https://reviews.llvm.org/D51604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D51604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
tatyana-krasnukha added a comment.
I have a third party module which implements a custom command for LLDB. The
command calls `str(target)`, `str(process)`, etc. for logging.
Anyway, every call to these functions will cause this crash to happen, because
PythonString is allocated after releasing
xbolva00 updated this revision to Diff 163852.
xbolva00 added a comment.
- Use abort
https://reviews.llvm.org/D51604
Files:
source/Utility/LLDBAssert.cpp
Index: source/Utility/LLDBAssert.cpp
===
--- source/Utility/LLDBAssert.cp
clayborg added a comment.
Yes abort is better as exit will cause the global C++ destructor chain to be
called. I was always thinking lldbassert() was aborting, but seeing as this is
not the case this could cause problems if you enable it as it will be a change.
Watch the buildbots carefully.
clayborg added a comment.
What kind of scenario causes this crash to happen? Seems like a hack?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
xbolva00 added a comment.
Ok, I messed up my LLDB svn a bit yesterday so probably I have found reason of
that strange behavior. I will re-setup it locally. Thanks.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51600
___
lldb-commits mailing l
lemo added inline comments.
Comment at: source/Utility/LLDBAssert.cpp:31
+"log, and as many details as possible\n";
+ exit(1);
}
abort() may be a better choice here (exit() path calls a lot of shutdown code
and it's not safe in a number of cases)
xbolva00 added a comment.
In https://reviews.llvm.org/D51600#1223303, @clayborg wrote:
> If you insert the text:
>
> Differential Revision: https://reviews.llvm.org/D51600
>
>
> Into your commit it will automatically show the SVN revision that was used
> for the commit. Can you attach the SVN
teemperor added a comment.
(you can also try arcanist which will do this automatically for you)
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
clayborg added a comment.
If you insert the text:
Differential Revision: https://reviews.llvm.org/D51600
Into your commit it will automatically show the SVN revision that was used for
the commit. Can you attach the SVN revision to this as a comment so we can
track this?
Repository:
rLLDB
clayborg added a comment.
Should be easy to write unit test for ExecutionContext.cpp. See
FileSpecTest.cpp for how to implement a unit test for a .cpp file.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D48704
___
lldb-commits mailing list
lld
clayborg added a comment.
Very nice. LGTM
https://reviews.llvm.org/D51557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xbolva00 updated this revision to Diff 163820.
xbolva00 added a comment.
- Addressed review comments
https://reviews.llvm.org/D51615
Files:
source/Core/Debugger.cpp
Index: source/Core/Debugger.cpp
===
--- source/Core/Debugger.c
tatyana-krasnukha added a comment.
Yes, and `%feature("nothreadallow")` doesn't allow to release GIL before
calling these functions - it prevents Swig from wrapping them into
SWIG_PYTHON_THREAD_BEGIN_ALLOW .. SWIG_PYTHON_THREAD_END_ALLOW block.
Repository:
rLLDB LLDB
https://reviews.llvm.o
xbolva00 updated this revision to Diff 163818.
xbolva00 added a comment.
- Use early return
https://reviews.llvm.org/D51604
Files:
source/Utility/LLDBAssert.cpp
Index: source/Utility/LLDBAssert.cpp
===
--- source/Utility/LLDBAs
clayborg added a comment.
Not sure about this one. IIUC we now wouldn't take the GIL for these functions
now and hope that the str() function doesn't do something that would require
thread safety?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51569
xbolva00 added inline comments.
Comment at: source/Core/Debugger.cpp:819
+ consoleMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+ SetUseColor(SetConsoleMode(hConsole, consoleMode));
+#endif
Should I rewrite it to more clear version like
bool ansi_supported = Set
xbolva00 added inline comments.
Comment at: source/Utility/LLDBAssert.cpp:23
if (expression)
;
else {
JDevlieghere wrote:
> I guess while we're at it we can turn this into an early return and use
> LLVM_LIKELY?
>
> ```
> if (LLVM_LIKELY(expression))
JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51602
___
lldb-commits mailing list
lldb-commits@lists.llv
JDevlieghere added inline comments.
Comment at: source/Utility/LLDBAssert.cpp:23
if (expression)
;
else {
I guess while we're at it we can turn this into an early return and use
LLVM_LIKELY?
```
if (LLVM_LIKELY(expression))
return;
```
Reposito
xbolva00 added a comment.
In https://reviews.llvm.org/D51615#1222730, @teemperor wrote:
> Thanks! Didn't know we can activate this setting for the user.
>
> Some questions though: Should we restore this setting to the original value
> after LLDB shuts down?
Good question. I tried run lldb, qui
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Please add the header also to the modulemap in Host (which has to be manually
written, as the Host module contains a lot of OS-specific headers):
`module SafeMachO { header "Hos
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Thanks! Didn't know we can activate this setting for the user.
Some questions though: Should we restore this setting to the original value
after LLDB shuts down? And what happe
xbolva00 created this revision.
xbolva00 added reviewers: JDevlieghere, teemperor.
Herald added subscribers: lldb-commits, abidh.
Windows console now supports supports ANSI escape codes, but we need to enable
it using SetConsoleMode with ENABLE_VIRTUAL_TERMINAL_PROCESSING flag.
https://docs.micr
31 matches
Mail list logo
