xbolva00 created this revision.
xbolva00 added reviewers: JDevlieghere, teemperor.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51604
Files:
source/Utility/LLDBAssert.cpp
Index: source/Utility/LLDBAssert.cpp
=
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
This whole code doesn't seem to have test coverage, so I'll not demand a test
for this. Also this patch is clearly fixing a typo, so let's get this in.
Repository:
rLLDB LLDB
https:/
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
teemperor added a comment.
Don't see a way to test this, as this can only be triggered when something in
LLDB is going really wrong. That piece of code also has zero test coverage, so
I'll just merge it in a few weeks or so unless someone comes up with a good way
to test this.
Repository:
r
teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added a subscriber: lldb-commits.
The check is inverted here: If we have error messages, we should print those
instead
of our default error message. But currently we print the default message when we
actually have a sensibl
teemperor added a comment.
My question about a good test case template was more directed at everyone :)
Repository:
rLLDB LLDB
https://reviews.llvm.org/D48704
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
xbolva00 created this revision.
xbolva00 added a reviewer: JDevlieghere.
Herald added a subscriber: lldb-commits.
Fixes implicit fall through warnings
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51601
Files:
source/Host/common/Editline.cpp
Index: source/Host/common/Editline.cpp
teemperor updated this revision to Diff 163741.
teemperor marked an inline comment as done.
teemperor added a comment.
- Now using a typedef instead of a macro.
- Using LLVM code style in Lazy.h
- Renamed UpdateX to CalculateX
https://reviews.llvm.org/D51557
Files:
include/lldb/DataFormatters
xbolva00 created this revision.
xbolva00 added a reviewer: JDevlieghere.
Herald added subscribers: lldb-commits, abidh.
/home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:656:59:
warning: enum constant in boolean context [-Wint-in-bool-con
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM, thx!
https://reviews.llvm.org/D51591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
tatyana-krasnukha accepted this revision.
tatyana-krasnukha added a subscriber: clayborg.
tatyana-krasnukha added a comment.
This revision is now accepted and ready to land.
Good to me, if no one is confused about absent general support of ARC target.
Please, add @clayborg to reviewers.
Reposit
xbolva00 updated this revision to Diff 163712.
xbolva00 added a comment.
- Added helper function
https://reviews.llvm.org/D51591
Files:
source/Host/common/PseudoTerminal.cpp
Index: source/Host/common/PseudoTerminal.cpp
===
--- s
apolyakov created this revision.
apolyakov added a reviewer: tatyana-krasnukha.
This patch specifies 'char' default sign on ARC.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51594
Files:
source/Utility/ArchSpec.cpp
Index: source/Utility/ArchSpec.cpp
==
JDevlieghere added a comment.
Any chance we could wrap this in a helper function?
https://reviews.llvm.org/D51591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov updated this revision to Diff 163708.
aleksandr.urakov added a comment.
Added the dumping AST ability to `lldb-test`; adding a corresponding test for
the patch.
https://reviews.llvm.org/D51162
Files:
include/lldb/Symbol/ClangASTContext.h
lit/SymbolFile/PDB/Inputs/AstRestor
xbolva00 updated this revision to Diff 163706.
xbolva00 added a comment.
- Removed include errno.h
https://reviews.llvm.org/D51591
Files:
source/Host/common/PseudoTerminal.cpp
Index: source/Host/common/PseudoTerminal.cpp
===
---
xbolva00 updated this revision to Diff 163705.
xbolva00 added a comment.
- Moved variable into #if block
https://reviews.llvm.org/D51591
Files:
source/Host/common/PseudoTerminal.cpp
Index: source/Host/common/PseudoTerminal.cpp
=
JDevlieghere added a comment.
Alright, thanks for the fix!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xbolva00 created this revision.
xbolva00 added a reviewer: JDevlieghere.
Herald added subscribers: lldb-commits, abidh.
LLVM provide (str)errno helpers, so convert code to use it.
Also fixes warning:
/home/xbolva00/LLVM/llvm/tools/lldb/source/Host/common/PseudoTerminal.cpp:248:25:
warning: ignor
xbolva00 added a comment.
In https://reviews.llvm.org/D51587#1222009, @JDevlieghere wrote:
> Looks reasonable. Did you run into this or is it just an improvement as you
> came across the code?
I just saw it as one of many GCC warnings when building lldb trunk.
Repository:
rLLDB LLDB
https
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks reasonable. Did you run into this or is it just an improvement as you
came across the code?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51587
xbolva00 created this revision.
xbolva00 added a reviewer: JDevlieghere.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51587
Files:
source/Symbol/Symtab.cpp
Index: source/Symbol/Symtab.cpp
=
jankratochvil updated this revision to Diff 163663.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51578
Files:
include/lldb/lldb-forward.h
source/Plugins/SymbolFile/DWARF/CMakeLists.txt
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
source/Plugins/SymbolFile/DWARF/DWARFASTP
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341296: [DWARF] Fix dwarf5-index-is-used.cpp (authored by
aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51208?vs=162336&id
Author: aleksandr.urakov
Date: Mon Sep 3 00:16:06 2018
New Revision: 341296
URL: http://llvm.org/viewvc/llvm-project?rev=341296&view=rev
Log:
[DWARF] Fix dwarf5-index-is-used.cpp
Summary:
`dwarf5-index-is-used.cpp` have been failing after rL340206, because `clang`
have stopped to emit pubnames b
aleksandr.urakov added a comment.
Ok, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
26 matches
Mail list logo
